From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqFUH-0001fx-Ny for qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:22:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqFUD-0005Qo-7n for qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:22:09 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:41534 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dqFUD-0005Q5-1E for qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:22:05 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v889J7Ga100063 for ; Fri, 8 Sep 2017 05:22:04 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0b-001b2d01.pphosted.com with ESMTP id 2cur2s98w2-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 08 Sep 2017 05:22:02 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Sep 2017 10:22:01 +0100 References: <20170905182546.00457332.cohuck@redhat.com> <20170906043108.GY31680@bjsdjshi@linux.vnet.ibm.com> <8946b1ec-4d14-c953-deab-aaded7cd2c9d@linux.vnet.ibm.com> <20170906162019.45eeec4a.cohuck@redhat.com> <20170907085831.GF31680@bjsdjshi@linux.vnet.ibm.com> <20170907122400.5b2e3faa.cohuck@redhat.com> <27b2addf-0d1c-81d7-1e82-1a8cdac70231@linux.vnet.ibm.com> <20170907134134.00f387e8.cohuck@redhat.com> <20170908034100.GH31680@bjsdjshi@linux.vnet.ibm.com> From: Halil Pasic Date: Fri, 8 Sep 2017 11:21:57 +0200 MIME-Version: 1.0 In-Reply-To: <20170908034100.GH31680@bjsdjshi@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: <381cb778-5679-634c-9d3d-7276f877da3a@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH 4/9] s390x: refactor error handling for SSCH and RSCH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , Dong Jia Shi , Pierre Morel , Xiao Feng Ren , qemu-devel@nongnu.org On 09/08/2017 05:41 AM, Dong Jia Shi wrote: > Let' me summarize here, in case I misunderstand things. Now we have > two ways to choose: > > A. Kernel: no change. > Qemu : handle -EFAULT as option 2 by generating a program check. > > B. Kernel: return -EFAULT > + > update the IRB area in the I/O region for option 1 to present > a unit check SCSW (with proper sense byte ECW), and for option > 2 to present a program check. > Qemu : handle -EFAULT according to the information that the IRB area > provided. This is not what I was trying to say. You got my message regarding A, but B was supposed to be understood like this. Keep the current handling for option 1, that is return -EFAULT. For option 2 do what the spec says, execute the program until the bad address and then generate a program-check (SCSW) once the bad stuff has it's turn. Thus the only change in QEMU would be handling -EFAULT with an unit check (because now it's just option 1). Halil