From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754874AbcESQVO (ORCPT ); Thu, 19 May 2016 12:21:14 -0400 Received: from gloria.sntech.de ([95.129.55.99]:56048 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754484AbcESQVM convert rfc822-to-8bit (ORCPT ); Thu, 19 May 2016 12:21:12 -0400 From: Heiko Stuebner To: Caesar Wang Cc: Mark Brown , linux-rockchip@lists.infradead.org, Rob Herring , devicetree@vger.kernel.org, Xu Jianqun , Kumar Gala , linux-kernel@vger.kernel.org, Ian Campbell , Pawel Moll , Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] spi/rockchip: add rk3036/rk3228/rk3368 socs for spi document Date: Thu, 19 May 2016 18:20:58 +0200 Message-ID: <3828505.WBLtTjjB7h@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <573DE3F7.6070300@rock-chips.com> References: <1463672824-15367-1-git-send-email-wxt@rock-chips.com> <3685935.dKdIbE8hXb@phil> <573DE3F7.6070300@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 20. Mai 2016, 00:04:07 schrieb Caesar Wang: > 在 2016年05月19日 23:51, Heiko Stuebner 写道: > > Am Donnerstag, 19. Mai 2016, 23:47:02 schrieb Caesar Wang: > >> We had supported the rk3036/rk3066/rk3188/rk3228/rk3288/rk3368/rk3399 > >> family SoCs in linux kernel. > >> > >> Let's add the other SoCs, in order to a better understanding from the > >> rockchip spi document. > >> > >> Signed-off-by: Caesar Wang > >> Cc: Rob Herring > >> Cc: Mark Brown > >> Cc: Heiko Stuebner > >> Cc: linux-rockchip@lists.infradead.org > >> --- > >> > >> Documentation/devicetree/bindings/spi/spi-rockchip.txt | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt > >> b/Documentation/devicetree/bindings/spi/spi-rockchip.txt index > >> 1b14d69..305b542 100644 > >> --- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt > >> +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt > >> @@ -6,9 +6,12 @@ and display controllers using the SPI communication > >> > >> interface. Required Properties: > >> - compatible: should be one of the following. > >> > >> + "rockchip,rk3036-spi" for rk3036. > > > > shouldn't the rk3036 also get the rk3066 fallback. Looking at the driver > > part (patch2) the rk3036 still is the same IP as for every other soc in > > here. > > Yep, the same IP. > > Do you think we should keep the below style? > > 1) > "rockchip,rk3036-spi", "rockchip,rk3066-spi" for rk3036. > "rockchip,rk3066-spi" for rk3066. > "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. > ... > > or > 2) > "rockchip,rk3066-spi" for rk3066. > "rockchip,rk3036-spi", "rockchip,rk3066-spi" for rk3036. > "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188 > .. > > or > 3) > "rockchip, rockchip-spi" for rk3036 rk3066....... > > Think about the 1) will be googd select. or (4) drop the fallbacks. We match against each compatible all the time anyway, so you could also simply do "rockchip,rk3036-spi" for rk3036 "rockchip,rk3066-spi" for rk3066 "rockchip,rk3188-spi" for rk3188 Maybe leave the fallbacks for existing socs, and just add the new ones without the fallbacks. rockchip,rockchip-spi is not future proof ... i.e. in some future soc somebody might want to exchange the IP block against a different one, so being specific saves us from hassle then :-) Heiko > >> "rockchip,rk3066-spi" for rk3066. > >> "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. > >> > >> + "rockchip,rk3228-spi", "rockchip,rk3066-spi" for rk3228. > >> > >> "rockchip,rk3288-spi", "rockchip,rk3066-spi" for rk3288. > >> > >> + "rockchip,rk3368-spi", "rockchip,rk3066-spi" for rk3368. > >> > >> "rockchip,rk3399-spi", "rockchip,rk3066-spi" for rk3399. > >> > >> - reg: physical base address of the controller and length of memory > >> > >> mapped region. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 1/3] spi/rockchip: add rk3036/rk3228/rk3368 socs for spi document Date: Thu, 19 May 2016 18:20:58 +0200 Message-ID: <3828505.WBLtTjjB7h@phil> References: <1463672824-15367-1-git-send-email-wxt@rock-chips.com> <3685935.dKdIbE8hXb@phil> <573DE3F7.6070300@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <573DE3F7.6070300-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Caesar Wang Cc: Mark Brown , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Xu Jianqun , Kumar Gala , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ian Campbell , Pawel Moll , Mark Rutland , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Am Freitag, 20. Mai 2016, 00:04:07 schrieb Caesar Wang: > =E5=9C=A8 2016=E5=B9=B405=E6=9C=8819=E6=97=A5 23:51, Heiko Stuebner =E5= =86=99=E9=81=93: > > Am Donnerstag, 19. Mai 2016, 23:47:02 schrieb Caesar Wang: > >> We had supported the rk3036/rk3066/rk3188/rk3228/rk3288/rk3368/rk3= 399 > >> family SoCs in linux kernel. > >>=20 > >> Let's add the other SoCs, in order to a better understanding from = the > >> rockchip spi document. > >>=20 > >> Signed-off-by: Caesar Wang > >> Cc: Rob Herring > >> Cc: Mark Brown > >> Cc: Heiko Stuebner > >> Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > >> --- > >>=20 > >> Documentation/devicetree/bindings/spi/spi-rockchip.txt | 3 +++ > >> 1 file changed, 3 insertions(+) > >>=20 > >> diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.tx= t > >> b/Documentation/devicetree/bindings/spi/spi-rockchip.txt index > >> 1b14d69..305b542 100644 > >> --- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt > >> +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt > >> @@ -6,9 +6,12 @@ and display controllers using the SPI communicati= on > >>=20 > >> interface. Required Properties: > >> - compatible: should be one of the following. > >>=20 > >> + "rockchip,rk3036-spi" for rk3036. > >=20 > > shouldn't the rk3036 also get the rk3066 fallback. Looking at the d= river > > part (patch2) the rk3036 still is the same IP as for every other so= c in > > here. >=20 > Yep, the same IP. >=20 > Do you think we should keep the below style? >=20 > 1) > "rockchip,rk3036-spi", "rockchip,rk3066-spi" for rk3036. > "rockchip,rk3066-spi" for rk3066. > "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. > ... >=20 > or > 2) > "rockchip,rk3066-spi" for rk3066. > "rockchip,rk3036-spi", "rockchip,rk3066-spi" for rk3036. > "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188 > .. >=20 > or > 3) > "rockchip, rockchip-spi" for rk3036 rk3066....... >=20 > Think about the 1) will be googd select. or (4) drop the fallbacks. We match against each compatible all the time=20 anyway, so you could also simply do "rockchip,rk3036-spi" for rk3036 "rockchip,rk3066-spi" for rk3066 "rockchip,rk3188-spi" for rk3188 Maybe leave the fallbacks for existing socs, and just add the new ones=20 without the fallbacks. rockchip,rockchip-spi is not future proof ... i.e. in some future soc=20 somebody might want to exchange the IP block against a different one, s= o=20 being specific saves us from hassle then :-) Heiko > >> "rockchip,rk3066-spi" for rk3066. > >> "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. > >>=20 > >> + "rockchip,rk3228-spi", "rockchip,rk3066-spi" for rk3228. > >>=20 > >> "rockchip,rk3288-spi", "rockchip,rk3066-spi" for rk3288. > >>=20 > >> + "rockchip,rk3368-spi", "rockchip,rk3066-spi" for rk3368. > >>=20 > >> "rockchip,rk3399-spi", "rockchip,rk3066-spi" for rk3399. > >> =20 > >> - reg: physical base address of the controller and length of mem= ory > >>=20 > >> mapped region. -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Thu, 19 May 2016 18:20:58 +0200 Subject: [PATCH 1/3] spi/rockchip: add rk3036/rk3228/rk3368 socs for spi document In-Reply-To: <573DE3F7.6070300@rock-chips.com> References: <1463672824-15367-1-git-send-email-wxt@rock-chips.com> <3685935.dKdIbE8hXb@phil> <573DE3F7.6070300@rock-chips.com> Message-ID: <3828505.WBLtTjjB7h@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Freitag, 20. Mai 2016, 00:04:07 schrieb Caesar Wang: > ? 2016?05?19? 23:51, Heiko Stuebner ??: > > Am Donnerstag, 19. Mai 2016, 23:47:02 schrieb Caesar Wang: > >> We had supported the rk3036/rk3066/rk3188/rk3228/rk3288/rk3368/rk3399 > >> family SoCs in linux kernel. > >> > >> Let's add the other SoCs, in order to a better understanding from the > >> rockchip spi document. > >> > >> Signed-off-by: Caesar Wang > >> Cc: Rob Herring > >> Cc: Mark Brown > >> Cc: Heiko Stuebner > >> Cc: linux-rockchip at lists.infradead.org > >> --- > >> > >> Documentation/devicetree/bindings/spi/spi-rockchip.txt | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/spi/spi-rockchip.txt > >> b/Documentation/devicetree/bindings/spi/spi-rockchip.txt index > >> 1b14d69..305b542 100644 > >> --- a/Documentation/devicetree/bindings/spi/spi-rockchip.txt > >> +++ b/Documentation/devicetree/bindings/spi/spi-rockchip.txt > >> @@ -6,9 +6,12 @@ and display controllers using the SPI communication > >> > >> interface. Required Properties: > >> - compatible: should be one of the following. > >> > >> + "rockchip,rk3036-spi" for rk3036. > > > > shouldn't the rk3036 also get the rk3066 fallback. Looking at the driver > > part (patch2) the rk3036 still is the same IP as for every other soc in > > here. > > Yep, the same IP. > > Do you think we should keep the below style? > > 1) > "rockchip,rk3036-spi", "rockchip,rk3066-spi" for rk3036. > "rockchip,rk3066-spi" for rk3066. > "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. > ... > > or > 2) > "rockchip,rk3066-spi" for rk3066. > "rockchip,rk3036-spi", "rockchip,rk3066-spi" for rk3036. > "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188 > .. > > or > 3) > "rockchip, rockchip-spi" for rk3036 rk3066....... > > Think about the 1) will be googd select. or (4) drop the fallbacks. We match against each compatible all the time anyway, so you could also simply do "rockchip,rk3036-spi" for rk3036 "rockchip,rk3066-spi" for rk3066 "rockchip,rk3188-spi" for rk3188 Maybe leave the fallbacks for existing socs, and just add the new ones without the fallbacks. rockchip,rockchip-spi is not future proof ... i.e. in some future soc somebody might want to exchange the IP block against a different one, so being specific saves us from hassle then :-) Heiko > >> "rockchip,rk3066-spi" for rk3066. > >> "rockchip,rk3188-spi", "rockchip,rk3066-spi" for rk3188. > >> > >> + "rockchip,rk3228-spi", "rockchip,rk3066-spi" for rk3228. > >> > >> "rockchip,rk3288-spi", "rockchip,rk3066-spi" for rk3288. > >> > >> + "rockchip,rk3368-spi", "rockchip,rk3066-spi" for rk3368. > >> > >> "rockchip,rk3399-spi", "rockchip,rk3066-spi" for rk3399. > >> > >> - reg: physical base address of the controller and length of memory > >> > >> mapped region.