From: Christian Eggers <ceggers@arri.de>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@kernel.org>, <stable@vger.kernel.org>,
"Hartmut Knaack" <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: trigger: sysfs: Disable irqs before calling iio_trigger_poll()
Date: Wed, 12 Aug 2020 13:01:51 +0200 [thread overview]
Message-ID: <3847827.rc3nFVyU9p@n95hx1g2> (raw)
In-Reply-To: <a59d204e-aeb0-2649-5e6f-f07815713d1a@metafoo.de>
Hi Lars
On Monday, 3 August 2020, 08:52:54 CEST, Lars-Peter Clausen wrote:
> On 8/3/20 8:44 AM, Christian Eggers wrote:
> > ...
> > is my patch sufficient, or would you prefer a different solution?
>
> The code in normal upstream is correct, there is no need to patch it
> since iio_sysfs_trigger_work() always runs with IRQs disabled.
>
> >> Are you using a non-upstream kernel? Maybe a RT kernel?
> >
> > I use v5.4.<almost-latest>-rt
>
> That explains it. Have a look at
> 0200-irqwork-push-most-work-into-softirq-context.patch.
>
> The right fix for this issue is to add the following snippet to the RT
> patchset.
>
> diff --git a/drivers/iio/trigger/iio-trig-sysfs.c
> b/drivers/iio/trigger/iio-trig-sysfs.c
> --- a/drivers/iio/trigger/iio-trig-sysfs.c
> +++ b/drivers/iio/trigger/iio-trig-sysfs.c
> @@ -161,6 +161,7 @@ static int iio_sysfs_trigger_probe(int id)
> iio_trigger_set_drvdata(t->trig, t);
>
> init_irq_work(&t->work, iio_sysfs_trigger_work);
> + t->work.flags = IRQ_WORK_HARD_IRQ;
>
> ret = iio_trigger_register(t->trig);
> if (ret)
I can confirm that this works for iio-trig-sysfs on 5.4.54-rt32. Currently I
do not use iio-trig-hrtimer, but if I remember correctly, the problem was also
present there.
Do you want to apply your patch for mainline? In contrast to v5.4,
IRQ_WORK_HARD_IRQ is already available there (moved to smp_types.h).
Unfortunately I cannot test it on mainline for now, as my BSP stuff is not
ported yet.
Best regards
Christian
next prev parent reply other threads:[~2020-08-12 11:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 14:57 [PATCH] iio: trigger: sysfs: Disable irqs before calling iio_trigger_poll() Christian Eggers
2020-08-01 16:02 ` Jonathan Cameron
2020-08-02 15:05 ` Lars-Peter Clausen
2020-08-03 5:16 ` Christian Eggers
2020-08-03 6:37 ` Lars-Peter Clausen
2020-08-03 6:44 ` Christian Eggers
2020-08-03 6:52 ` Lars-Peter Clausen
2020-08-12 11:01 ` Christian Eggers [this message]
2020-08-13 7:23 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3847827.rc3nFVyU9p@n95hx1g2 \
--to=ceggers@arri.de \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.