From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D76CC433EF for ; Fri, 25 Feb 2022 07:38:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232889AbiBYHjY (ORCPT ); Fri, 25 Feb 2022 02:39:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232659AbiBYHjY (ORCPT ); Fri, 25 Feb 2022 02:39:24 -0500 Received: from mx1.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0152177764; Thu, 24 Feb 2022 23:38:46 -0800 (PST) Received: from [192.168.0.2] (ip5f5aee37.dynamic.kabel-deutschland.de [95.90.238.55]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 1671961EA1928; Fri, 25 Feb 2022 08:38:45 +0100 (CET) Message-ID: <38520a76-db53-fc6c-8af4-f72fa7a87321@molgen.mpg.de> Date: Fri, 25 Feb 2022 08:38:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 3/4] acpi: exsystem: Warn about sleeps greater than 50 ms Content-Language: en-US To: Robert Moore , "Rafael J. Wysocki" , Len Brown Cc: linux-acpi@vger.kernel.org, devel@acpica.org, linux-kernel@vger.kernel.org References: <20220224113807.91771-1-pmenzel@molgen.mpg.de> <20220224113807.91771-3-pmenzel@molgen.mpg.de> From: Paul Menzel In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Dear Robert, Am 24.02.22 um 17:19 schrieb Moore, Robert: > So, this is the current implementation: > > /* > * For compatibility with other ACPI implementations and to prevent > * accidental deep sleeps, limit the sleep time to something reasonable. > */ > if (HowLong > ACPI_MAX_SLEEP) > { > HowLong = ACPI_MAX_SLEEP; > } > > AcpiOsSleep (HowLong); > > Where ACPI_MAX_SLEEP is: > > #define ACPI_MAX_SLEEP 2000 /* 2000 millisec == two seconds */ Exactly. I am not changing it though, but just add a warning. Kind regards, Paul > -----Original Message----- > From: Paul Menzel > Sent: Thursday, February 24, 2022 3:38 AM > To: Moore, Robert ; Wysocki, Rafael J ; Len Brown > Cc: Paul Menzel ; linux-acpi@vger.kernel.org; devel@acpica.org; linux-kernel@vger.kernel.org > Subject: [PATCH 3/4] acpi: exsystem: Warn about sleeps greater than 50 ms > > Quick boottime is important, so warn about sleeps greater than 50 ms in ACPI. > > 50 ms is still long compared to distribution Linux kernels reaching initrd in 350 ms, so should probably changed to 10 ms, so people are aware about this. > > Signed-off-by: Paul Menzel > --- > drivers/acpi/acpica/exsystem.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/acpi/acpica/exsystem.c b/drivers/acpi/acpica/exsystem.c index 00f66af31ffa..bdffb8aac05c 100644 > --- a/drivers/acpi/acpica/exsystem.c > +++ b/drivers/acpi/acpica/exsystem.c > @@ -167,6 +167,11 @@ acpi_status acpi_ex_system_do_sleep(u64 how_long_ms) > > acpi_ex_exit_interpreter(); > > + if (how_long_ms > 50) { > + ACPI_WARNING((AE_INFO, > + "Time parameter %llu > 50 ms. Please contact firmware vendor for more responsive system.", how_long_ms)); > + } > + > /* > * For compatibility with other ACPI implementations and to prevent > * accidental deep sleeps, limit the sleep time to something reasonable. > -- > 2.35.1