From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7D80C43334 for ; Wed, 1 Jun 2022 22:45:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232401AbiFAWpa (ORCPT ); Wed, 1 Jun 2022 18:45:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232398AbiFAWpY (ORCPT ); Wed, 1 Jun 2022 18:45:24 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 93DFE1D5A81; Wed, 1 Jun 2022 15:45:22 -0700 (PDT) Received: from [192.168.254.32] (unknown [47.189.24.195]) by linux.microsoft.com (Postfix) with ESMTPSA id 6650720BE540; Wed, 1 Jun 2022 15:45:21 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6650720BE540 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1654123522; bh=M8pAiYfNyt6tZDL5lQY+5VM1wBjeicnIUXpnmkImi5A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ckxOtl7BsJyVxjaoRnh5pMaaktmJ/pjDcGRl3x18qDfTBCcDwA/e6jdBoQppyv1TQ VBLe24/k8JkhTXXeOwB2Chi/OaMITW/W9ar2zWl79bZpILfzmO7gEvrzUGLJTGMOYj IBWW1HK/aiDnG1Q0S0DIxe1xPywi+l9gUqEx0IIc= Message-ID: <38546223-7585-bfad-b553-9739d31d7fbf@linux.microsoft.com> Date: Wed, 1 Jun 2022 17:45:20 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RFC PATCH v2 09/20] objtool: arm64: Implement command to invoke the decoder Content-Language: en-US To: Peter Zijlstra Cc: Mark Brown , jpoimboe@redhat.com, chenzhongjin@huawei.com, mark.rutland@arm.com, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jamorris@linux.microsoft.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220524001637.1707472-1-madvenka@linux.microsoft.com> <20220524001637.1707472-10-madvenka@linux.microsoft.com> From: "Madhavan T. Venkataraman" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/30/22 02:51, Peter Zijlstra wrote: > On Sun, May 29, 2022 at 09:49:44AM -0500, Madhavan T. Venkataraman wrote: >> >> >> On 5/24/22 09:09, Mark Brown wrote: >>> On Mon, May 23, 2022 at 07:16:26PM -0500, madvenka@linux.microsoft.com wrote: >>>> From: "Madhavan T. Venkataraman" >>>> >>>> Implement a built-in command called cmd_fpv() that can be invoked as >>>> follows: >>>> >>>> objtool fpv generate file.o >>>> >>>> The built-in command invokes decode_instructions() to walk each function >>>> and decode the instructions of the function. >>> >>> In commit b51277eb9775ce91 ("objtool: Ditch subcommands") Josh removed >>> subcommands so this interface is going to need a rethink. >> >> Thanks for mentioning this. I will sync my patchset to the latest and send out version 3. > > Before you do; why are you duplicating lots of validate_branch() ? Why > can't you use the regular code to generate ORC data? > > I'm really not happy about all this. Hi Peter, I am preparing a detailed response to this explaining why I have not used validate_branch(). The short answer is that no validation is required for my approach. But I will send my detailed response shortly. Thanks. Madhavan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39059C43334 for ; Wed, 1 Jun 2022 22:46:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uA4qwlFmlBQAU9d/QBXRMimIPkUwvgyFL8DQCOCqMC8=; b=JvjNzNujViY8fU zN2aKMjkx4lYCYWVWZh4exVcH5QfZDqmwxbG9HoJQtcFaEkxIF5SeEqLY999kiRGRSPyHZk4PMxAE B9Ni/WNjJ6gGTFw1pU2IpzQNi5pD3l0CSS41vdrVFZlnd5OuRxggbmloBd/PM2M1dEcgjmUodKSe9 GatjmnSNT31LD3N0Y0LuyoP9B89eMo10iv0nXcOpG/fe1OQQMH2v5aSgWAESlbU4QoypURCDsDsZn gjpokpwZe2HPzU7bd9XBR85U4O1NpkM8A/Z3e9qKqOnZ5fCpdScBtK10gW2Gc2LMmGdNchsmCSs84 rso68l3/NY/PApwc54Vw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwX5j-000hNA-PF; Wed, 01 Jun 2022 22:45:27 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwX5g-000hMU-Oc for linux-arm-kernel@lists.infradead.org; Wed, 01 Jun 2022 22:45:26 +0000 Received: from [192.168.254.32] (unknown [47.189.24.195]) by linux.microsoft.com (Postfix) with ESMTPSA id 6650720BE540; Wed, 1 Jun 2022 15:45:21 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6650720BE540 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1654123522; bh=M8pAiYfNyt6tZDL5lQY+5VM1wBjeicnIUXpnmkImi5A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ckxOtl7BsJyVxjaoRnh5pMaaktmJ/pjDcGRl3x18qDfTBCcDwA/e6jdBoQppyv1TQ VBLe24/k8JkhTXXeOwB2Chi/OaMITW/W9ar2zWl79bZpILfzmO7gEvrzUGLJTGMOYj IBWW1HK/aiDnG1Q0S0DIxe1xPywi+l9gUqEx0IIc= Message-ID: <38546223-7585-bfad-b553-9739d31d7fbf@linux.microsoft.com> Date: Wed, 1 Jun 2022 17:45:20 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [RFC PATCH v2 09/20] objtool: arm64: Implement command to invoke the decoder Content-Language: en-US To: Peter Zijlstra Cc: Mark Brown , jpoimboe@redhat.com, chenzhongjin@huawei.com, mark.rutland@arm.com, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jamorris@linux.microsoft.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220524001637.1707472-1-madvenka@linux.microsoft.com> <20220524001637.1707472-10-madvenka@linux.microsoft.com> From: "Madhavan T. Venkataraman" In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_154524_881923_F1BB29DA X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/30/22 02:51, Peter Zijlstra wrote: > On Sun, May 29, 2022 at 09:49:44AM -0500, Madhavan T. Venkataraman wrote: >> >> >> On 5/24/22 09:09, Mark Brown wrote: >>> On Mon, May 23, 2022 at 07:16:26PM -0500, madvenka@linux.microsoft.com wrote: >>>> From: "Madhavan T. Venkataraman" >>>> >>>> Implement a built-in command called cmd_fpv() that can be invoked as >>>> follows: >>>> >>>> objtool fpv generate file.o >>>> >>>> The built-in command invokes decode_instructions() to walk each function >>>> and decode the instructions of the function. >>> >>> In commit b51277eb9775ce91 ("objtool: Ditch subcommands") Josh removed >>> subcommands so this interface is going to need a rethink. >> >> Thanks for mentioning this. I will sync my patchset to the latest and send out version 3. > > Before you do; why are you duplicating lots of validate_branch() ? Why > can't you use the regular code to generate ORC data? > > I'm really not happy about all this. Hi Peter, I am preparing a detailed response to this explaining why I have not used validate_branch(). The short answer is that no validation is required for my approach. But I will send my detailed response shortly. Thanks. Madhavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel