From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ivanoab7.miniserver.com ([37.128.132.42] helo=www.kot-begemot.co.uk) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4rbr-00014R-Bc for linux-um@lists.infradead.org; Thu, 20 Feb 2020 19:35:44 +0000 Subject: Re: [PATCH 1/2] um: Don't overwrite ethtool driver version References: <20200220084014.238768-1-leon@kernel.org> <20200220084014.238768-2-leon@kernel.org> From: Anton Ivanov Message-ID: <3857ae89-3cfc-a409-e0d6-ce2dab008d9b@cambridgegreys.com> Date: Thu, 20 Feb 2020 19:35:38 +0000 MIME-Version: 1.0 In-Reply-To: <20200220084014.238768-2-leon@kernel.org> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Leon Romanovsky , Jeff Dike , Richard Weinberger Cc: Leon Romanovsky , linux-um On 20/02/2020 08:40, Leon Romanovsky wrote: > From: Leon Romanovsky > > > In-tree drivers don't need to manage internal version because > they are aligned to the global Linux kernel version, which is > reported by default with "ethtool -i". > > Signed-off-by: Leon Romanovsky > --- > arch/um/drivers/net_kern.c | 1 - > arch/um/drivers/vector_kern.c | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c > index 35ebeebfc1a8..af07733c2dc8 100644 > --- a/arch/um/drivers/net_kern.c > +++ b/arch/um/drivers/net_kern.c > @@ -266,7 +266,6 @@ static void uml_net_get_drvinfo(struct net_device *dev, > struct ethtool_drvinfo *info) > { > strlcpy(info->driver, DRIVER_NAME, sizeof(info->driver)); > - strlcpy(info->version, "42", sizeof(info->version)); > } > > static const struct ethtool_ops uml_net_ethtool_ops = { > diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c > index 0ff86391f77d..9693dfca7651 100644 > --- a/arch/um/drivers/vector_kern.c > +++ b/arch/um/drivers/vector_kern.c > @@ -46,7 +46,6 @@ > > > #define DRIVER_NAME "uml-vector" > -#define DRIVER_VERSION "01" > struct vector_cmd_line_arg { > struct list_head list; > int unit; > @@ -1378,7 +1377,6 @@ static void vector_net_get_drvinfo(struct net_device *dev, > struct ethtool_drvinfo *info) > { > strlcpy(info->driver, DRIVER_NAME, sizeof(info->driver)); > - strlcpy(info->version, DRIVER_VERSION, sizeof(info->version)); > } > > static int vector_net_load_bpf_flash(struct net_device *dev, > -- > 2.24.1 > > Acked-by: Anton Ivanov -- Anton R. Ivanov Cambridge Greys Limited, England and Wales company No 10273661 http://www.cambridgegreys.com/ _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um