Re: [PATCH v2 06/13] optee: add domain contexts

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 05/09/18 15:10, Julien Grall wrote:
> Hi,
>
> On 09/03/2018 05:54 PM, Volodymyr Babchuk wrote:
>> OP-TEE meditor needs to store per-domain context, as will be seen
>
> s/meditor/mediator/
>
>> in the next patches. At this moment it stores only reference to domain.
>>
>> This allows us to filter out calls from domains that are not allowed
>> to work with OP-TEE.
>>
>> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>> ---
>>   xen/arch/arm/tee/optee.c | 66
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 66 insertions(+)
>>
>> diff --git a/xen/arch/arm/tee/optee.c b/xen/arch/arm/tee/optee.c
>> index 48bff5d..c895a99 100644
>> --- a/xen/arch/arm/tee/optee.c
>> +++ b/xen/arch/arm/tee/optee.c
>> @@ -19,6 +19,14 @@
>>   #include <asm/tee/optee_msg.h>
>>   #include <asm/tee/optee_smc.h>
>>   +struct domain_ctx {
>
> I would prefer if the structure has optee in its name such as
> optee_domain.
>
> We also tend to abbreviate context in Xen using the ctxt.

I'd argue that "ctx" is the better way of abbreviating context.  It's
far more usual, and easier to type.  (That said, optee_domain would be
the most consistent name with the rest of the codebase in this case)

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel