From: Jan Beulich <jbeulich@suse.com>
To: Wei Liu <wl@xen.org>
Cc: "Wei Liu" <liuwe@microsoft.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Paul Durrant" <pdurrant@amazon.com>,
"Michael Kelley" <mikelley@microsoft.com>,
"Xen Development List" <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v4 1/3] x86/hypervisor: pass flags to hypervisor_flush_tlb
Date: Tue, 10 Mar 2020 10:58:09 +0100 [thread overview]
Message-ID: <3864acf5-aa3e-7849-56e4-11d7cace70db@suse.com> (raw)
In-Reply-To: <20200309172552.i273f2re4y6uuklr@debian>
On 09.03.2020 18:25, Wei Liu wrote:
> On Mon, Mar 09, 2020 at 05:38:12PM +0100, Jan Beulich wrote:
>> On 19.02.2020 12:44, Wei Liu wrote:
>>> --- a/xen/include/asm-x86/flushtlb.h
>>> +++ b/xen/include/asm-x86/flushtlb.h
>>> @@ -123,6 +123,9 @@ void switch_cr3_cr4(unsigned long cr3, unsigned long cr4);
>>> /* Flush all HVM guests linear TLB (using ASID/VPID) */
>>> #define FLUSH_GUESTS_TLB 0x4000
>>>
>>> +#define FLUSH_TLB_FLAGS_MASK (FLUSH_TLB | FLUSH_TLB_GLOBAL | FLUSH_VA_VALID | \
>>> + FLUSH_ORDER_MASK)
>>
>> I don't think FLUSH_ORDER_MASK should be part of this, as it's not
>> exclusively TLB-flush related.
>
> My intention was to capture all flags pertinent to TLB flushes. I didn't
> mean they were exclusively TLB flush related.
That's what I understood, but the result is leading to possible ambiguity.
Thinking about it again, ...
> I can remove the order mask from the list of flags. Not a big deal.
... I'm afraid I also have to ask for FLUSH_VA_VALID to be dropped,
as that one's not TLB flush related at all. Instead it identifies
whether the linear address provided _still has_ a valid mapping
(rather than there being an address provided at all), such that
CLFLUSH bases cache flushing would be usable. At that point I
wonder whether the separate constant is still of much use at all.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-03-10 9:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 11:44 [Xen-devel] [PATCH v4 0/3] Xen on Hyper-V: Implement L0 assisted TLB flush Wei Liu
2020-02-19 11:44 ` [Xen-devel] [PATCH v4 1/3] x86/hypervisor: pass flags to hypervisor_flush_tlb Wei Liu
2020-03-09 16:38 ` Jan Beulich
2020-03-09 17:25 ` Wei Liu
2020-03-10 9:58 ` Jan Beulich [this message]
2020-03-10 13:39 ` Wei Liu
2020-02-19 11:44 ` [Xen-devel] [PATCH v4 2/3] x86/hyperv: skeleton for L0 assisted TLB flush Wei Liu
2020-02-19 11:44 ` [Xen-devel] [PATCH v4 3/3] x86/hyperv: " Wei Liu
2020-02-19 17:52 ` Roger Pau Monné
2020-02-20 10:53 ` Durrant, Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3864acf5-aa3e-7849-56e4-11d7cace70db@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=liuwe@microsoft.com \
--cc=mikelley@microsoft.com \
--cc=pdurrant@amazon.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.