All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: "Liu, Changcheng" <changcheng.liu@intel.com>,
	linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, gregkh@linuxfoundation.org,
	pombredanne@nexb.com, neilb@suse.com, akpm@linux-foundation.org
Subject: Re: [PATCH] scripts/faddr2line: fix CROSS_COMPILE unset error
Date: Wed, 06 Dec 2017 20:16:26 +0100	[thread overview]
Message-ID: <3875933.96IucGWEYa@blindfold> (raw)
In-Reply-To: <20171206013022.GA83929@sofia>

Am Mittwoch, 6. Dezember 2017, 02:30:22 CET schrieb Liu, Changcheng:
> faddr2line hit var unbound error When CROSS_COMPILE
> isn't set since nounset option is set in bash script.
> 
> Signed-off-by: Liu Changcheng <changcheng.liu@intel.com>
> Reported-by: Richard Weinberger <richard.weinberger@gmail.com>
> 
> diff --git a/scripts/faddr2line b/scripts/faddr2line
> index 39e07d8..7721d5b 100755
> --- a/scripts/faddr2line
> +++ b/scripts/faddr2line
> @@ -44,10 +44,10 @@
>  set -o errexit
>  set -o nounset
> 
> -READELF="${CROSS_COMPILE}readelf"
> -ADDR2LINE="${CROSS_COMPILE}addr2line"
> -SIZE="${CROSS_COMPILE}size"
> -NM="${CROSS_COMPILE}nm"
> +READELF="${CROSS_COMPILE:-}readelf"
> +ADDR2LINE="${CROSS_COMPILE:-}addr2line"
> +SIZE="${CROSS_COMPILE:-}size"
> +NM="${CROSS_COMPILE:-}nm"
> 
>  command -v awk >/dev/null 2>&1 || die "awk isn't installed"
>  command -v ${READELF} >/dev/null 2>&1 || die "readelf isn't installed"

Fixes: 95a879825419 ("scripts/faddr2line: extend usage on generic arch")
Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

      reply	other threads:[~2017-12-06 19:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06  1:30 [PATCH] scripts/faddr2line: fix CROSS_COMPILE unset error Liu, Changcheng
2017-12-06 19:16 ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3875933.96IucGWEYa@blindfold \
    --to=richard@nod.at \
    --cc=akpm@linux-foundation.org \
    --cc=changcheng.liu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.com \
    --cc=pombredanne@nexb.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.