From: Sergey Shtylyov <s.shtylyov@omprussia.ru>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH] scsi: hisi_sas: fix IRQ checks
Date: Sun, 4 Apr 2021 18:39:36 +0300 [thread overview]
Message-ID: <38771b7a-fbb5-19ca-37c1-175f912cb7d6@omprussia.ru> (raw)
In-Reply-To: <CAHp75VfZ+B-MNZ57BzMxgTvGXQ7Ek-DU2T4UVQ2tQpPoOmfcTg@mail.gmail.com>
On 4/4/21 2:48 PM, Andy Shevchenko wrote:
[...]
> Commit df2d8213d9e3 ("hisi_sas: use platform_get_irq()") failed to take
> into account that irq_of_parse_and_map() and platform_get_irq() have a
> different way of indicating an error: the former returns 0 and the latter
> returns a negative error code. Fix up the IRQ checks!
>
>
> Shouldn’t you unshadow error codes at the same time?
>
> return -ENOENT; ==> return IRQ;
I'm going to send that as a follow-up (cleanup) patch -- we also have devm_request_irq() with
the result overridden for no good reason...
> Fixes: df2d8213d9e3 ("hisi_sas: use platform_get_irq()")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru <mailto:s.shtylyov@omprussia.ru>>
[...]
MBR, Sergei
next prev parent reply other threads:[~2021-04-04 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 20:43 [PATCH] scsi: hisi_sas: fix IRQ checks Sergey Shtylyov
[not found] ` <CAHp75VfZ+B-MNZ57BzMxgTvGXQ7Ek-DU2T4UVQ2tQpPoOmfcTg@mail.gmail.com>
2021-04-04 15:39 ` Sergey Shtylyov [this message]
2021-04-05 14:27 ` Sergey Shtylyov
2021-04-06 7:43 ` John Garry
2021-04-10 18:58 ` Sergey Shtylyov
2021-04-16 2:51 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38771b7a-fbb5-19ca-37c1-175f912cb7d6@omprussia.ru \
--to=s.shtylyov@omprussia.ru \
--cc=andy.shevchenko@gmail.com \
--cc=avri.altman@wdc.com \
--cc=jejb@linux.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.