From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDD93C4707F for ; Tue, 25 May 2021 14:16:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF8E7613F1 for ; Tue, 25 May 2021 14:16:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233691AbhEYORb (ORCPT ); Tue, 25 May 2021 10:17:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43491 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233756AbhEYORZ (ORCPT ); Tue, 25 May 2021 10:17:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621952154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nlqULTQKgpp23k3zz821ZdlDSBodLG51nX7mC5euY1A=; b=bgTOBlUq8wjAAoWXAxN/yPI4xSeBSrqtRkXFeMR0Ws9hyrIH4lm5dsFRuLahOg8z6+o4IF dMFmAVUVivgI16Fej+hxUMgNNj2/0QWIaffuIMptSUP1IVF6oO3/0O4sTrQfOx+jAaJwxT kkedZNRRS/4HLfhvJ29QrBiLT6hBFXE= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-221-0-TFQmi6Ojml9VDPpZDUbQ-1; Tue, 25 May 2021 10:15:51 -0400 X-MC-Unique: 0-TFQmi6Ojml9VDPpZDUbQ-1 Received: by mail-qt1-f198.google.com with SMTP id h7-20020ac846c70000b0290231af0e7829so32348qto.7 for ; Tue, 25 May 2021 07:15:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=nlqULTQKgpp23k3zz821ZdlDSBodLG51nX7mC5euY1A=; b=JaeKPkpAHwXFCqR6ZRMZ18n04l9lNKfgdFPv4Ty6pTmZ9E/CeeXsnIrnjAEQVyBaVh ZhUTdvTCRg42gepLPCuKRTSajUwwEHOC9wJZvLIer3jwgUSCibuD9xyTi2gd4nyhcDq+ bGRWzGp444DdVr6o0XelJIcn3tvYPh2/Tk7Nh0iKxZWNS6H3Kjk1ySBKRp2iD0mEpIia t/hXy5U48pJbB3w2EVTJ76gk8vP6RWbDabg3BKR5dzoIBpYLv4mYeoW5lJzBV71XCUdr mjazQLuYyid7G9AaiHqKUR1q4lubgwYznPowWZVFBrKyBEnxExvKPa3OqubM01xXd4w9 LeuA== X-Gm-Message-State: AOAM533QFMwUMaDVbq/z+oCk4ELzunEuZcixXOZgLVpqK9b/3pK/urix iC1CDEwbn3H5TMRFsrrhp/zF15S6lNdHlG0W7wGP5yS3oldONtwAvcuVdVmYwWUlNXlVWCTAu+d GzTpJ18fw7TMY3OQjfjs3ErCA X-Received: by 2002:ac8:7757:: with SMTP id g23mr31954677qtu.46.1621952149697; Tue, 25 May 2021 07:15:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuhv77RHaTLDz2vpI9KwRMUqN7iMGKAvxMiOkVCrF6SaL1qezOHGzvuvnqSYnRkR3GljYCiA== X-Received: by 2002:ac8:7757:: with SMTP id g23mr31954652qtu.46.1621952149414; Tue, 25 May 2021 07:15:49 -0700 (PDT) Received: from llong.remote.csb ([2601:191:8500:76c0::cdbc]) by smtp.gmail.com with ESMTPSA id i10sm13315446qko.68.2021.05.25.07.15.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 May 2021 07:15:48 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Subject: Re: [PATCH] LOCKDEP: use depends on LOCKDEP_SUPPORT instead of $ARCH list To: Randy Dunlap , Waiman Long , Ingo Molnar Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, Johannes Berg , Jeff Dike , Richard Weinberger , Anton Ivanov , linux-um@lists.infradead.org References: <20210517034430.9569-1-rdunlap@infradead.org> <1284b997-b9da-769f-2d36-4d4232c7df88@redhat.com> <8a4ee5be-ad5c-ca06-dd1a-aa13ccc94906@redhat.com> <09243238-94ba-caca-441e-3fdac0154822@infradead.org> <3a0fb04c-c640-25db-7e7a-fbdd3b4defb5@redhat.com> <0213cd4e-e832-f768-106a-345e77ce2665@infradead.org> Message-ID: <38797295-8c65-814a-c550-298da324b988@redhat.com> Date: Tue, 25 May 2021 10:15:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <0213cd4e-e832-f768-106a-345e77ce2665@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/25/21 12:18 AM, Randy Dunlap wrote: > On 5/24/21 5:05 PM, Waiman Long wrote: >> On 5/24/21 5:41 PM, Randy Dunlap wrote: >>> On 5/24/21 2:31 PM, Randy Dunlap wrote: >>>> On 5/24/21 2:04 PM, Waiman Long wrote: >>>> >>>>> Is it possible to just get rid of the 2nd depends-on statement? >>>>> >>>>> The 2nd depends-on line was introduced by commit 7d37cb2c912d ("lib: fix kconfig dependency on ARCH_WANT_FRAME_POINTER"): >>>> and I should have looked at that history too. Thanks. >>>> >>>> Yes, I agree, we can just delete that line... >>>> >>>> I'll send a v2 and copy the author of commit 7d37cb2c912d as well. >>> Hm, as I review that commit, I have to wonder if the previous 'select' >>> was correct (if we disregard the Kconfig warning).  If so, then >>> FRAME_POINTER is still wanted/needed for some arch-es. >>> >>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug >>> index 2779c29d9981..417c3d3e521b 100644 >>> --- a/lib/Kconfig.debug >>> +++ b/lib/Kconfig.debug >>> @@ -1363,7 +1363,7 @@ config LOCKDEP >>>          bool >>>          depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT >>>          select STACKTRACE >>> -       select FRAME_POINTER if !MIPS && !PPC && !ARM && !S390 && !MICROBLAZE && !ARC && !X86 <<<<<<<<<<< >>> >> AFAICS, enabling FRAME_POINTER is a debugging aid as it enable more precise stacktrace. However, not all archs want to enable FRAME_POINTER because of LOCKDEP. Now you are just letting users decide if they want FRAME_POINTER or not. Maybe you can modify the help text to mention that. > LOCKDEP doesn't have any user help text. > > For FRAME_POINTER, when ARCH_WANT_FRAME_POINTERS + a few other conditions > is met, it seems that the FRAME_POINTER help text is good enough IMO. > > help > If you say Y here the resulting kernel image will be slightly > larger and slower, but it gives very useful debugging information > in case of kernel bugs. (precise oopses/stacktraces/warnings) > Right. I am fine with that. Thanks, Longman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llXqf-005alz-8Y for linux-um@lists.infradead.org; Tue, 25 May 2021 14:15:58 +0000 Received: by mail-qt1-f198.google.com with SMTP id h7-20020ac846c70000b0290231af0e7829so32372qto.7 for ; Tue, 25 May 2021 07:15:50 -0700 (PDT) From: Waiman Long Subject: Re: [PATCH] LOCKDEP: use depends on LOCKDEP_SUPPORT instead of $ARCH list References: <20210517034430.9569-1-rdunlap@infradead.org> <1284b997-b9da-769f-2d36-4d4232c7df88@redhat.com> <8a4ee5be-ad5c-ca06-dd1a-aa13ccc94906@redhat.com> <09243238-94ba-caca-441e-3fdac0154822@infradead.org> <3a0fb04c-c640-25db-7e7a-fbdd3b4defb5@redhat.com> <0213cd4e-e832-f768-106a-345e77ce2665@infradead.org> Message-ID: <38797295-8c65-814a-c550-298da324b988@redhat.com> Date: Tue, 25 May 2021 10:15:47 -0400 MIME-Version: 1.0 In-Reply-To: <0213cd4e-e832-f768-106a-345e77ce2665@infradead.org> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Randy Dunlap , Waiman Long , Ingo Molnar Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, Johannes Berg , Jeff Dike , Richard Weinberger , Anton Ivanov , linux-um@lists.infradead.org T24gNS8yNS8yMSAxMjoxOCBBTSwgUmFuZHkgRHVubGFwIHdyb3RlOgo+IE9uIDUvMjQvMjEgNTow NSBQTSwgV2FpbWFuIExvbmcgd3JvdGU6Cj4+IE9uIDUvMjQvMjEgNTo0MSBQTSwgUmFuZHkgRHVu bGFwIHdyb3RlOgo+Pj4gT24gNS8yNC8yMSAyOjMxIFBNLCBSYW5keSBEdW5sYXAgd3JvdGU6Cj4+ Pj4gT24gNS8yNC8yMSAyOjA0IFBNLCBXYWltYW4gTG9uZyB3cm90ZToKPj4+Pgo+Pj4+PiBJcyBp dCBwb3NzaWJsZSB0byBqdXN0IGdldCByaWQgb2YgdGhlIDJuZCBkZXBlbmRzLW9uIHN0YXRlbWVu dD8KPj4+Pj4KPj4+Pj4gVGhlIDJuZCBkZXBlbmRzLW9uIGxpbmUgd2FzIGludHJvZHVjZWQgYnkg Y29tbWl0IDdkMzdjYjJjOTEyZCAoImxpYjogZml4IGtjb25maWcgZGVwZW5kZW5jeSBvbiBBUkNI X1dBTlRfRlJBTUVfUE9JTlRFUiIpOgo+Pj4+IGFuZCBJIHNob3VsZCBoYXZlIGxvb2tlZCBhdCB0 aGF0IGhpc3RvcnkgdG9vLiBUaGFua3MuCj4+Pj4KPj4+PiBZZXMsIEkgYWdyZWUsIHdlIGNhbiBq dXN0IGRlbGV0ZSB0aGF0IGxpbmUuLi4KPj4+Pgo+Pj4+IEknbGwgc2VuZCBhIHYyIGFuZCBjb3B5 IHRoZSBhdXRob3Igb2YgY29tbWl0IDdkMzdjYjJjOTEyZCBhcyB3ZWxsLgo+Pj4gSG0sIGFzIEkg cmV2aWV3IHRoYXQgY29tbWl0LCBJIGhhdmUgdG8gd29uZGVyIGlmIHRoZSBwcmV2aW91cyAnc2Vs ZWN0Jwo+Pj4gd2FzIGNvcnJlY3QgKGlmIHdlIGRpc3JlZ2FyZCB0aGUgS2NvbmZpZyB3YXJuaW5n KS7CoCBJZiBzbywgdGhlbgo+Pj4gRlJBTUVfUE9JTlRFUiBpcyBzdGlsbCB3YW50ZWQvbmVlZGVk IGZvciBzb21lIGFyY2gtZXMuCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2xpYi9LY29uZmlnLmRlYnVn IGIvbGliL0tjb25maWcuZGVidWcKPj4+IGluZGV4IDI3NzljMjlkOTk4MS4uNDE3YzNkM2U1MjFi IDEwMDY0NAo+Pj4gLS0tIGEvbGliL0tjb25maWcuZGVidWcKPj4+ICsrKyBiL2xpYi9LY29uZmln LmRlYnVnCj4+PiBAQCAtMTM2Myw3ICsxMzYzLDcgQEAgY29uZmlnIExPQ0tERVAKPj4+ICDCoMKg wqDCoMKgwqDCoMKgIGJvb2wKPj4+ICDCoMKgwqDCoMKgwqDCoMKgIGRlcGVuZHMgb24gREVCVUdf S0VSTkVMICYmIExPQ0tfREVCVUdHSU5HX1NVUFBPUlQKPj4+ICDCoMKgwqDCoMKgwqDCoMKgIHNl bGVjdCBTVEFDS1RSQUNFCj4+PiAtwqDCoMKgwqDCoMKgIHNlbGVjdCBGUkFNRV9QT0lOVEVSIGlm ICFNSVBTICYmICFQUEMgJiYgIUFSTSAmJiAhUzM5MCAmJiAhTUlDUk9CTEFaRSAmJiAhQVJDICYm ICFYODYgPDw8PDw8PDw8PDwKPj4+Cj4+IEFGQUlDUywgZW5hYmxpbmcgRlJBTUVfUE9JTlRFUiBp cyBhIGRlYnVnZ2luZyBhaWQgYXMgaXQgZW5hYmxlIG1vcmUgcHJlY2lzZSBzdGFja3RyYWNlLiBI b3dldmVyLCBub3QgYWxsIGFyY2hzIHdhbnQgdG8gZW5hYmxlIEZSQU1FX1BPSU5URVIgYmVjYXVz ZSBvZiBMT0NLREVQLiBOb3cgeW91IGFyZSBqdXN0IGxldHRpbmcgdXNlcnMgZGVjaWRlIGlmIHRo ZXkgd2FudCBGUkFNRV9QT0lOVEVSIG9yIG5vdC4gTWF5YmUgeW91IGNhbiBtb2RpZnkgdGhlIGhl bHAgdGV4dCB0byBtZW50aW9uIHRoYXQuCj4gTE9DS0RFUCBkb2Vzbid0IGhhdmUgYW55IHVzZXIg aGVscCB0ZXh0Lgo+Cj4gRm9yIEZSQU1FX1BPSU5URVIsIHdoZW4gQVJDSF9XQU5UX0ZSQU1FX1BP SU5URVJTICsgYSBmZXcgb3RoZXIgY29uZGl0aW9ucwo+IGlzIG1ldCwgaXQgc2VlbXMgdGhhdCB0 aGUgRlJBTUVfUE9JTlRFUiBoZWxwIHRleHQgaXMgZ29vZCBlbm91Z2ggSU1PLgo+Cj4gCWhlbHAK PiAJICBJZiB5b3Ugc2F5IFkgaGVyZSB0aGUgcmVzdWx0aW5nIGtlcm5lbCBpbWFnZSB3aWxsIGJl IHNsaWdodGx5Cj4gCSAgbGFyZ2VyIGFuZCBzbG93ZXIsIGJ1dCBpdCBnaXZlcyB2ZXJ5IHVzZWZ1 bCBkZWJ1Z2dpbmcgaW5mb3JtYXRpb24KPiAJICBpbiBjYXNlIG9mIGtlcm5lbCBidWdzLiAocHJl Y2lzZSBvb3BzZXMvc3RhY2t0cmFjZXMvd2FybmluZ3MpCj4KUmlnaHQuIEkgYW0gZmluZSB3aXRo IHRoYXQuCgpUaGFua3MsCkxvbmdtYW4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC11bSBtYWlsaW5nIGxpc3QKbGludXgtdW1AbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LXVtCg==