From: Lee Duncan <lduncan@suse.com>
To: Mike Christie <michael.christie@oracle.com>,
cleech@redhat.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, jejb@linux.ibm.com
Subject: Re: [PATCH 02/12] scsi: iscsi: Rename iscsi_conn_queue_work
Date: Tue, 8 Mar 2022 10:49:00 -0800 [thread overview]
Message-ID: <387bf893-5ea4-e3a2-f06b-d9374d956b91@suse.com> (raw)
In-Reply-To: <20220308002747.122682-3-michael.christie@oracle.com>
On 3/7/22 16:27, Mike Christie wrote:
> Rename iscsi_conn_queue_work to iscsi_conn_queue_xmit to reflect it
> handles queueing of xmits only.
>
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
> drivers/scsi/cxgbi/libcxgbi.c | 2 +-
> drivers/scsi/iscsi_tcp.c | 2 +-
> drivers/scsi/libiscsi.c | 12 ++++++------
> include/scsi/libiscsi.h | 2 +-
> 4 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
> index 4365d52c6430..411b0d386fad 100644
> --- a/drivers/scsi/cxgbi/libcxgbi.c
> +++ b/drivers/scsi/cxgbi/libcxgbi.c
> @@ -1455,7 +1455,7 @@ void cxgbi_conn_tx_open(struct cxgbi_sock *csk)
> if (conn) {
> log_debug(1 << CXGBI_DBG_SOCK,
> "csk 0x%p, cid %d.\n", csk, conn->id);
> - iscsi_conn_queue_work(conn);
> + iscsi_conn_queue_xmit(conn);
> }
> }
> EXPORT_SYMBOL_GPL(cxgbi_conn_tx_open);
> diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
> index 1bc37593c88f..f274a86d2ec0 100644
> --- a/drivers/scsi/iscsi_tcp.c
> +++ b/drivers/scsi/iscsi_tcp.c
> @@ -205,7 +205,7 @@ static void iscsi_sw_tcp_write_space(struct sock *sk)
> old_write_space(sk);
>
> ISCSI_SW_TCP_DBG(conn, "iscsi_write_space\n");
> - iscsi_conn_queue_work(conn);
> + iscsi_conn_queue_xmit(conn);
> }
>
> static void iscsi_sw_tcp_conn_set_callbacks(struct iscsi_conn *conn)
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 14f5737429cf..fa44445dc75f 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -83,7 +83,7 @@ MODULE_PARM_DESC(debug_libiscsi_eh,
> "%s " dbg_fmt, __func__, ##arg); \
> } while (0);
>
> -inline void iscsi_conn_queue_work(struct iscsi_conn *conn)
> +inline void iscsi_conn_queue_xmit(struct iscsi_conn *conn)
> {
> struct Scsi_Host *shost = conn->session->host;
> struct iscsi_host *ihost = shost_priv(shost);
> @@ -91,7 +91,7 @@ inline void iscsi_conn_queue_work(struct iscsi_conn *conn)
> if (ihost->workq)
> queue_work(ihost->workq, &conn->xmitwork);
> }
> -EXPORT_SYMBOL_GPL(iscsi_conn_queue_work);
> +EXPORT_SYMBOL_GPL(iscsi_conn_queue_xmit);
>
> static void __iscsi_update_cmdsn(struct iscsi_session *session,
> uint32_t exp_cmdsn, uint32_t max_cmdsn)
> @@ -764,7 +764,7 @@ __iscsi_conn_send_pdu(struct iscsi_conn *conn, struct iscsi_hdr *hdr,
> goto free_task;
> } else {
> list_add_tail(&task->running, &conn->mgmtqueue);
> - iscsi_conn_queue_work(conn);
> + iscsi_conn_queue_xmit(conn);
> }
>
> return task;
> @@ -1512,7 +1512,7 @@ void iscsi_requeue_task(struct iscsi_task *task)
> */
> iscsi_put_task(task);
> }
> - iscsi_conn_queue_work(conn);
> + iscsi_conn_queue_xmit(conn);
> spin_unlock_bh(&conn->session->frwd_lock);
> }
> EXPORT_SYMBOL_GPL(iscsi_requeue_task);
> @@ -1781,7 +1781,7 @@ int iscsi_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *sc)
> }
> } else {
> list_add_tail(&task->running, &conn->cmdqueue);
> - iscsi_conn_queue_work(conn);
> + iscsi_conn_queue_xmit(conn);
> }
>
> session->queued_cmdsn++;
> @@ -1962,7 +1962,7 @@ EXPORT_SYMBOL_GPL(iscsi_suspend_tx);
> static void iscsi_start_tx(struct iscsi_conn *conn)
> {
> clear_bit(ISCSI_CONN_FLAG_SUSPEND_TX, &conn->flags);
> - iscsi_conn_queue_work(conn);
> + iscsi_conn_queue_xmit(conn);
> }
>
> /*
> diff --git a/include/scsi/libiscsi.h b/include/scsi/libiscsi.h
> index 10a9b89b7448..b567ea4700e5 100644
> --- a/include/scsi/libiscsi.h
> +++ b/include/scsi/libiscsi.h
> @@ -441,7 +441,7 @@ extern int iscsi_conn_get_addr_param(struct sockaddr_storage *addr,
> enum iscsi_param param, char *buf);
> extern void iscsi_suspend_tx(struct iscsi_conn *conn);
> extern void iscsi_suspend_queue(struct iscsi_conn *conn);
> -extern void iscsi_conn_queue_work(struct iscsi_conn *conn);
> +extern void iscsi_conn_queue_xmit(struct iscsi_conn *conn);
>
> #define iscsi_conn_printk(prefix, _c, fmt, a...) \
> iscsi_cls_conn_printk(prefix, ((struct iscsi_conn *)_c)->cls_conn, \
Reviewed-by: Lee Duncan <lduncan@suse.com>
next prev parent reply other threads:[~2022-03-08 18:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 0:27 [[PATCH 00/12] misc iscsi patches Mike Christie
2022-03-08 0:27 ` [PATCH 01/12] scsi: iscsi: Merge suspend fields Mike Christie
2022-03-08 18:47 ` Lee Duncan
2022-03-08 0:27 ` [PATCH 02/12] scsi: iscsi: Rename iscsi_conn_queue_work Mike Christie
2022-03-08 18:49 ` Lee Duncan [this message]
2022-03-09 0:55 ` Wu Bo
2022-03-08 0:27 ` [PATCH 03/12] scsi: iscsi: Add recv workqueue helpers Mike Christie
2022-03-10 22:50 ` Lee Duncan
2022-03-08 0:27 ` [PATCH 04/12] scsi: iscsi: Allow a recv and xmit work to run Mike Christie
2022-03-08 19:00 ` Lee Duncan
2022-03-08 0:27 ` [PATCH 05/12] scsi: iscsi: Run recv path from workqueue Mike Christie
2022-03-18 16:45 ` Lee Duncan
2022-03-18 22:11 ` Mike Christie
2022-03-08 0:27 ` [PATCH 06/12] scsi: iscsi_tcp: Use sendpage for the PDU header Mike Christie
2022-03-12 19:42 ` Lee Duncan
2022-03-08 0:27 ` [PATCH 07/12] scsi: iscsi_tcp: Drop target_alloc use Mike Christie
2022-03-09 1:31 ` Wu Bo
2022-03-12 19:43 ` Lee Duncan
2022-03-08 0:27 ` [PATCH 08/12] scsi: iscsi: remove unneeded task state check Mike Christie
2022-03-09 1:33 ` Wu Bo
2022-03-14 17:13 ` Lee Duncan
2022-03-08 0:27 ` [PATCH 09/12] scsi: iscsi: Remove iscsi_get_task back_lock requirement Mike Christie
2022-03-14 17:44 ` Lee Duncan
2022-03-18 17:31 ` Lee Duncan
2022-03-08 0:27 ` [PATCH 10/12] scsi: iscsi: Try to avoid taking back_lock in xmit path Mike Christie
2022-03-18 17:37 ` Lee Duncan
2022-03-08 0:27 ` [PATCH 11/12] scsi: libiscsi: improve conn_send_pdu API Mike Christie
2022-03-18 16:49 ` Lee Duncan
2022-03-08 0:27 ` [PATCH 12/12] scsi: iscsi: Fix race between recovery and task xmit Mike Christie
2022-03-14 17:46 ` Lee Duncan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=387bf893-5ea4-e3a2-f06b-d9374d956b91@suse.com \
--to=lduncan@suse.com \
--cc=cleech@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.