From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v3 06/15] clk: tegra: Remove tegra_pmc_clk_init along with clk ids Date: Sat, 7 Dec 2019 17:33:19 +0300 Message-ID: <3880aa15-c47a-5ab2-dd39-e8a47f6a3d6a@gmail.com> References: <1575600535-26877-1-git-send-email-skomatineni@nvidia.com> <1575600535-26877-7-git-send-email-skomatineni@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1575600535-26877-7-git-send-email-skomatineni@nvidia.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, mperttunen@nvidia.com, gregkh@linuxfoundation.org, sboyd@kernel.org, tglx@linutronix.de, robh+dt@kernel.org, mark.rutland@arm.com Cc: allison@lohutok.net, pdeschrijver@nvidia.com, pgaikwad@nvidia.com, mturquette@baylibre.com, horms+renesas@verge.net.au, Jisheng.Zhang@synaptics.com, krzk@kernel.org, arnd@arndb.de, spujar@nvidia.com, josephl@nvidia.com, vidyas@nvidia.com, daniel.lezcano@linaro.org, mmaddireddy@nvidia.com, markz@nvidia.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alexios.zavras@intel.com, alsa-devel@alsa-project.org List-Id: linux-tegra@vger.kernel.org 06.12.2019 05:48, Sowjanya Komatineni пишет: > Current Tegra clock driver registers PMC clocks clk_out_1, clk_out_2, > clk_out_3 and blink output in tegra_pmc_init() which does direct Tegra > PMC access during clk_ops and these PMC register read and write access > will not happen when PMC is in secure mode. > > Any direct PMC register access from non-secure world will not go > through and all the PMC clocks and blink control are done in Tegra PMC > driver with PMC as clock provider. > > This patch removes tegra_pmc_clk_init along with corresponding clk ids > from Tegra clock driver. > > Signed-off-by: Sowjanya Komatineni > --- [snip] > @@ -1230,9 +1222,6 @@ static struct tegra_clk_init_table init_table[] __initdata = { > { TEGRA30_CLK_PLL_A, TEGRA30_CLK_CLK_MAX, 564480000, 1 }, > { TEGRA30_CLK_PLL_A_OUT0, TEGRA30_CLK_CLK_MAX, 11289600, 1 }, > { TEGRA30_CLK_EXTERN1, TEGRA30_CLK_PLL_A_OUT0, 0, 1 }, Perhaps these clocks do not need to be always-enabled? [snip] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D559FC43603 for ; Mon, 9 Dec 2019 10:19:47 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C16120726 for ; Mon, 9 Dec 2019 10:19:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="rpZeSNkS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K3aQ1qbn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C16120726 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A6CFE16D8; Mon, 9 Dec 2019 11:18:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A6CFE16D8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1575886785; bh=7cafCujQrYJhKxaY+FnxKk/6VRnz6gI9KCaWF+4D4lI=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rpZeSNkSSEoryiCMcm21eogapzR2Oe0CLHSKixmpBEq619ggoVWFBSVza70gFnpSs +EZk4nlFjLaIYavDiVPBXQ9exrb7JTd14i6gYaBwdFS9VFCT/VAJlPsSGQyKrFaLxL zLgMT7M2/SH9tDTrZjvzwy3ixViAmZyy1IS3ZpB0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2184CF80475; Mon, 9 Dec 2019 10:52:12 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0BFB6F801F7; Sat, 7 Dec 2019 15:33:26 +0100 (CET) Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 44876F8010F for ; Sat, 7 Dec 2019 15:33:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 44876F8010F Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K3aQ1qbn" Received: by mail-lj1-x242.google.com with SMTP id a13so10731219ljm.10 for ; Sat, 07 Dec 2019 06:33:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/FFDjLwGzWA9HSQGVIzBQAFJnVseiTav15XJa3GBc3M=; b=K3aQ1qbnb55GNOBjWlsAMHcHx4YpXkTmspJZNtQXfZdFyWE+cwSXhC+prKM7Cj+7LU jduHbB8Y3SawAfvF6BiO8joJc70Bkgx827I05VZk19e5S08pWQHu0Xcj6ubmkd9v01yz 8vUqyzhjuQuo0tipFfpM4TEbT+am9WsUMgmv74hmFUD5Zr2yprED8P8W42B5XsatRe9S 38WrXZFsAGdVu3KbEql7dhqguT+YQlZWhEvwJyyK9ghBvbfEPEAFUPiFXdK9weISgcb/ /GbNBmS+Dg67t1paCZbFk9QohnHq8yqD2EqOYGBFRHLDRRrZm8Dj+vv5w6l+R7nUiWbP PXFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/FFDjLwGzWA9HSQGVIzBQAFJnVseiTav15XJa3GBc3M=; b=Nr9Q76Vjse6uuTvOXSN6QVdByvCThIVaMOU0IJoC+M4VsQ+HMlu+yFgOBev8aU7p7e cHafRjGRn58pwjoEht07ChWEbOmUzKdpGieUG3yAhUh6FqJyQdSBz04pMKd8six42KqZ HJYxCyb4uSErrMr8OsqZp86xIBxzTcFiKpP2rgGNY8DGHPwy/Y7TX5yeAp9+S1iCB0Ft p0Z3uKAMrzl8fMo+EbVw2frpSBJcnCxjZIpcXdMxu44lif9dcK5xazvNJB/aRddoEGJQ w/mbQUKmvc9vg7WwbMy3YGx0zHZp0dHGNaVNp4/3GTg98iXVPEJ2IhJ0dZyCIkOK5pRz evMA== X-Gm-Message-State: APjAAAW9NyOy2D69TB4xWnA4fpk51Hd28rNXXnlGDCfhAGrZvmqJwaCI oWaT0ql9TOKMctYCGVx60xwf90Ei X-Google-Smtp-Source: APXvYqwlXFJb8W4yPOfhW3/16zy5CO9BLcreipXry+ldYRegUMcmqCBo+2yeOXVRJRYvTKIUZaTVpA== X-Received: by 2002:a2e:9705:: with SMTP id r5mr10932018lji.114.1575729201868; Sat, 07 Dec 2019 06:33:21 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id l28sm8132397lfk.21.2019.12.07.06.33.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Dec 2019 06:33:21 -0800 (PST) To: Sowjanya Komatineni , thierry.reding@gmail.com, jonathanh@nvidia.com, mperttunen@nvidia.com, gregkh@linuxfoundation.org, sboyd@kernel.org, tglx@linutronix.de, robh+dt@kernel.org, mark.rutland@arm.com References: <1575600535-26877-1-git-send-email-skomatineni@nvidia.com> <1575600535-26877-7-git-send-email-skomatineni@nvidia.com> From: Dmitry Osipenko Message-ID: <3880aa15-c47a-5ab2-dd39-e8a47f6a3d6a@gmail.com> Date: Sat, 7 Dec 2019 17:33:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <1575600535-26877-7-git-send-email-skomatineni@nvidia.com> Content-Language: en-US X-Mailman-Approved-At: Mon, 09 Dec 2019 10:51:21 +0100 Cc: alsa-devel@alsa-project.org, pgaikwad@nvidia.com, spujar@nvidia.com, linux-kernel@vger.kernel.org, josephl@nvidia.com, linux-clk@vger.kernel.org, arnd@arndb.de, daniel.lezcano@linaro.org, krzk@kernel.org, mturquette@baylibre.com, devicetree@vger.kernel.org, mmaddireddy@nvidia.com, markz@nvidia.com, alexios.zavras@intel.com, broonie@kernel.org, linux-tegra@vger.kernel.org, horms+renesas@verge.net.au, tiwai@suse.com, allison@lohutok.net, pdeschrijver@nvidia.com, lgirdwood@gmail.com, vidyas@nvidia.com, Jisheng.Zhang@synaptics.com Subject: Re: [alsa-devel] [PATCH v3 06/15] clk: tegra: Remove tegra_pmc_clk_init along with clk ids X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" MDYuMTIuMjAxOSAwNTo0OCwgU293amFueWEgS29tYXRpbmVuaSDQv9C40YjQtdGCOgo+IEN1cnJl bnQgVGVncmEgY2xvY2sgZHJpdmVyIHJlZ2lzdGVycyBQTUMgY2xvY2tzIGNsa19vdXRfMSwgY2xr X291dF8yLAo+IGNsa19vdXRfMyBhbmQgYmxpbmsgb3V0cHV0IGluIHRlZ3JhX3BtY19pbml0KCkg d2hpY2ggZG9lcyBkaXJlY3QgVGVncmEKPiBQTUMgYWNjZXNzIGR1cmluZyBjbGtfb3BzIGFuZCB0 aGVzZSBQTUMgcmVnaXN0ZXIgcmVhZCBhbmQgd3JpdGUgYWNjZXNzCj4gd2lsbCBub3QgaGFwcGVu IHdoZW4gUE1DIGlzIGluIHNlY3VyZSBtb2RlLgo+IAo+IEFueSBkaXJlY3QgUE1DIHJlZ2lzdGVy IGFjY2VzcyBmcm9tIG5vbi1zZWN1cmUgd29ybGQgd2lsbCBub3QgZ28KPiB0aHJvdWdoIGFuZCBh bGwgdGhlIFBNQyBjbG9ja3MgYW5kIGJsaW5rIGNvbnRyb2wgYXJlIGRvbmUgaW4gVGVncmEgUE1D Cj4gZHJpdmVyIHdpdGggUE1DIGFzIGNsb2NrIHByb3ZpZGVyLgo+IAo+IFRoaXMgcGF0Y2ggcmVt b3ZlcyB0ZWdyYV9wbWNfY2xrX2luaXQgYWxvbmcgd2l0aCBjb3JyZXNwb25kaW5nIGNsayBpZHMK PiBmcm9tIFRlZ3JhIGNsb2NrIGRyaXZlci4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBTb3dqYW55YSBL b21hdGluZW5pIDxza29tYXRpbmVuaUBudmlkaWEuY29tPgo+IC0tLQoKW3NuaXBdCgo+IEBAIC0x MjMwLDkgKzEyMjIsNiBAQCBzdGF0aWMgc3RydWN0IHRlZ3JhX2Nsa19pbml0X3RhYmxlIGluaXRf dGFibGVbXSBfX2luaXRkYXRhID0gewoKPiAgCXsgVEVHUkEzMF9DTEtfUExMX0EsIFRFR1JBMzBf Q0xLX0NMS19NQVgsIDU2NDQ4MDAwMCwgMSB9LAo+ICAJeyBURUdSQTMwX0NMS19QTExfQV9PVVQw LCBURUdSQTMwX0NMS19DTEtfTUFYLCAxMTI4OTYwMCwgMSB9LAo+ICAJeyBURUdSQTMwX0NMS19F WFRFUk4xLCBURUdSQTMwX0NMS19QTExfQV9PVVQwLCAwLCAxIH0sCgpQZXJoYXBzIHRoZXNlIGNs b2NrcyBkbyBub3QgbmVlZCB0byBiZSBhbHdheXMtZW5hYmxlZD8KCltzbmlwXQpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcg bGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cHM6Ly9tYWlsbWFuLmFsc2EtcHJv amVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg==