From: Julien Grall <julien@xen.org>
To: Stefano Stabellini <sstabellini@kernel.org>,
Jan Beulich <jbeulich@suse.com>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"roger.pau@citrix.com" <roger.pau@citrix.com>,
"George.Dunlap@citrix.com" <George.Dunlap@citrix.com>,
Stefano Stabellini <stefano.stabellini@xilinx.com>
Subject: Re: [PATCH 1/2] docs/misra: introduce rules.rst
Date: Mon, 30 May 2022 10:12:09 +0100 [thread overview]
Message-ID: <3882cc86-72a7-8e19-5f7b-b1cc89cce02e@xen.org> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2205271602320.1905099@ubuntu-linux-20-04-desktop>
Hi Stefano,
On 28/05/2022 00:16, Stefano Stabellini wrote:
> """
> It is possible that in specific circumstances it is best not to follow a
> rule because it is not possible or because the alternative leads to
> better code quality. Those cases are called "deviations". They are
> permissible as long as they are documented, either as an in-code comment
> or as part of the commit message. Other documentation mechanisms are
I would drop the "as part of the commit message" because it is a lot
more difficult to associate the deviation with a rationale (the code may
have been moved and you would need to go through the history).
Other than that, the text looks fine.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2022-05-30 9:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 0:34 [PATCH 0/2] introduce docs/misra/rules.rst Stefano Stabellini
2022-05-25 0:35 ` [PATCH 1/2] docs/misra: introduce rules.rst Stefano Stabellini
2022-05-25 7:39 ` Julien Grall
2022-05-26 1:02 ` Stefano Stabellini
2022-05-26 9:43 ` Jan Beulich
2022-05-26 9:54 ` Bertrand Marquis
2022-05-26 10:15 ` Jan Beulich
2022-05-26 13:04 ` Bertrand Marquis
2022-05-26 19:57 ` Stefano Stabellini
2022-05-27 6:56 ` Jan Beulich
2022-05-27 23:16 ` Stefano Stabellini
2022-05-30 8:37 ` Jan Beulich
2022-05-30 9:12 ` Julien Grall [this message]
2022-05-30 9:16 ` Jan Beulich
2022-05-30 9:27 ` Julien Grall
2022-05-30 9:33 ` Jan Beulich
2022-05-30 9:41 ` Julien Grall
2022-05-30 9:55 ` Jan Beulich
2022-05-30 10:21 ` George Dunlap
2022-05-30 13:35 ` Bertrand Marquis
2022-05-31 9:41 ` Julien Grall
2022-06-01 1:25 ` Stefano Stabellini
2022-05-25 8:25 ` Jan Beulich
2022-05-26 1:12 ` Stefano Stabellini
2022-05-26 9:36 ` Jan Beulich
2022-05-26 19:57 ` Stefano Stabellini
2022-05-25 12:21 ` Andrew Cooper
2022-05-26 1:57 ` Stefano Stabellini
2022-05-25 0:35 ` [PATCH 2/2] docs/misra: add Rule 5.1 Stefano Stabellini
2022-05-25 7:40 ` Julien Grall
2022-05-25 12:26 ` Andrew Cooper
2022-05-25 8:08 ` Jan Beulich
2022-05-26 1:18 ` Stefano Stabellini
2022-05-26 9:40 ` Jan Beulich
2022-05-26 10:10 ` Bertrand Marquis
2022-05-26 19:58 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3882cc86-72a7-8e19-5f7b-b1cc89cce02e@xen.org \
--to=julien@xen.org \
--cc=Bertrand.Marquis@arm.com \
--cc=George.Dunlap@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@xilinx.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.