From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29260C43462 for ; Wed, 28 Apr 2021 10:09:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E43106142C for ; Wed, 28 Apr 2021 10:09:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239124AbhD1KKL (ORCPT ); Wed, 28 Apr 2021 06:10:11 -0400 Received: from foss.arm.com ([217.140.110.172]:38870 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239013AbhD1KKH (ORCPT ); Wed, 28 Apr 2021 06:10:07 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 119281FB; Wed, 28 Apr 2021 03:09:23 -0700 (PDT) Received: from [10.57.67.189] (unknown [10.57.67.189]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1EF143F70D; Wed, 28 Apr 2021 03:09:20 -0700 (PDT) Subject: Re: [PATCH v1] coresight: add node to reset all coresight devices To: taozha@codeaurora.org Cc: Mathieu Poirier , Alexander Shishkin , Mike Leach , Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Mao Jinlong , Yuanfang Zhang References: <1619166578-28690-1-git-send-email-taozha@codeaurora.org> <4036d63a8759ac67a26fd8798b9adf6b@codeaurora.org> From: Suzuki K Poulose Message-ID: <38865567-8557-e48d-779b-ca257e318c19@arm.com> Date: Wed, 28 Apr 2021 11:09:19 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <4036d63a8759ac67a26fd8798b9adf6b@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/04/2021 10:57, taozha@codeaurora.org wrote: > On 2021-04-23 21:20, Suzuki K Poulose wrote: >> On 23/04/2021 09:29, Tao Zhang wrote: >>> Add new reset_source_sink node to be able to disable all active >>> coresight devices. >>> In this way, we no longer need to manually disable all active >>> coresight devices one by one. After enabling multiple coresight >>> paths, users can reset their status more conveniently by this >>> node. >>> >> >> What is the use case here ? Why would you trigger a reset for all the >> sources/sink without gracefully completing any on-going sessions >> (including the perf ones, which are driven by the kernel perf layer) >> > We have a tool needs a command that could reset all active devices. > Since the tool cannot what dvices are activated, we add this new node > to sysFS for our tool could reset all active device by one command. > We hope that this patch can also provide a more convenient option > for the other users with the same needs. There is sysfs handles to do this already. See the testcase under perf, e.g, that can walk the sysfs and figure out the source devices and the "sinks" that can be reached from the given device. If some information is missing, to achieve this. we could provide that. But simply because a tool wants to do something without bothering to use the provided ABI, is not a justification to add something to the kernel. Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D56F4C433ED for ; Wed, 28 Apr 2021 10:11:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 630FC610FA for ; Wed, 28 Apr 2021 10:11:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 630FC610FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=30uCzqz0CAuN1ApY2d4RPsC0r2cfVJwiVQRToBIndlw=; b=j28Ky0G9hBpL3Yk5vGwQliT+x iqlIbBsg9IOeo5c/pU98Mzqvf8BfKm7K1sgvfQyRpOKH4TCs0RZhswRNIKjrbWa2OyxlyiJaBc8M1 WNsAbfENZPjsSUfyfNJIfe8n2VZKMaTT5r8be5+Nus29iDr5zwrkeFdJlgmNRso9rkZYDL12n8wTd 3FORcfD5Jgo1N4JHNenMqoXI5s8jN2e8USFLbT1LoN7d0mb0Vzr5ZzBKAq6Nq8rLfTSh280PUv/jw qMMuRHNpCqe/Wvc9i0tNV/6blqhxJfdcRbpvM/wEKMvMa9AzmUDFCk2xaPqVffoNwOJ8RFIKHEOiS vx/xOVnYg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbh8j-003GAg-5Q; Wed, 28 Apr 2021 10:09:53 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbh8O-003G9E-6A for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 10:09:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=mZNxeGNCoZqZxAqezTbVH2jnxo7AX0+kj6AnjML9DXQ=; b=HgMcJ9eS+0PqbLLs5UODl+bwVO 4Fcrkm5nsqDghCUhglrrM7zoCXaHWhC5ILN+XEH+P25QrBHFlIyd5pUyYBPoNOrPvOjGbXyQ+MyY6 ixXmPqKM6g7sXjYJQaUtLlczSkPAIBapWxEIz2KXHyy0lbBM1Zd1tLSMqIIrpqPvX9GSrqTYxtV6P lthNYB81llGYFUrn1MWBdiu2C6RnGLpsy3r8Jwi7XN4BpBrM36Jqu1zz0t0e742ufeMnOZhr9Z9ub DDEhCiO9EJXCljBeLy/uidkwEIjsEimr3Fr1wfVXMShlLrSehZ3LPrGBPDkiB1HqxZPsqqJpQ3FTc GxgAXDug==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbh8L-00HLWP-Dk for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 10:09:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 119281FB; Wed, 28 Apr 2021 03:09:23 -0700 (PDT) Received: from [10.57.67.189] (unknown [10.57.67.189]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1EF143F70D; Wed, 28 Apr 2021 03:09:20 -0700 (PDT) Subject: Re: [PATCH v1] coresight: add node to reset all coresight devices To: taozha@codeaurora.org Cc: Mathieu Poirier , Alexander Shishkin , Mike Leach , Leo Yan , Greg Kroah-Hartman , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Mao Jinlong , Yuanfang Zhang References: <1619166578-28690-1-git-send-email-taozha@codeaurora.org> <4036d63a8759ac67a26fd8798b9adf6b@codeaurora.org> From: Suzuki K Poulose Message-ID: <38865567-8557-e48d-779b-ca257e318c19@arm.com> Date: Wed, 28 Apr 2021 11:09:19 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <4036d63a8759ac67a26fd8798b9adf6b@codeaurora.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_030929_538798_8F85BE7E X-CRM114-Status: GOOD ( 18.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/04/2021 10:57, taozha@codeaurora.org wrote: > On 2021-04-23 21:20, Suzuki K Poulose wrote: >> On 23/04/2021 09:29, Tao Zhang wrote: >>> Add new reset_source_sink node to be able to disable all active >>> coresight devices. >>> In this way, we no longer need to manually disable all active >>> coresight devices one by one. After enabling multiple coresight >>> paths, users can reset their status more conveniently by this >>> node. >>> >> >> What is the use case here ? Why would you trigger a reset for all the >> sources/sink without gracefully completing any on-going sessions >> (including the perf ones, which are driven by the kernel perf layer) >> > We have a tool needs a command that could reset all active devices. > Since the tool cannot what dvices are activated, we add this new node > to sysFS for our tool could reset all active device by one command. > We hope that this patch can also provide a more convenient option > for the other users with the same needs. There is sysfs handles to do this already. See the testcase under perf, e.g, that can walk the sysfs and figure out the source devices and the "sinks" that can be reached from the given device. If some information is missing, to achieve this. we could provide that. But simply because a tool wants to do something without bothering to use the provided ABI, is not a justification to add something to the kernel. Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel