All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hoang Nguyen <the_hoang0709@yahoo.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] Fix mistake in strcmp() for skipping in aarch64. And there is the same error in aarch64be, so add it.
Date: Sat, 17 Dec 2016 04:34:15 +0000 (UTC)	[thread overview]
Message-ID: <389215298.4676169.1481949255172@mail.yahoo.com> (raw)
In-Reply-To: <5854ABA4.9090007@huawei.com>

Hi,
I've added the commit message last time (same as your way), but not know why the patch is created, it's disappeared.(I may put the messages in the wrong way, a blank line need after the first line comment? )
Sorry for did not check the patch file.
I've sent it again.
Thanks a lot for your help.
Br,H


      From: Cui Bixuan <cuibixuan@huawei.com>
 To: ltp@lists.linux.it 
 Sent: Saturday, 17 December 2016, 10:06
 Subject: Re: [LTP] [PATCH v2] Fix mistake in strcmp() for skipping in aarch64. And there is the same error in aarch64be, so add it.
   
On 2016/12/16 20:58, the_hoang0709@yahoo.com wrote:
> 
> Signed-off-by: Vertigo <the_hoang0709@yahoo.com>
> ---
>  testcases/kernel/mem/tunable/max_map_count.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
It looks well, but there are no message and Signed-off-by in your patch;

Maybe you can do:
git add $file;
git commit;
and write it:

[title](such as 'Fix mistake in strcmp() for skipping in aarch64')

You can write something for this commit, about the error.

Signed-off-by: Vertigo <the_hoang0709@yahoo.com>

# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
# On branch master
...

Then 'git format-patch -1' can get your patch;
git send-email --to ltp@lists.linux.it $your_patch  or as a attachment.

Thanks,
Cui Bixuan
> 
> 
> 


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp


   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20161217/a4574127/attachment-0001.html>

      reply	other threads:[~2016-12-17  4:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-16 12:58 [LTP] [PATCH v2] Fix mistake in strcmp() for skipping in aarch64. And there is the same error in aarch64be, so add it the_hoang0709
2016-12-17  3:06 ` Cui Bixuan
2016-12-17  4:34   ` Hoang Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=389215298.4676169.1481949255172@mail.yahoo.com \
    --to=the_hoang0709@yahoo.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.