From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62414C433E8 for ; Wed, 22 Jul 2020 23:13:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A19C2071A for ; Wed, 22 Jul 2020 23:13:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733072AbgGVXNp (ORCPT ); Wed, 22 Jul 2020 19:13:45 -0400 Received: from gloria.sntech.de ([185.11.138.130]:48888 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726447AbgGVXNp (ORCPT ); Wed, 22 Jul 2020 19:13:45 -0400 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jyNvg-0006Rv-PO; Thu, 23 Jul 2020 01:13:40 +0200 From: Heiko Stuebner To: Jagan Teki Cc: Rob Herring , Suniel Mahesh , Michael Trimarchi , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amarula Subject: Re: [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding Date: Thu, 23 Jul 2020 01:13:39 +0200 Message-ID: <3893924.cuH9TW0V3R@phil> In-Reply-To: <20200722190949.215656-3-jagan@amarulasolutions.com> References: <20200722190949.215656-1-jagan@amarulasolutions.com> <20200722190949.215656-3-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jagan, Am Mittwoch, 22. Juli 2020, 21:09:46 CEST schrieb Jagan Teki: > Add dt-bindings for ROCKPi 4B which is similar to 4A with > additional AP6256 Wifi/BT, PoE. > > Signed-off-by: Jagan Teki > --- > Changes for v2: > - new patch > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 36057c9e4b83..7250adb43d24 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -448,6 +448,12 @@ properties: > - const: radxa,rockpi4a > - const: rockchip,rk3399 > > + - description: Radxa ROCK Pi 4B > + items: > + - const: radxa,rockpi4 > + - const: radxa,rockpi4b > + - const: rockchip,rk3399 > + Please do all RockPi4 variants into one entry, so we want something like: - description: Radxa ROCK Pi 4 items: - enum: - radxa,rockpi4a - radxa,rockpi4b - radxa,rockpi4c - const: radxa,rockpi4 - const: rockchip,rk3399 And as the {a,b,c} variant is the most specific it also should be the first entry, not the second. Heiko > - description: Radxa ROCK Pi N8 > items: > - const: radxa,rockpi-n8 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding Date: Thu, 23 Jul 2020 01:13:39 +0200 Message-ID: <3893924.cuH9TW0V3R@phil> References: <20200722190949.215656-1-jagan@amarulasolutions.com> <20200722190949.215656-3-jagan@amarulasolutions.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20200722190949.215656-3-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jagan Teki Cc: Rob Herring , Suniel Mahesh , Michael Trimarchi , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-amarula List-Id: linux-rockchip.vger.kernel.org Hi Jagan, Am Mittwoch, 22. Juli 2020, 21:09:46 CEST schrieb Jagan Teki: > Add dt-bindings for ROCKPi 4B which is similar to 4A with > additional AP6256 Wifi/BT, PoE. > > Signed-off-by: Jagan Teki > --- > Changes for v2: > - new patch > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 36057c9e4b83..7250adb43d24 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -448,6 +448,12 @@ properties: > - const: radxa,rockpi4a > - const: rockchip,rk3399 > > + - description: Radxa ROCK Pi 4B > + items: > + - const: radxa,rockpi4 > + - const: radxa,rockpi4b > + - const: rockchip,rk3399 > + Please do all RockPi4 variants into one entry, so we want something like: - description: Radxa ROCK Pi 4 items: - enum: - radxa,rockpi4a - radxa,rockpi4b - radxa,rockpi4c - const: radxa,rockpi4 - const: rockchip,rk3399 And as the {a,b,c} variant is the most specific it also should be the first entry, not the second. Heiko > - description: Radxa ROCK Pi N8 > items: > - const: radxa,rockpi-n8 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4837AC433E1 for ; Wed, 22 Jul 2020 23:15:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 093BE2071A for ; Wed, 22 Jul 2020 23:15:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yJNYQv0N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 093BE2071A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PFLDp43YMIsYK6FHYPI0DpwoRvUa/g/pJ8A5c5B4Ros=; b=yJNYQv0NYPBxsCFPyBC9aHP1Z 5Nhg+S/RXehlHYOoQD3eEOzApl2X+DMY5Hq/nXUwx5Jjb6SQhdW2aiYUu3tWE3L2sTHVY1MJ26iFt RbhVd+fxgz5fsKSDWIURcb1WznO1uz3dwPTsHjaKpBWcqBduiBrmJm0swtVgnXv3QsQSdzMV8VOeb ki8BNw7QsoH9OtaXxfrI+FWs2zY7OPeu6EZMeVLOyUnauXvK7+BFKC0unbDzK4THEsIpmItdqIh0B LkAUAGYx6Hu5GWzVFueSe3FWbvc/ZHdoORgqSbGQMbQIeJGuPgTMqaeAe30ZWBM99oMbbS9mGd688 2pVWYkwHg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyNvl-0003QY-OO; Wed, 22 Jul 2020 23:13:45 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyNvi-0003Po-TM; Wed, 22 Jul 2020 23:13:43 +0000 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jyNvg-0006Rv-PO; Thu, 23 Jul 2020 01:13:40 +0200 From: Heiko Stuebner To: Jagan Teki Subject: Re: [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding Date: Thu, 23 Jul 2020 01:13:39 +0200 Message-ID: <3893924.cuH9TW0V3R@phil> In-Reply-To: <20200722190949.215656-3-jagan@amarulasolutions.com> References: <20200722190949.215656-1-jagan@amarulasolutions.com> <20200722190949.215656-3-jagan@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200722_191342_962168_BDE51BAB X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Suniel Mahesh , Michael Trimarchi , linux-amarula , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jagan, Am Mittwoch, 22. Juli 2020, 21:09:46 CEST schrieb Jagan Teki: > Add dt-bindings for ROCKPi 4B which is similar to 4A with > additional AP6256 Wifi/BT, PoE. > > Signed-off-by: Jagan Teki > --- > Changes for v2: > - new patch > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 36057c9e4b83..7250adb43d24 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -448,6 +448,12 @@ properties: > - const: radxa,rockpi4a > - const: rockchip,rk3399 > > + - description: Radxa ROCK Pi 4B > + items: > + - const: radxa,rockpi4 > + - const: radxa,rockpi4b > + - const: rockchip,rk3399 > + Please do all RockPi4 variants into one entry, so we want something like: - description: Radxa ROCK Pi 4 items: - enum: - radxa,rockpi4a - radxa,rockpi4b - radxa,rockpi4c - const: radxa,rockpi4 - const: rockchip,rk3399 And as the {a,b,c} variant is the most specific it also should be the first entry, not the second. Heiko > - description: Radxa ROCK Pi N8 > items: > - const: radxa,rockpi-n8 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel