From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751117AbeDXWSx (ORCPT ); Tue, 24 Apr 2018 18:18:53 -0400 Received: from lithops.sigma-star.at ([195.201.40.130]:42754 "EHLO lithops.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750766AbeDXWSt (ORCPT ); Tue, 24 Apr 2018 18:18:49 -0400 From: Richard Weinberger To: Michal Hocko Cc: LKML , Artem Bityutskiy , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Cyrille Pitchen , "Theodore Ts'o" , Andreas Dilger , Steven Whitehouse , Bob Peterson , Trond Myklebust , Anna Schumaker , Adrian Hunter , Philippe Ombredanne , Kate Stewart , Mikulas Patocka , linux-mtd@lists.infradead.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: vmalloc with GFP_NOFS Date: Wed, 25 Apr 2018 00:18:40 +0200 Message-ID: <3894056.cxOY6eVYVp@blindfold> In-Reply-To: <20180424192803.GT17484@dhcp22.suse.cz> References: <20180424162712.GL17484@dhcp22.suse.cz> <3732370.1623zxSvNg@blindfold> <20180424192803.GT17484@dhcp22.suse.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 24. April 2018, 21:28:03 CEST schrieb Michal Hocko: > > Also only for debugging. > > Getting rid of vmalloc with GFP_NOFS in UBIFS is no big problem. > > I can prepare a patch. > > Cool! > > Anyway, if UBIFS has some reclaim recursion critical sections in general > it would be really great to have them documented and that is where the > scope api is really handy. Just add the scope and document what is the > recursion issue. This will help people reading the code as well. Ideally > there shouldn't be any explicit GFP_NOFS in the code. So in a perfect world a filesystem calls memalloc_nofs_save/restore and always uses GFP_KERNEL for kmalloc/vmalloc? Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: Re: vmalloc with GFP_NOFS Date: Wed, 25 Apr 2018 00:18:40 +0200 Message-ID: <3894056.cxOY6eVYVp@blindfold> References: <20180424162712.GL17484@dhcp22.suse.cz> <3732370.1623zxSvNg@blindfold> <20180424192803.GT17484@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: LKML , Artem Bityutskiy , David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Cyrille Pitchen , Theodore Ts'o , Andreas Dilger , Steven Whitehouse , Bob Peterson , Trond Myklebust , Anna Schumaker , Adrian Hunter , Philippe Ombredanne , Kate Stewart , Mikulas Patocka , linux-mtd@lists.infradead.org, linux-ext4@vger.k To: Michal Hocko Return-path: In-Reply-To: <20180424192803.GT17484@dhcp22.suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org Am Dienstag, 24. April 2018, 21:28:03 CEST schrieb Michal Hocko: > > Also only for debugging. > > Getting rid of vmalloc with GFP_NOFS in UBIFS is no big problem. > > I can prepare a patch. > > Cool! > > Anyway, if UBIFS has some reclaim recursion critical sections in general > it would be really great to have them documented and that is where the > scope api is really handy. Just add the scope and document what is the > recursion issue. This will help people reading the code as well. Ideally > there shouldn't be any explicit GFP_NOFS in the code. So in a perfect world a filesystem calls memalloc_nofs_save/restore and always uses GFP_KERNEL for kmalloc/vmalloc? Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Date: Wed, 25 Apr 2018 00:18:40 +0200 Subject: [Cluster-devel] vmalloc with GFP_NOFS In-Reply-To: <20180424192803.GT17484@dhcp22.suse.cz> References: <20180424162712.GL17484@dhcp22.suse.cz> <3732370.1623zxSvNg@blindfold> <20180424192803.GT17484@dhcp22.suse.cz> Message-ID: <3894056.cxOY6eVYVp@blindfold> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Am Dienstag, 24. April 2018, 21:28:03 CEST schrieb Michal Hocko: > > Also only for debugging. > > Getting rid of vmalloc with GFP_NOFS in UBIFS is no big problem. > > I can prepare a patch. > > Cool! > > Anyway, if UBIFS has some reclaim recursion critical sections in general > it would be really great to have them documented and that is where the > scope api is really handy. Just add the scope and document what is the > recursion issue. This will help people reading the code as well. Ideally > there shouldn't be any explicit GFP_NOFS in the code. So in a perfect world a filesystem calls memalloc_nofs_save/restore and always uses GFP_KERNEL for kmalloc/vmalloc? Thanks, //richard