Re: [PATCH v2 3/3] sam460ex: Clean up irq mapping

[BALATON Zoltan via <qemu-devel@nongnu.org>]

On Fri, 1 Jan 2021, Peter Maydell wrote:
> On Thu, 31 Dec 2020 at 20:55, BALATON Zoltan <balaton@eik.bme.hu> wrote:
>> The SoC is called 460EX (despite having a PPC 440 core not 460 one) but I
>> think you've looked at the right data sheet and it's just a typo. I also
>> don't know how the board is wired so I think in this case I prefer
>> dropping this patch and keeping the current code just for simplicity but
>> to avoid going through this again maybe we should add a comment saying why
>> it's working. Can you please suggest a text for such comment pointing to
>> the relevant part of pci_change_irq_level() you refer to above? I don't
>> think I understand it enough to document it.
>
> How about:
>
> /*
> * All four IRQ[ABCD] pins from all slots are tied to a single board
> * IRQ, so our mapping function here maps everything to IRQ 0.
> * The code in pci_change_irq_level() tracks the number of times
> * the mapped IRQ is asserted and deasserted, so if multiple devices
> * assert an IRQ at the same time the behaviour is correct.
> */

Very good, thank you. Leaving it as it is now also avoids needing to 
rebase your UIC series so that should still apply. I've sent a series with 
the above comment now, please add your Suggested-by, Reviewed-by as you 
see fit.

Regards,
BALATON Zoltan