From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] scripts: check cc stable mailing list in commit
Date: Wed, 30 Nov 2016 16:09:47 +0100 [thread overview]
Message-ID: <3896815.T41b2RsLT8@xps13> (raw)
In-Reply-To: <1b249c77-5685-8492-6f6b-3478a2731267@intel.com>
2016-11-30 14:54, Ferruh Yigit:
> On 11/21/2016 10:43 PM, Thomas Monjalon wrote:
> > +stablefixes=$($selfdir/git-log-fixes.sh $range | sed '/(N\/A)$/d' | cut -d' ' -f2)
>
> This breaks the "check-git-log.sh -N" usage, since "-N" is not a valid
> range for git-log-fixes.sh.
> Generates warning:
> .../scripts/git-log-fixes.sh: illegal option -- 6
> usage: git-log-fixes.sh [-h] <git_range>
Yes, good catch.
I'm trying to fix it by converting -N to HEAD~N..
if printf -- $range | grep -q '^-[0-9]\+' ; then
range="HEAD$(printf -- $range | sed 's,^-,~,').."
fi
> > +# check CC:stable for fixes
> > +bad=$(for fix in $stablefixes ; do
> > + git log --format='%b' -1 $fix | grep -qi '^CC: *stable@dpdk.org' ||
> > + git log --format='\t%s' -1 $fix
> > +done)
> > +[ -z "$bad" ] || printf "Should CC: stable@dpdk.org\n$bad\n"
>
> This is good for developer, but since "CC: xx" tags removed when patch
> applied, this will generate warnings when run against existing history.
I do not think it is a problem.
Who runs this tool against existing history?
> I don't know what can be done for this.
>
> Or should we keep CC: tags in commit log perhaps?
I do not see the value of keeping the CC: in the git history.
next prev parent reply other threads:[~2016-11-30 15:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 22:43 [PATCH] scripts: check cc stable mailing list in commit Thomas Monjalon
2016-11-30 14:54 ` Ferruh Yigit
2016-11-30 15:09 ` Thomas Monjalon [this message]
2016-11-30 15:26 ` Bruce Richardson
2016-11-30 15:31 ` Thomas Monjalon
2016-11-30 15:36 ` Bruce Richardson
2017-01-16 9:51 ` Yuanhan Liu
2017-01-16 10:37 ` Thomas Monjalon
2017-01-16 11:19 ` Yuanhan Liu
2017-01-16 14:26 ` Thomas Monjalon
2017-01-16 14:46 ` Yuanhan Liu
2017-01-16 10:38 ` Ferruh Yigit
2017-01-16 10:54 ` Yuanhan Liu
2016-12-01 13:43 ` [PATCH v2] " Thomas Monjalon
2016-12-01 15:00 ` Ferruh Yigit
2016-12-01 15:03 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3896815.T41b2RsLT8@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.