From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B59C433ED for ; Wed, 7 Apr 2021 17:52:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA21D61363 for ; Wed, 7 Apr 2021 17:52:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233475AbhDGRwY (ORCPT ); Wed, 7 Apr 2021 13:52:24 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:60262 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbhDGRwV (ORCPT ); Wed, 7 Apr 2021 13:52:21 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1617817931; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=YrQgPTfY48iGzzVhb/GjqH7aT+xdZHhGl9cpqh8bNVU=; b=L+hw3w5Jiz7Anfh6IBVXyB/LOUwzCjh+5zkjnbxrjIImn2ohn6Hfkq31REkrM5tSr4AvQzc+ OeHuPVybiNl558GedytIq6JACknA6zoXc6wB2TmQ7RpQo01tSHJ1BUT20bYvM9//b6Mz7oVo QIJXHcTHo58M8ZXB3lJK5J6OsnY= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 606df13bfebcffa80f2a36d2 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 07 Apr 2021 17:51:55 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 922C9C43462; Wed, 7 Apr 2021 17:51:55 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 706A9C433ED; Wed, 7 Apr 2021 17:51:54 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 07 Apr 2021 10:51:54 -0700 From: abhinavk@codeaurora.org To: Zhen Lei Cc: Rob Clark , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm , dri-devel , freedreno , linux-kernel Subject: Re: [PATCH 1/1] drm/msm/dp: remove unused local variable 'hpd' In-Reply-To: <20210407082315.2703-1-thunder.leizhen@huawei.com> References: <20210407082315.2703-1-thunder.leizhen@huawei.com> Message-ID: <38969a7640a5067a714fc87fb5aa7d3a@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-04-07 01:23, Zhen Lei wrote: > Fixes the following W=1 kernel build warning: > > drivers/gpu/drm/msm/dp/dp_display.c: In function > ‘dp_display_usbpd_attention_cb’: > drivers/gpu/drm/msm/dp/dp_display.c:496:19: warning: variable ‘hpd’ > set but not used [-Wunused-but-set-variable] > > Fixes: c58eb1b54fee ("drm/msm/dp: fix connect/disconnect handled at > irq_hpd") > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dp/dp_display.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 5a39da6e1eaf277..31bf2a40a9eb2c9 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -493,7 +493,6 @@ static int dp_display_usbpd_attention_cb(struct > device *dev) > int rc = 0; > u32 sink_request; > struct dp_display_private *dp; > - struct dp_usbpd *hpd; > > if (!dev) { > DRM_ERROR("invalid dev\n"); > @@ -507,8 +506,6 @@ static int dp_display_usbpd_attention_cb(struct > device *dev) > return -ENODEV; > } > > - hpd = dp->usbpd; > - > /* check for any test request issued by sink */ > rc = dp_link_process_request(dp->link); > if (!rc) { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07186C433ED for ; Wed, 7 Apr 2021 17:52:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6D2F6124C for ; Wed, 7 Apr 2021 17:51:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6D2F6124C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2F55A6E139; Wed, 7 Apr 2021 17:51:59 +0000 (UTC) Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5CE0A6E134 for ; Wed, 7 Apr 2021 17:51:57 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1617817917; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=YrQgPTfY48iGzzVhb/GjqH7aT+xdZHhGl9cpqh8bNVU=; b=aMe9JhEng0yf0m5i5+G71KtgYBusgx8vZT85u2jb0zqMv7QnHeQXySXenU3NxepHzatVnzP3 MUbDKB0Z0AmP5aIzrhBOF3oBdMSYDcyYshvaNGIY895vy4/0w5nA8DdabtDyHxJ3szM4a1aL lpzpc7M9fOq1SZMtLYNoNBraBDA= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 606df13c8166b7eff730beea (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 07 Apr 2021 17:51:56 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 88C10C433CA; Wed, 7 Apr 2021 17:51:55 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 706A9C433ED; Wed, 7 Apr 2021 17:51:54 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 07 Apr 2021 10:51:54 -0700 From: abhinavk@codeaurora.org To: Zhen Lei Subject: Re: [PATCH 1/1] drm/msm/dp: remove unused local variable 'hpd' In-Reply-To: <20210407082315.2703-1-thunder.leizhen@huawei.com> References: <20210407082315.2703-1-thunder.leizhen@huawei.com> Message-ID: <38969a7640a5067a714fc87fb5aa7d3a@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno , David Airlie , linux-arm-msm , linux-kernel , dri-devel , Sean Paul Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMjAyMS0wNC0wNyAwMToyMywgWmhlbiBMZWkgd3JvdGU6Cj4gRml4ZXMgdGhlIGZvbGxvd2lu ZyBXPTEga2VybmVsIGJ1aWxkIHdhcm5pbmc6Cj4gCj4gZHJpdmVycy9ncHUvZHJtL21zbS9kcC9k cF9kaXNwbGF5LmM6IEluIGZ1bmN0aW9uCj4g4oCYZHBfZGlzcGxheV91c2JwZF9hdHRlbnRpb25f Y2LigJk6Cj4gZHJpdmVycy9ncHUvZHJtL21zbS9kcC9kcF9kaXNwbGF5LmM6NDk2OjE5OiB3YXJu aW5nOiB2YXJpYWJsZSDigJhocGTigJkKPiBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1idXQt c2V0LXZhcmlhYmxlXQo+IAo+IEZpeGVzOiBjNThlYjFiNTRmZWUgKCJkcm0vbXNtL2RwOiBmaXgg Y29ubmVjdC9kaXNjb25uZWN0IGhhbmRsZWQgYXQgCj4gaXJxX2hwZCIpCj4gUmVwb3J0ZWQtYnk6 IEh1bGsgUm9ib3QgPGh1bGtjaUBodWF3ZWkuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFpoZW4gTGVp IDx0aHVuZGVyLmxlaXpoZW5AaHVhd2VpLmNvbT4KUmV2aWV3ZWQtYnk6IEFiaGluYXYgS3VtYXIg PGFiaGluYXZrQGNvZGVhdXJvcmEub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2Rw L2RwX2Rpc3BsYXkuYyB8IDMgLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGRlbGV0aW9ucygtKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2RwL2RwX2Rpc3BsYXkuYwo+IGIv ZHJpdmVycy9ncHUvZHJtL21zbS9kcC9kcF9kaXNwbGF5LmMKPiBpbmRleCA1YTM5ZGE2ZTFlYWYy NzcuLjMxYmYyYTQwYTllYjJjOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rw L2RwX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZHAvZHBfZGlzcGxheS5j Cj4gQEAgLTQ5Myw3ICs0OTMsNiBAQCBzdGF0aWMgaW50IGRwX2Rpc3BsYXlfdXNicGRfYXR0ZW50 aW9uX2NiKHN0cnVjdCAKPiBkZXZpY2UgKmRldikKPiAgCWludCByYyA9IDA7Cj4gIAl1MzIgc2lu a19yZXF1ZXN0Owo+ICAJc3RydWN0IGRwX2Rpc3BsYXlfcHJpdmF0ZSAqZHA7Cj4gLQlzdHJ1Y3Qg ZHBfdXNicGQgKmhwZDsKPiAKPiAgCWlmICghZGV2KSB7Cj4gIAkJRFJNX0VSUk9SKCJpbnZhbGlk IGRldlxuIik7Cj4gQEAgLTUwNyw4ICs1MDYsNiBAQCBzdGF0aWMgaW50IGRwX2Rpc3BsYXlfdXNi cGRfYXR0ZW50aW9uX2NiKHN0cnVjdCAKPiBkZXZpY2UgKmRldikKPiAgCQlyZXR1cm4gLUVOT0RF VjsKPiAgCX0KPiAKPiAtCWhwZCA9IGRwLT51c2JwZDsKPiAtCj4gIAkvKiBjaGVjayBmb3IgYW55 IHRlc3QgcmVxdWVzdCBpc3N1ZWQgYnkgc2luayAqLwo+ICAJcmMgPSBkcF9saW5rX3Byb2Nlc3Nf cmVxdWVzdChkcC0+bGluayk7Cj4gIAlpZiAoIXJjKSB7Cl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=