All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v12.2 0/5] bq27xxx_battery partial series
@ 2017-03-30  9:02 Liam Breck
  2017-03-30  9:02 ` [PATCH v12.2 5/9] power: bq27xxx_battery: Add bulk transfer bus methods Liam Breck
                   ` (5 more replies)
  0 siblings, 6 replies; 18+ messages in thread
From: Liam Breck @ 2017-03-30  9:02 UTC (permalink / raw)
  To: Andrew F. Davis, linux-pm

Changes in this rev:

Removed macro for if (...) dev_dbg(...) from I/O helper functions.

Moved update_dm_block() to patch "Add power_supply_battery_info support".
No more refactoring please; it's not really improving the code itself :-)

set_cfgupdate is required for DM write on certain chips, see this Q&A
https://e2e.ti.com/support/power_management/battery_management/f/180/p/577798/2121489#2121489

Renamed dm_buf .full => .has_data, .updt => .dirty
dm_buf has 3 states: !has_data, has_data && !dirty, has_data && dirty
I considered a single field and enum values, but I think this is clearer.

Renamed set_cfgupdate(..., u16 flag => state)
We call set_cfgupdate(di, BQ27XXX_FLAG_CFGUP or 0)
We !!state to print the intended flag state in error msg.


  power: bq27xxx_battery: Add bulk transfer bus methods
  power: bq27xxx_battery: Add chip data memory read/write support
  power: bq27xxx_battery: Add power_supply_battery_info support
  power: bq27xxx_battery: Enable chip data memory update for certain chips
  power: bq27xxx_battery: Remove duplicate register arrays

 drivers/power/supply/bq27xxx_battery.c     | 700 +++++++++++++++++++++++------
 drivers/power/supply/bq27xxx_battery_i2c.c |  98 +++-
 include/linux/power/bq27xxx_battery.h      |  26 +-
 3 files changed, 682 insertions(+), 142 deletions(-)

-- 
2.9.3

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2017-04-04 21:50 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-30  9:02 [PATCH v12.2 0/5] bq27xxx_battery partial series Liam Breck
2017-03-30  9:02 ` [PATCH v12.2 5/9] power: bq27xxx_battery: Add bulk transfer bus methods Liam Breck
2017-03-30 12:45   ` Andrew F. Davis
2017-03-30 19:48     ` Liam Breck
2017-03-30  9:02 ` [PATCH v12.2 6/9] power: bq27xxx_battery: Add chip data memory read/write support Liam Breck
2017-03-30 12:55   ` Andrew F. Davis
2017-03-30 20:04     ` Liam Breck
2017-03-30  9:02 ` [PATCH v12.2 7/9] power: bq27xxx_battery: Add power_supply_battery_info support Liam Breck
2017-03-30  9:02 ` [PATCH v12.2 8/9] power: bq27xxx_battery: Enable chip data memory update for certain chips Liam Breck
2017-03-30 12:58   ` Andrew F. Davis
2017-03-30 20:14     ` Liam Breck
2017-04-04 20:12       ` Andrew F. Davis
2017-04-04 21:37         ` Liam Breck
2017-04-04 21:42           ` Andrew F. Davis
2017-04-04 21:50             ` Liam Breck
2017-03-30  9:02 ` [PATCH v12.2 9/9] power: bq27xxx_battery: Remove duplicate register arrays Liam Breck
2017-03-30 12:39 ` [PATCH v12.2 0/5] bq27xxx_battery partial series Andrew F. Davis
2017-03-30 19:45   ` Liam Breck

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.