From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6193AC04AB6 for ; Fri, 31 May 2019 16:36:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28BD026C3A for ; Fri, 31 May 2019 16:36:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GueBvGAn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726826AbfEaQgc (ORCPT ); Fri, 31 May 2019 12:36:32 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:42855 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726531AbfEaQgb (ORCPT ); Fri, 31 May 2019 12:36:31 -0400 Received: by mail-pg1-f193.google.com with SMTP id e6so3076538pgd.9; Fri, 31 May 2019 09:36:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3tzOLexHcMrooSCenmTLyKwfDBS6JJ3zJIi8d/CAsZ8=; b=GueBvGAnyvQS7tqxY/ep/9VWXhGdfjle/8DpFYXLjgQ9LSSN5+0p0VGsdTiWlLnBjI WFyjyMjKkofva9H/mYTm9HeVEDNW6dBOCYDoKy2pwG6i0GVUv6mEEJJvRSCzQoNbSuln +mn5VWlCgyHSdBOLmpOR6AaLlyy9jo6ja2drpjMEEHSowT6toWCX3XovkEHXcjxpKKP+ 2UAVFUXdTpd/aD7ObWdIe/xfSmj989TRLbrE3omKW6H/8xyUefhbq8nqj1ZjVqL+0Z3D bG3pZlXlPIjrAlw3Ispiwt6jd3OOEhY4DR/qHwwKoJfUvOS9yxje6LmcdyftX1ejYg59 4zMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=3tzOLexHcMrooSCenmTLyKwfDBS6JJ3zJIi8d/CAsZ8=; b=lV2K0kt0PAzCcnyi6Nf7IgSMV2jjWAi2Jt+QvKz+3LscmC0+jIEmUfH2UStn6WMEs+ hPnpNK4LGNxAvOfqMA3U3s4QQSY/gwaK7v92FWnkSDv0vYHglkHinTY5qw2ErGKePK/1 QGBpp8BI2SmALDaeB/+IuGFJCgdsoAPlN9TZhn3sZYD6fvadtZTyLvBJsJSEaFZluD5D FX8hT78O7KjFJkejIOFjSM9CZoSg2SS7xlM2Z149rv8dyrokYICT/H81jf61R9YFtgxC V1u36SQTqDwefSC09cw0qfd2z+xp9o7tQiA3A7Sx0HTadHHIMEVyjH1fcD69IqrOiRlp 3odA== X-Gm-Message-State: APjAAAWxv5DyTZ0nK2+xr62Ld8My42Lx9CDlf0VBms2H3JX8/c8p5VXk hW1nS1JNQ6Pjp620oE7RnOI= X-Google-Smtp-Source: APXvYqyV74XMGh8mpCBAGgPVOupb/zGAHgmCHvU8ZfZKSiXv6RWokgpeEE0DK7BkZFnsd5mO7tTlPg== X-Received: by 2002:a63:f410:: with SMTP id g16mr287275pgi.428.1559320590442; Fri, 31 May 2019 09:36:30 -0700 (PDT) Received: from [10.67.49.123] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id s24sm6599407pfe.57.2019.05.31.09.36.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 May 2019 09:36:29 -0700 (PDT) Subject: Re: [PATCH] net: dsa: mv88e6xxx: avoid error message on remove from VLAN 0 To: Vivien Didelot , Nikita Yushchenko Cc: Andrew Lunn , "David S. Miller" , Heiner Kallweit , =?UTF-8?Q?Marek_Beh=c3=ban?= , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Healy References: <20190531073514.2171-1-nikita.yoush@cogentembedded.com> <20190531103105.GE23464@t480s.localdomain> <20190531143758.GB23821@lunn.ch> <422482dc-8887-0f92-c8c9-f9d639882c77@cogentembedded.com> <20190531110017.GB2075@t480s.localdomain> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <38a5dbac-a8e7-325a-225f-b97774f7bb81@gmail.com> Date: Fri, 31 May 2019 09:36:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190531110017.GB2075@t480s.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/31/19 8:00 AM, Vivien Didelot wrote: > Hi Nikita, > > On Fri, 31 May 2019 17:46:29 +0300, Nikita Yushchenko wrote: >> >> >> 31.05.2019 17:37, Andrew Lunn wrote: >>>> I'm not sure that I like the semantic of it, because the driver can actually >>>> support VID 0 per-se, only the kernel does not use VLAN 0. Thus I would avoid >>>> calling the port_vlan_del() ops for VID 0, directly into the upper DSA layer. >>>> >>>> Florian, Andrew, wouldn't the following patch be more adequate? >>>> >>>> diff --git a/net/dsa/slave.c b/net/dsa/slave.c >>>> index 1e2ae9d59b88..80f228258a92 100644 >>>> --- a/net/dsa/slave.c >>>> +++ b/net/dsa/slave.c >>>> @@ -1063,6 +1063,10 @@ static int dsa_slave_vlan_rx_kill_vid(struct net_device *dev, __be16 proto, >>>> struct bridge_vlan_info info; >>>> int ret; >>>> >>>> + /* VID 0 has a special meaning and is never programmed in hardware */ >>>> + if (!vid) >>>> + return 0; >>>> + >>>> /* Check for a possible bridge VLAN entry now since there is no >>>> * need to emulate the switchdev prepare + commit phase. >>>> */ >>> >> Kernel currently does, but it is caught in >> mv88e6xxx_port_check_hw_vlan() and returns -ENOTSUPP from there. > > But VID 0 has a special meaning for the kernel, it means the port's private > database (when it is isolated, non-bridged), it is not meant to be programmed > in the switch. That's why I would've put that knowledge into the DSA layer, > which job is to translate the kernel operations to the (dumb) DSA drivers. > > I hope I'm seeing things correctly here. Your first part about the fact that it's the port private database is true, the fact that it is not programmed into the HW actually depends on what the switch is capable of doing. With mv88e6xxx you have per-port VLAN filtering controls, but other switches that do not have that capability need to program VID == 0 into the HW to continue maintaining VLAN filtering on a non bridged port while a bridge has enslaved other ports of the switch. AFAICT, mv88e6xx is the only driver that attempts to catch vid == 0 and return something to the upper layers about it. -- Florian