From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752594AbdIWBrd (ORCPT ); Fri, 22 Sep 2017 21:47:33 -0400 Received: from merlin.infradead.org ([205.233.59.134]:58436 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752542AbdIWBrb (ORCPT ); Fri, 22 Sep 2017 21:47:31 -0400 To: LKML , linux-spi@vger.kernel.org, Mark Brown Cc: Baolin Wang From: Randy Dunlap Subject: [PATCH v2] spi: fix spi-sprd-adi build errors when HWSPINLOCK=m and SPI_SPRD_ADI=y Message-ID: <38b3774a-96b0-fc1d-5e91-e1665cb8c076@infradead.org> Date: Fri, 22 Sep 2017 18:47:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap Fix build errors when CONFIG_HWSPINLOCK=m and SPI_SPRD_ADI=y. That combination is not allowed. This allows building with HWSPINLOCK and SPI_SPRD_ADI in any combinations except for HWSPINLOCK=m and SPI_SPRD_ADI=y. drivers/spi/spi-sprd-adi.o: In function `sprd_adi_remove': spi-sprd-adi.c:(.text+0x13): undefined reference to `hwspin_lock_free' drivers/spi/spi-sprd-adi.o: In function `sprd_adi_probe': spi-sprd-adi.c:(.text+0xf5): undefined reference to `of_hwspin_lock_get_id' spi-sprd-adi.c:(.text+0x107): undefined reference to `hwspin_lock_request_specific' spi-sprd-adi.c:(.text+0x22e): undefined reference to `hwspin_lock_free' drivers/spi/spi-sprd-adi.o: In function `sprd_adi_transfer_one': spi-sprd-adi.c:(.text+0x2eb): undefined reference to `__hwspin_lock_timeout' spi-sprd-adi.c:(.text+0x349): undefined reference to `__hwspin_unlock' spi-sprd-adi.c:(.text+0x389): undefined reference to `__hwspin_lock_timeout' spi-sprd-adi.c:(.text+0x3ee): undefined reference to `__hwspin_unlock' Signed-off-by: Randy Dunlap Cc: Baolin Wang Cc: Mark Brown Cc: linux-spi@vger.kernel.org --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+) v2: allow build with or without HWSPINLOCK, but restrict SPI_SPRD_ADI to =m if HWSPINLOCK=m. --- linux-next-20170921.orig/drivers/spi/Kconfig +++ linux-next-20170921/drivers/spi/Kconfig @@ -625,6 +625,7 @@ config SPI_SIRF config SPI_SPRD_ADI tristate "Spreadtrum ADI controller" depends on ARCH_SPRD || COMPILE_TEST + depends on HWSPINLOCK || HWSPINLOCK=n help ADI driver based on SPI for Spreadtrum SoCs.