From mboxrd@z Thu Jan 1 00:00:00 1970 From: "johann deneux" Subject: Re: [PATCH] Added device to hid-ff Date: Fri, 16 Feb 2007 16:43:54 +0100 Message-ID: <38b3b7c0702160743g67ae3e55pbccad84eefc2368b@mail.gmail.com> References: <38b3b7c0702151056m7c396952j81199783f654bf7a@mail.gmail.com> <45D4B9AB.70509@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_6263_4452801.1171640634515" Return-path: In-Reply-To: <45D4B9AB.70509@gmail.com> Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Anssi Hannula Cc: Dmitry Torokhov , "STenyaK (Bruno Gonzalez)" , linux-input , Valentin Zagura List-Id: linux-input@vger.kernel.org ------=_Part_6263_4452801.1171640634515 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline On 2/15/07, Anssi Hannula wrote: > > Dmitry Torokhov wrote: > > On 2/15/07, STenyaK (Bruno Gonzalez) wrote: > >> Sorry for not providing a proper patch, could you please also add > >> {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel > >> to the list? I tested it here and that wheel is also working. > >> > > > > OK. > > > > Hmm.. Shouldn't an entry also be added to the devices[] list in > hid-lgff.c for these devices? (and it seems one device is already > missing from there in the current kernel). > > I'm not able to check right now, but I think some earlier kernels may > have defaulted to ff_joystick if no entry is present in devices[], hence > these devices working for some without the entry. > (so the alternative is to restore that behaviour) Yes, defaulting to joystick was the way it was when I wrote hid-lgff.c, and I guess Valentin made his original patch on a kernel where defaulting was still there. I'll send a separate mail with the patch adding the devices there too, but I personally think defaulting was nice. Was there a reason behind the removal? -- Johann ------=_Part_6263_4452801.1171640634515 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On 2/15/07, Anssi Hannula <anssi.hannula@gmail.com> wrote:
Dmitry Torokhov wrote:
> On 2/15/07, STenyaK (Bruno Gonzalez) <stenyak@gmail.com> wrote:
>> Sorry for not providing a proper patch, could you please also add
>>         {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel
>> to the list? I tested it here and that wheel is also working.
>>
>
> OK.
>

Hmm.. Shouldn't an entry also be added to the devices[] list in
hid-lgff.c for these devices? (and it seems one device is already
missing from there in the current kernel).

I'm not able to check right now, but I think some earlier kernels may
have defaulted to ff_joystick if no entry is present in devices[], hence
these devices working for some without the entry.
(so the alternative is to restore that behaviour)

Yes, defaulting to joystick was the way it was when I wrote hid-lgff.c, and I guess Valentin made his original patch on a kernel where defaulting was still there.
I'll send a separate mail with the patch adding the devices there too, but I personally think defaulting was nice. Was there a reason behind the removal?

--
Johann

------=_Part_6263_4452801.1171640634515--