From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D2A7C34049 for ; Tue, 18 Feb 2020 17:32:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CBC42467B for ; Tue, 18 Feb 2020 17:32:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbgBRRca (ORCPT ); Tue, 18 Feb 2020 12:32:30 -0500 Received: from foss.arm.com ([217.140.110.172]:56946 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726865AbgBRRc3 (ORCPT ); Tue, 18 Feb 2020 12:32:29 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F5C131B; Tue, 18 Feb 2020 09:32:29 -0800 (PST) Received: from [10.1.196.37] (e121345-lin.cambridge.arm.com [10.1.196.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 13CAC3F703; Tue, 18 Feb 2020 09:32:24 -0800 (PST) Subject: Re: [RFC PATCH 06/11] iommu: arm-smmu: Remove Calxeda secure mode quirk To: Will Deacon , Rob Herring Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, soc@kernel.org, Andre Przywara , Robert Richter , Jon Loeliger , Alexander Graf , Matthias Brugger , Mark Langsdorf , Alex Williamson , Borislav Petkov , Cornelia Huck , Daniel Lezcano , "David S. Miller" , devicetree@vger.kernel.org, Eric Auger , iommu@lists.linux-foundation.org, James Morse , Jens Axboe , Joerg Roedel , kvm@vger.kernel.org, linux-clk@vger.kernel.org, linux-edac@vger.kernel.org, linux-ide@vger.kernel.org, linux-pm@vger.kernel.org, Mauro Carvalho Chehab , netdev@vger.kernel.org, "Rafael J. Wysocki" , Stephen Boyd , Tony Luck , Viresh Kumar References: <20200218171321.30990-1-robh@kernel.org> <20200218171321.30990-7-robh@kernel.org> <20200218172000.GF1133@willie-the-truck> From: Robin Murphy Message-ID: <38be84e3-d23f-1e91-4d3d-87fc11d7c089@arm.com> Date: Tue, 18 Feb 2020 17:32:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200218172000.GF1133@willie-the-truck> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 18/02/2020 5:20 pm, Will Deacon wrote: > On Tue, Feb 18, 2020 at 11:13:16AM -0600, Rob Herring wrote: >> Cc: Will Deacon >> Cc: Robin Murphy >> Cc: Joerg Roedel >> Cc: iommu@lists.linux-foundation.org >> Signed-off-by: Rob Herring >> --- >> Do not apply yet. > > Pleeeeease? ;) > >> drivers/iommu/arm-smmu-impl.c | 43 ----------------------------------- Presumably we also want to remove the definition of the option from binding too. >> 1 file changed, 43 deletions(-) > > Yes, I'm happy to get rid of this. Sadly, I don't think we can remove > anything from 'struct arm_smmu_impl' because most implementations fall > just short of perfect. Right, this served as the prototype for register access hooks, but we have at least one other known user for those. > Anyway, let me know when I can push the button and I'll queue this in > the arm-smmu tree. FWIW the quirk has proven useful in other circumstances too, but I imagine if we ever have to prototype an integration on VExpress-CA9 again, reverting this patch will hardly be the most unpleasant part :) Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B22F7C3404B for ; Tue, 18 Feb 2020 17:32:33 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86ED922B48 for ; Tue, 18 Feb 2020 17:32:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86ED922B48 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 592F9204A5; Tue, 18 Feb 2020 17:32:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v0HOc2GnyKZA; Tue, 18 Feb 2020 17:32:32 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id A8E3D2000E; Tue, 18 Feb 2020 17:32:32 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 89835C08A0; Tue, 18 Feb 2020 17:32:32 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id C1066C013E for ; Tue, 18 Feb 2020 17:32:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 9995A85D22 for ; Tue, 18 Feb 2020 17:32:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lDigq2HY3RjQ for ; Tue, 18 Feb 2020 17:32:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by hemlock.osuosl.org (Postfix) with ESMTP id AD43182476 for ; Tue, 18 Feb 2020 17:32:29 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F5C131B; Tue, 18 Feb 2020 09:32:29 -0800 (PST) Received: from [10.1.196.37] (e121345-lin.cambridge.arm.com [10.1.196.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 13CAC3F703; Tue, 18 Feb 2020 09:32:24 -0800 (PST) Subject: Re: [RFC PATCH 06/11] iommu: arm-smmu: Remove Calxeda secure mode quirk To: Will Deacon , Rob Herring References: <20200218171321.30990-1-robh@kernel.org> <20200218171321.30990-7-robh@kernel.org> <20200218172000.GF1133@willie-the-truck> From: Robin Murphy Message-ID: <38be84e3-d23f-1e91-4d3d-87fc11d7c089@arm.com> Date: Tue, 18 Feb 2020 17:32:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200218172000.GF1133@willie-the-truck> Content-Language: en-GB Cc: Mark Langsdorf , kvm@vger.kernel.org, Viresh Kumar , linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, soc@kernel.org, Daniel Lezcano , devicetree@vger.kernel.org, Jon Loeliger , linux-pm@vger.kernel.org, Andre Przywara , Alex Williamson , Tony Luck , Alexander Graf , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, Jens Axboe , Matthias Brugger , Stephen Boyd , netdev@vger.kernel.org, Cornelia Huck , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Robert Richter , James Morse , Borislav Petkov , "David S. Miller" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 18/02/2020 5:20 pm, Will Deacon wrote: > On Tue, Feb 18, 2020 at 11:13:16AM -0600, Rob Herring wrote: >> Cc: Will Deacon >> Cc: Robin Murphy >> Cc: Joerg Roedel >> Cc: iommu@lists.linux-foundation.org >> Signed-off-by: Rob Herring >> --- >> Do not apply yet. > > Pleeeeease? ;) > >> drivers/iommu/arm-smmu-impl.c | 43 ----------------------------------- Presumably we also want to remove the definition of the option from binding too. >> 1 file changed, 43 deletions(-) > > Yes, I'm happy to get rid of this. Sadly, I don't think we can remove > anything from 'struct arm_smmu_impl' because most implementations fall > just short of perfect. Right, this served as the prototype for register access hooks, but we have at least one other known user for those. > Anyway, let me know when I can push the button and I'll queue this in > the arm-smmu tree. FWIW the quirk has proven useful in other circumstances too, but I imagine if we ever have to prototype an integration on VExpress-CA9 again, reverting this patch will hardly be the most unpleasant part :) Robin. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80408C34047 for ; Tue, 18 Feb 2020 17:32:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53F092465A for ; Tue, 18 Feb 2020 17:32:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AyM00cxk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53F092465A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0SG3J14xH0LPnbULdtb3S1gHJm0yzy+cACREVcX8wKo=; b=AyM00cxktHEuSzDtygn971iVo DJtxiqv73ZwXA/ThjzIrxndkSU3QN+S3Fdj4SW2O8lNQ8fGVgW5zGTSqD/qur2Q4YiarO8NJdeo6V Rg5+O8JPoQpmehf5G/KDItUMu0OsgIJ5TJNADEaLMxPpCgEEwyrny7xElc1yS+7tIj4zQADo4QzhF LSbdOWYTmCgzogorU2RDWfenP6eIr/FU5K8fwzgo7pf53j9jP2YESNdudVDi6jyUAp7vhQQ0JsDsS ddpkn5+B+ZYA/vzCD5Z69CA1U5eCPhAUaaD+SogI/w0Et+URpAqRKW46NOgxArbFWr3wOpWgQK/TJ G4BgS4tPg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j46ja-0005lh-Pe; Tue, 18 Feb 2020 17:32:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j46jX-0005ji-GO for linux-arm-kernel@lists.infradead.org; Tue, 18 Feb 2020 17:32:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F5C131B; Tue, 18 Feb 2020 09:32:29 -0800 (PST) Received: from [10.1.196.37] (e121345-lin.cambridge.arm.com [10.1.196.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 13CAC3F703; Tue, 18 Feb 2020 09:32:24 -0800 (PST) Subject: Re: [RFC PATCH 06/11] iommu: arm-smmu: Remove Calxeda secure mode quirk To: Will Deacon , Rob Herring References: <20200218171321.30990-1-robh@kernel.org> <20200218171321.30990-7-robh@kernel.org> <20200218172000.GF1133@willie-the-truck> From: Robin Murphy Message-ID: <38be84e3-d23f-1e91-4d3d-87fc11d7c089@arm.com> Date: Tue, 18 Feb 2020 17:32:23 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200218172000.GF1133@willie-the-truck> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200218_093231_593080_9C47F90A X-CRM114-Status: GOOD ( 16.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Langsdorf , kvm@vger.kernel.org, Viresh Kumar , linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, soc@kernel.org, Joerg Roedel , Daniel Lezcano , devicetree@vger.kernel.org, Jon Loeliger , linux-pm@vger.kernel.org, Andre Przywara , Eric Auger , Alex Williamson , Tony Luck , Alexander Graf , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, Jens Axboe , Matthias Brugger , Stephen Boyd , netdev@vger.kernel.org, Cornelia Huck , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Robert Richter , James Morse , Borislav Petkov , "David S. Miller" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/02/2020 5:20 pm, Will Deacon wrote: > On Tue, Feb 18, 2020 at 11:13:16AM -0600, Rob Herring wrote: >> Cc: Will Deacon >> Cc: Robin Murphy >> Cc: Joerg Roedel >> Cc: iommu@lists.linux-foundation.org >> Signed-off-by: Rob Herring >> --- >> Do not apply yet. > > Pleeeeease? ;) > >> drivers/iommu/arm-smmu-impl.c | 43 ----------------------------------- Presumably we also want to remove the definition of the option from binding too. >> 1 file changed, 43 deletions(-) > > Yes, I'm happy to get rid of this. Sadly, I don't think we can remove > anything from 'struct arm_smmu_impl' because most implementations fall > just short of perfect. Right, this served as the prototype for register access hooks, but we have at least one other known user for those. > Anyway, let me know when I can push the button and I'll queue this in > the arm-smmu tree. FWIW the quirk has proven useful in other circumstances too, but I imagine if we ever have to prototype an integration on VExpress-CA9 again, reverting this patch will hardly be the most unpleasant part :) Robin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel