From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39215) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d81pk-0001hq-PY for qemu-devel@nongnu.org; Tue, 09 May 2017 05:53:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d81ph-00066n-Lk for qemu-devel@nongnu.org; Tue, 09 May 2017 05:53:32 -0400 References: <1494322876-28843-1-git-send-email-armbru@redhat.com> <1494322876-28843-2-git-send-email-armbru@redhat.com> From: Thomas Huth Message-ID: <38c73cb6-b128-0aab-3c4e-ffa9f402dcda@redhat.com> Date: Tue, 9 May 2017 11:53:25 +0200 MIME-Version: 1.0 In-Reply-To: <1494322876-28843-2-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] docs qemu-doc: Avoid ide-drive, it's deprecated List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org On 09.05.2017 11:41, Markus Armbruster wrote: > Suggested-by: Thomas Huth > Signed-off-by: Markus Armbruster > --- > docs/bootindex.txt | 2 +- > docs/qdev-device-use.txt | 4 ++-- > qemu-options.hx | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/docs/bootindex.txt b/docs/bootindex.txt > index b9a8ba1..6937862 100644 > --- a/docs/bootindex.txt > +++ b/docs/bootindex.txt > @@ -13,7 +13,7 @@ Let's assume we have a QEMU machine with two NICs (virtio, e1000) and two > disks (IDE, virtio): > > qemu -drive file=disk1.img,if=none,id=disk1 > - -device ide-drive,drive=disk1,bootindex=4 > + -device ide-hd,drive=disk1,bootindex=4 > -drive file=disk2.img,if=none,id=disk2 > -device virtio-blk-pci,drive=disk2,bootindex=3 > -netdev type=user,id=net0 -device virtio-net-pci,netdev=net0,bootindex=2 > diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt > index b059405..caf779b 100644 > --- a/docs/qdev-device-use.txt > +++ b/docs/qdev-device-use.txt > @@ -31,8 +31,8 @@ A QEMU block device (drive) has a host and a guest part. > > In the general case, the guest device is connected to a controller > device. For instance, the IDE controller provides two IDE buses, each > -of which can have up to two ide-drive devices, and each ide-drive > -device is a guest part, and is connected to a host part. > +of which can have up to two devices, and each device is a guest part, > +and is connected to a host part. > > Except we sometimes lump controller, bus(es) and drive device(s) all > together into a single device. For instance, the ISA floppy > diff --git a/qemu-options.hx b/qemu-options.hx > index f68829f..37147b3 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -224,7 +224,7 @@ STEXI > Set default value of @var{driver}'s property @var{prop} to @var{value}, e.g.: > > @example > -qemu-system-i386 -global ide-drive.physical_block_size=4096 -drive file=file,if=ide,index=0,media=disk > +qemu-system-i386 -global ide-hd.physical_block_size=4096 disk-image.img > @end example > > In particular, you can use this to set driver properties for devices which are > Reviewed-by: Thomas Huth