From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEDQk-0004B7-Jh for qemu-devel@nongnu.org; Sun, 21 Oct 2018 09:06:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gEDEI-0002KB-9G for qemu-devel@nongnu.org; Sun, 21 Oct 2018 08:53:17 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:54573) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gEDEI-0002Jz-2a for qemu-devel@nongnu.org; Sun, 21 Oct 2018 08:53:14 -0400 Received: by mail-wm1-x335.google.com with SMTP id r63-v6so7616343wma.4 for ; Sun, 21 Oct 2018 05:53:13 -0700 (PDT) References: <20181019010625.25294-1-cota@braap.org> <20181019010625.25294-8-cota@braap.org> From: Richard Henderson Message-ID: <38c8c109-c231-696e-2fb8-4fae6f3fb641@linaro.org> Date: Sun, 21 Oct 2018 13:53:09 +0100 MIME-Version: 1.0 In-Reply-To: <20181019010625.25294-8-cota@braap.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v3 07/56] target/m68k: rename cpu_halted to cpu_halt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" , qemu-devel@nongnu.org Cc: Paolo Bonzini , Laurent Vivier On 10/19/18 2:05 AM, Emilio G. Cota wrote: > To avoid a name clash with the soon-to-be-defined cpu_halted() helper. > > Cc: Laurent Vivier > Signed-off-by: Emilio G. Cota > --- > target/m68k/translate.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Although for this usage it's probably better to avoid the tcg_global_mem_new_i32 and just use tcg_gen_st_i32. Reviewed-by: Richard Henderson r~