From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A889A8004F for ; Thu, 28 Mar 2024 17:05:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711645558; cv=none; b=jSFeAbUhIjVqOATmVKEsgdaD/KYKXuNAp7AB9veOJGOXBI5AwjgaiHZR1PhzRf4z2iaggfihYCWnC49s02uZ/WAx2aGLpVcjmNaKks2E0JZ10sAgGcH/6gKk19ViWLdA20O14NPOPDwO3tr0ACm3yZ2PrAM26lS0ckdTdYjFWNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711645558; c=relaxed/simple; bh=wSsry2PMXLPRJT5NhTiuPA1FZxtDvgfhBGHxg4riOr4=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=DcMFSl89sefNbC5bAL0uhkkFv45Jc/wCEB+vZrjjLOhzLWqiqwCSW4XSh5qmotnvv1mHEWJToLflQW5i09TCHiUPXwzYP2JPiDrNAc4cv9+GlOuJWMXO/LJTrxHtNnAeyyw5v2yId+/m5lKHzVbBDkGcjDd0w3dLWkT+YjSa3+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VzTVIOOh; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VzTVIOOh" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2d6c8d741e8so17956261fa.3 for ; Thu, 28 Mar 2024 10:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711645555; x=1712250355; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=8UV269C+zXw1qTig2GGB1q1grJrIL/P42czrgTeCgxA=; b=VzTVIOOhSUQTcx1vlA6ObXvp6qGaHNcxqRblLYzeUefZZWXD6LEvFA3QC5ode6oUyd TsZQnmm/gKQaAKC2AeMWMOuMlndV7iY/gmSQN466WEE/vQLZP1zKoaJVUo8zJQazo/aR KZHCjlo0U1/934njzM2FldbSWa6TGuknKwj7maa7YO9swLJyVgihujEUofIhvIegxa9f FvShosevcp13L9Zh0GLNJrm80dfhqUGTe9N8W7li0w8iodWsWR4CppqRTaneHLKuGpBq 9NBxazIkdG3D6QJTkd58KibPMnONOE/WOmMGlinZz0aWNFtmx2bYbLdg9sJ1dKC1mAqE zeGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711645555; x=1712250355; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8UV269C+zXw1qTig2GGB1q1grJrIL/P42czrgTeCgxA=; b=YF91nPQVWpN3YemhUFy0XqvQ6jiX4AA76I89k6Rtc/tX2MypjXztHd3UC3kmH9JWfF 1+S0WkzLu8nawBPOb0i1NwW0Sy5re0Ahwnhpx//p5QmXBaJ5zQITRXRp8d+zImhth39E 0vfrr96x58tvTwZlPD6bz2aLW60ZBfosVIIYBDrz8ApPMxjDAc+FwGYseWbckd049M7R zL96IYT2o/zIcqvYJw0j3jpiX1VT6FA8o2Qt9/lf8fhdwwJSm4WrrxfTPUllFNfem59A 5cmYnxDt3X4HxDX8iL0kVRtZlKzT8zR6tEYQq2zDF88+FCHZ4ljmC+wLcI+dGLVo4Oyf niYQ== X-Forwarded-Encrypted: i=1; AJvYcCUl33LP6/uRrcRH9dJhQKdf5AXcUc+bzlb6mIpLZAl7fQQyCUFBM20+uOcanEmWkEsmN6wuChnEmZi/0vMJRwUU93YBHE+hVEDN4w5k X-Gm-Message-State: AOJu0YyssLBzf+b3o3XkuvNZmiqFuLcFZndueK3HyqE6zwU7fQG7d2wi H6zPz93qyf4U16pYAATvVWEsbl8SLLLnSrT1T+6dg/biHTt92RvSAQIvpfYEa/I= X-Google-Smtp-Source: AGHT+IFZbbgEPpP8HiHWB0MFkZHwyrileLkAqzyfyUOIrjDjVaxKv38u5/6CSekNPHOY1gdBGyKJ9A== X-Received: by 2002:a2e:8606:0:b0:2d6:f62b:6e08 with SMTP id a6-20020a2e8606000000b002d6f62b6e08mr2511766lji.27.1711645554835; Thu, 28 Mar 2024 10:05:54 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.50]) by smtp.gmail.com with ESMTPSA id u15-20020a05600c00cf00b00414041032casm4810878wmm.1.2024.03.28.10.05.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 10:05:54 -0700 (PDT) Message-ID: <38d2156e-fdc5-4196-b598-644a00a0c35f@linaro.org> Date: Thu, 28 Mar 2024 18:05:52 +0100 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH REVIEW] hwrng: add exynos Secure World RNG device driver From: Krzysztof Kozlowski To: Alexey Klimov , olivia@selenic.com, herbert@gondor.apana.org.au, sehi.kim@samsung.com, linux-samsung-soc@vger.kernel.org, peter.griffin@linaro.org, =?UTF-8?Q?=C5=81ukasz_Stelmach?= Cc: alim.akhtar@samsung.com, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com, andre.draszik@linaro.org, willmcvicker@google.com, saravanak@google.com, elder@linaro.org, tudor.ambarus@linaro.org, klimov.linux@gmail.com References: <20240328125056.1054878-1-alexey.klimov@linaro.org> <6b691a48-ca97-4f23-a09f-69b9254f0c11@linaro.org> <83607b46-56e4-45eb-ac69-9bc5be5bdee4@linaro.org> Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <83607b46-56e4-45eb-ac69-9bc5be5bdee4@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/03/2024 18:01, Krzysztof Kozlowski wrote: > On 28/03/2024 14:36, Krzysztof Kozlowski wrote: >>> + >>> +static UNIVERSAL_DEV_PM_OPS(exyswd_rng_pm_ops, exyswd_rng_suspend, >>> + exyswd_rng_resume, NULL); >>> + >>> +static struct platform_driver exyswd_rng_driver = { >>> + .probe = exyswd_rng_probe, >>> + .remove = exyswd_rng_remove, >>> + .driver = { >>> + .name = DRVNAME, >>> + .owner = THIS_MODULE, >> >> So this was fixed ~8-10 years ago. Yet it re-appears. Please do not use >> downstream code as template. >> >> Take upstream driver and either change it or customize it. > > Alex Elder pointed out that some of my comments might not be precise or > not helping enough. Let me clarify then: > > Please run all standard, open-source tools when submitting new driver, > which is: > 1. Coccinelle, which points to this specific line since 2014, > 2. smatch, > 3. sparse, > 4. checkpatch, > 5. If changing bindings: dt_binding_check, > 6. If changing DTS or bindings: dtbs_check. And I forgot: 7. make W=1 Many of these, including W=1 above, can be with target, e.g. `make W=1 drivers/char/hw_random/` to reduce the scope of tests/warnings etc. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1264CCD11DD for ; Thu, 28 Mar 2024 17:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wZQe3YQm1QCwUWp1tdwV32kpCbgCYoZJse1WQLz9o/A=; b=RMvpOXCJmS+ueq B/2VjTT9Htqh38MWOXhuQpVYmRybOYJKgcF3qF42Wa/bS0uHe+Am8GYbcmvbomKg9y6b8FjmDaT+I BBY0MgbOBdy/EKqECXcTEOCN3XcrKMeul9vAXF1hux1ezsrWZ8ZmZB1+qOyU2XXg56tVzr4ySdU0H THgxc+PIxSXvOFSN/QuJ3YYOq+Y0V5RBzevJsPNMo/mZAS5bP51grWHRtwxQckfMU4wa7EKKcOI7c 1rE05b8q7me++nOA4wncEUgredCfKoj5uLqotQ6bKJQtJa5a/YOcbSGUBCR3VXGvgWrEKMovkVeMC bZkJTZEBGZbBRUPAFixA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rptCt-0000000EuDY-2P1X; Thu, 28 Mar 2024 17:06:28 +0000 Received: from mail-lj1-f177.google.com ([209.85.208.177]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rptCQ-0000000EtwN-1xjz for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2024 17:06:02 +0000 Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2d6fc3adaacso17278161fa.2 for ; Thu, 28 Mar 2024 10:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711645555; x=1712250355; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=8UV269C+zXw1qTig2GGB1q1grJrIL/P42czrgTeCgxA=; b=DtHcTU4ZtkwYRCbxamk1AQiC7M57iF2ItYiilrwregigZ8M19GExTFbFLBVe5fUpH1 bsvI46arGTfvjjV3BkLAIOMUnoDBZ/4MAekAsgkUlUV1hD2awWnrgRDGSCP0OLV7st+X mJXiamGSWQoIRVlocWlO7MRlRoR+I0ej9qjD2c2sfx0PxBW44U63/KEnNQ0hSRQ8rdLN ieWapaU7pPcupTZog4kMbnok2ehfPSRdqEMblxdA59l/b0vfMi+XgIIkfniWC6yd2lnW otCCLBz3gNXIjyHkWiSUdtvUqHi61xwHEjKwNMzIbTbdSAsmSL/tvPPQ3ZtNI6aB977/ fdFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711645555; x=1712250355; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8UV269C+zXw1qTig2GGB1q1grJrIL/P42czrgTeCgxA=; b=TSRfo72NzgApzmufC/v2xnriVhV+FMYyJ2xGrQjtVpuOBGll/yvwaxOk5eoWRTDgmB Ue/xbjkCsTpbiH08fEQFNjcMCwUtQuos22Ygm16T2x4TLw+bYx6z6lKlAzVGNbAy1nmt Lx96kExUMjx32fXOqTfPD9V9Nczx1wEz1R956V5Wv+iyO/M1z32O4OpQHktQpbBt5CPW 2fORkCxdKLRYd69QFoPV8wYgApmTChGi0messkRb3U6VOvI8SGUstT9RHFF6C3Kmu/SN SzdiodExUDHk0bEJu4K3Mf9fqXghqLVKwLcXfDCMnp2O0aSRgTAW40iiK7IeWO0UETNB cdrg== X-Forwarded-Encrypted: i=1; AJvYcCVVcZVcb+74xUjmSnLIi1SAJtVv70LHXt0PXzkNmCOif+9mkYCag31AITj9RE0ell4KWBdo5ALEup9ffaHXRkHwZABnE6LackjgMOq4EgkRPXFBC24= X-Gm-Message-State: AOJu0YyqSQPv+GybE0zfeIPq0Mam702ww0qATWEGDO6T13+9EEuLhfv5 rH2LxdZVWhgAsazrK0j3ecSY259eIsS6ZYNB/kItk7wUGaUslEnlo++IZ8J2OJk= X-Google-Smtp-Source: AGHT+IFZbbgEPpP8HiHWB0MFkZHwyrileLkAqzyfyUOIrjDjVaxKv38u5/6CSekNPHOY1gdBGyKJ9A== X-Received: by 2002:a2e:8606:0:b0:2d6:f62b:6e08 with SMTP id a6-20020a2e8606000000b002d6f62b6e08mr2511766lji.27.1711645554835; Thu, 28 Mar 2024 10:05:54 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.50]) by smtp.gmail.com with ESMTPSA id u15-20020a05600c00cf00b00414041032casm4810878wmm.1.2024.03.28.10.05.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 10:05:54 -0700 (PDT) Message-ID: <38d2156e-fdc5-4196-b598-644a00a0c35f@linaro.org> Date: Thu, 28 Mar 2024 18:05:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH REVIEW] hwrng: add exynos Secure World RNG device driver From: Krzysztof Kozlowski To: Alexey Klimov , olivia@selenic.com, herbert@gondor.apana.org.au, sehi.kim@samsung.com, linux-samsung-soc@vger.kernel.org, peter.griffin@linaro.org, =?UTF-8?Q?=C5=81ukasz_Stelmach?= Cc: alim.akhtar@samsung.com, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com, andre.draszik@linaro.org, willmcvicker@google.com, saravanak@google.com, elder@linaro.org, tudor.ambarus@linaro.org, klimov.linux@gmail.com References: <20240328125056.1054878-1-alexey.klimov@linaro.org> <6b691a48-ca97-4f23-a09f-69b9254f0c11@linaro.org> <83607b46-56e4-45eb-ac69-9bc5be5bdee4@linaro.org> Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <83607b46-56e4-45eb-ac69-9bc5be5bdee4@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_100558_751609_8EAC24A1 X-CRM114-Status: GOOD ( 12.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/03/2024 18:01, Krzysztof Kozlowski wrote: > On 28/03/2024 14:36, Krzysztof Kozlowski wrote: >>> + >>> +static UNIVERSAL_DEV_PM_OPS(exyswd_rng_pm_ops, exyswd_rng_suspend, >>> + exyswd_rng_resume, NULL); >>> + >>> +static struct platform_driver exyswd_rng_driver = { >>> + .probe = exyswd_rng_probe, >>> + .remove = exyswd_rng_remove, >>> + .driver = { >>> + .name = DRVNAME, >>> + .owner = THIS_MODULE, >> >> So this was fixed ~8-10 years ago. Yet it re-appears. Please do not use >> downstream code as template. >> >> Take upstream driver and either change it or customize it. > > Alex Elder pointed out that some of my comments might not be precise or > not helping enough. Let me clarify then: > > Please run all standard, open-source tools when submitting new driver, > which is: > 1. Coccinelle, which points to this specific line since 2014, > 2. smatch, > 3. sparse, > 4. checkpatch, > 5. If changing bindings: dt_binding_check, > 6. If changing DTS or bindings: dtbs_check. And I forgot: 7. make W=1 Many of these, including W=1 above, can be with target, e.g. `make W=1 drivers/char/hw_random/` to reduce the scope of tests/warnings etc. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel