From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Wei Yongjun <weiyj.lk@gmail.com>,
Helmut Buchsbaum <helmut.buchsbaum@gmail.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH -next] net: macb: fix missing unlock on error in macb_start_xmit()
Date: Mon, 12 Sep 2016 09:38:06 +0200 [thread overview]
Message-ID: <38d7d9ba-bb2e-53d0-8a61-0e0e0ad97c38@atmel.com> (raw)
In-Reply-To: <1473506277-31304-1-git-send-email-weiyj.lk@gmail.com>
Le 10/09/2016 à 13:17, Wei Yongjun a écrit :
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix missing unlock before return from function macb_start_xmit()
> in the error handling case.
>
> Fixes: 007e4ba3ee13 ("net: macb: initialize checksum when using
> checksum offloading")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Yes,
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks. Best regards,
> ---
> drivers/net/ethernet/cadence/macb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 0294b6a..63144bb 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -1398,7 +1398,7 @@ static int macb_start_xmit(struct sk_buff *skb, struct net_device *dev)
>
> if (macb_clear_csum(skb)) {
> dev_kfree_skb_any(skb);
> - return NETDEV_TX_OK;
> + goto unlock;
> }
>
> /* Map socket buffer for DMA transfer */
>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2016-09-12 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 11:17 [PATCH -next] net: macb: fix missing unlock on error in macb_start_xmit() Wei Yongjun
2016-09-12 7:38 ` Nicolas Ferre [this message]
2016-09-12 17:40 ` Helmut Buchsbaum
2016-09-29 17:21 ` Nicolas Ferre
2016-09-13 15:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38d7d9ba-bb2e-53d0-8a61-0e0e0ad97c38@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=helmut.buchsbaum@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.