From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7BE5C07E99 for ; Mon, 5 Jul 2021 20:07:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A1366197F for ; Mon, 5 Jul 2021 20:07:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229757AbhGEUJv (ORCPT ); Mon, 5 Jul 2021 16:09:51 -0400 Received: from dispatch1-us1.ppe-hosted.com ([148.163.129.52]:46426 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229565AbhGEUJv (ORCPT ); Mon, 5 Jul 2021 16:09:51 -0400 X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.67.132]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 7E49F1C0061; Mon, 5 Jul 2021 20:07:12 +0000 (UTC) Received: from mail3.candelatech.com (mail2.candelatech.com [208.74.158.173]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 32D50500061; Mon, 5 Jul 2021 20:07:12 +0000 (UTC) Received: from [192.168.100.195] (50-251-239-81-static.hfc.comcastbusiness.net [50.251.239.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id B203913C2B1; Mon, 5 Jul 2021 13:07:11 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com B203913C2B1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1625515631; bh=8h4BJxrglOAVxnROZZ7hGmL5o9NCigAv20izN16DG9I=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=o84ZTBq5OxH8kc8eLi3w3DGysa+n6cHD/6MNyefkFtO0fiIXfU1RuL3XxK6vdwh1m 13O20c+qWqM2Tp9NmcVQrMbnczcsQzq7uYW9LEMiZCHSkssI7VpZ4OTMvjVOus6zC2 F1xdkFGaT5aLC5u3WxWv0fBiTKJR4/KAG1GM35WE= Subject: Re: backports spatch question To: Johannes Berg , Hauke Mehrtens Cc: backports@vger.kernel.org References: <84336f24b55f6ef407511235a90af4b24a8488ce.camel@sipsolutions.net> <6260cc7d2771a5d67e04736a036ae23c8441c57d.camel@sipsolutions.net> <31776ce8-7014-b3ed-41bf-121e8ce5001c@candelatech.com> <244749b289fcaca6826670471890420d4b51b6ed.camel@sipsolutions.net> <05c73f83ce63bc1e15c40836fce56dcdb7eb9a8b.camel@sipsolutions.net> <33deca8741a231072f2a835ccf7a93eac1430e9d.camel@sipsolutions.net> <9ace0ebe7417d5ade9f5f1df02e46ad982c11c5e.camel@sipsolutions.net> <5cb833b8-4c9d-7628-fd1d-d95f12c3962c@candelatech.com> <40985f693651f6712aad27f1033c48d99dc5298c.camel@sipsolutions.net> From: Ben Greear Organization: Candela Technologies Message-ID: <38e2f7d5-8315-7aea-3725-fada306643cf@candelatech.com> Date: Mon, 5 Jul 2021 13:07:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <40985f693651f6712aad27f1033c48d99dc5298c.camel@sipsolutions.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-MDID: 1625515633-A9u2Vte-i95H Precedence: bulk List-ID: X-Mailing-List: backports@vger.kernel.org On 7/5/21 12:32 PM, Johannes Berg wrote: > On Mon, 2021-07-05 at 12:32 -0700, Ben Greear wrote: >> On 7/5/21 12:26 PM, Johannes Berg wrote: >>> On Mon, 2021-07-05 at 12:26 -0700, Ben Greear wrote: >>>> On 7/5/21 12:19 PM, Johannes Berg wrote: >>>>> On Mon, 2021-07-05 at 12:17 -0700, Ben Greear wrote: >>>>>> >>>>>> Did you test it? >>>>>> >>>>> >>>>> Yes, pretty sure we do it basically all the time. We don't have kernels >>>>> that new yet in most of our test setups. >>>>> >>>>>>     Because that should be logically identical to what I tried if I read this file properly: >>>>> >>>>> Actually, your version might be more correct than ours ... >>>>> >>>>> I dunno. I note we also have an include in cfg80211.h, >>>>> but that should be there upstream too, so not sure. >>>> >>>> There are a lot of rfkill.h files, what logic makes the backports code include the specific >>>> backport/backport-include/linux/rfkill.h file? I suspect that isn't working for the cfg80211.h >>>> file for whatever reason. >>> >>> It's just an additional -I flag on the compiler command line, or - >>> isystem or something like that. >>> >>> johannes >>> >> >> my cfg80211.h shows this line: >> >> #include > > Not a later line? We have one like that in our version > ... > > I guess we should really only have the one, but since > we want the function declaration, we really ought to have that? > > johannes > > This got me further....will debug next problem now... [greearb@ben-dt4 linux-5.13.dev.y]$ git show commit 2c307ff3476bdedd76b2929028b3a9cdc9a42620 (HEAD -> master, origin/master, origin/HEAD) Author: Ben Greear Date: Mon Jul 5 12:52:11 2021 -0700 cfg80211: Include linux/rfkill.h, not uapi/linux/rfkill.h This should help when using the kernel with backports. Signed-off-by: Ben Greear diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index 49154fb347e7..cf41d75b23d2 100644 --- a/include/net/cfg80211.h +++ b/include/net/cfg80211.h @@ -11,7 +11,7 @@ */ #include -#include +#include #include #include #include -- Ben Greear Candela Technologies Inc http://www.candelatech.com -- To unsubscribe from this list: send the line "unsubscribe backports" in