From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A22C9C433E0 for ; Thu, 4 Jun 2020 11:06:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 723FB206A2 for ; Thu, 4 Jun 2020 11:06:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fYlG5Rwa"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tFO+2ppu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 723FB206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cYshQlho/XFUcm9YtIM9PkyMFXJbvd2NvD2cn5dpwfk=; b=fYlG5RwaF2nUWf BDXNF0RbTJ9wW4EPpJhM4YHFzf13mmcaiNTy8Az04/60BiOocconiXzawoXIbP18NQZ6a7m60082D SKUEeRYErkov6/nTfBH+XVu4Xt2jszz5QMP+dfnzEURcH1xKjIhvpLDfTTcaSq1ZTvbE/TN/FyDhA 67J6Ww6BsN5zvBo0SakZGFbt/uMNdi7dbzkwqxi7lQaC7JlGX5/rdG++nw3hnYWffZdwgLspSlX1R KQ7YteQ348G5+aZdJtCs1yuUGDzrxVrtIw0kUgdXDkJlAIAOlLwZPkN/gaGaRR2vvDW/NwnDwphpZ Xi0khZ+z1GZiUFRwupsQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgnhO-0001Et-VZ; Thu, 04 Jun 2020 11:06:14 +0000 Received: from mail-qv1-xf43.google.com ([2607:f8b0:4864:20::f43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgnhM-0001ET-5L for linux-snps-arc@lists.infradead.org; Thu, 04 Jun 2020 11:06:14 +0000 Received: by mail-qv1-xf43.google.com with SMTP id y9so2675163qvs.4 for ; Thu, 04 Jun 2020 04:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UTnbBfd0kna19TDW9hQpzvFjavQSTmNaM2twmVdIm44=; b=tFO+2ppuGjri/F++iHVlmzaUQ0o/7Jxp8QUa8+ETjmqpbEa5Brcq3/8mVglwn/kF0Z S6r/O3IVwKu8daVGX+iDMqEmK8c0+fSudIPYvHM8W0WcyAg0zseLo54/M19+sLAJxNKV glTC0Nx6GwJ7T9iStcmcnPr/kzr2ZD2gsgNuif9wpYEaBLftuJOBNkd22nEMq2kwdd+a h+0Y3wt84qZ3ncZHLVA9cNlpDtvdOq8pIu1Pji8B1zUpTkCyE/oWhmGL8wIw7l41/56I xq3Bf/YprCt/hRBtzxgg9MV5eQUK2ReFQ5eK/jjoRSMMnyQ/rwGOMJms3IMTV2b9rZJv XSzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=UTnbBfd0kna19TDW9hQpzvFjavQSTmNaM2twmVdIm44=; b=GAzTMOkk1/RCigd62p9UdrvqhC4Wa9VraP4tgG+Qg6ANEQfdf0+WzF6nqWP5BeJTpA THUeEFwJFTXyjsh9+NZK7U6gZV3Ne6AGaAWRXEAyz5EFArj6aNrEhYXmiqGqmcfdYETr OBSUqE1kyEACoJM8fM2w9yIaC5OTtcylKW713glM09bXT3yG+duel/ELK5lTpgcb+kky 6lonEAxDivEYm/BIqNHYyq8fDb+tIoCUFv4mf9ailanXDVPlTagWEaQBFAj4lCQa01BF WI5sQvdnctM4CAJd6OfoQIfy39ai+vse4X3uUv8mu0Fqvko0gGspST7nILw8P57HAFvS acbw== X-Gm-Message-State: AOAM531MsLfM2OlcJoGAMwihbjmognXgdkZp4y+g7VP1dXhKWINGN6Wt n2lMrJY02JjgyT9gbu+sYePSXCiR3cw= X-Google-Smtp-Source: ABdhPJxDR8ahp/nPBoJah1JX9bIo0VbSzyJ/2Zok6JAFWVe2A+/dN5jB2S4kq8QXZVH/a2WrnnwJgQ== X-Received: by 2002:a05:6214:90e:: with SMTP id dj14mr4059683qvb.3.1591268769578; Thu, 04 Jun 2020 04:06:09 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id f7sm3788174qkk.88.2020.06.04.04.06.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2020 04:06:08 -0700 (PDT) Subject: Re: [PATCH v6 07/13] ARC: Linux Syscall Interface To: Vineet Gupta , "libc-alpha@sourceware.org" References: <20200423014126.10417-1-vgupta@synopsys.com> <20200423014126.10417-8-vgupta@synopsys.com> <248259c7-8263-805d-56cd-9db397eb9c04@linaro.org> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <38ef4944-8c03-0784-50e5-0c8227d7cac8@linaro.org> Date: Thu, 4 Jun 2020 08:06:06 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200604_040612_214307_5AFABDCF X-CRM114-Status: GOOD ( 12.75 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-snps-arc@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On 03/06/2020 17:17, Vineet Gupta wrote: > On 6/3/20 1:04 PM, Adhemerval Zanella via Libc-alpha wrote: >> >> >> On 03/06/2020 16:46, Vineet Gupta wrote: >>> On 5/29/20 9:49 AM, Adhemerval Zanella via Libc-alpha wrote: >>>>> + ; ----- child starts here --------- >>>>> + >>>>> + ; Setup TP register (only recent kernels v4.19+ do that) >>>>> + and.f 0, r12, CLONE_SETTLS >>>>> + mov.nz r25, r9 >>>> Do you still need to set it since the minimum supported kernel >>>> for ARC is 5.1 ? >>> >>> Right. >>> >>>> It should be safe for internal glibc usage, since for both pthread >>>> and posix_spawn it blocks all signals including SIGCANCEL and SIGXID. >>>> However this is still small race window if this is called directly >>>> with pthread cancellation or g*uid in multithread. >>> >>> I'm not sure what you mean above. Do you mean not doing this in glibc and even if >>> kernel support didn't exist should be safe internally ? >> >> At least for internal clone usage with CLONE_VM within glibc we explicit >> disable all signals (posix_spawn and pthread_create). >> >>> >>> fwiw as mentioned above kernel sets up TP for clone (SETTLS). I detested doing >>> that for a long time, give ABI implications but ended up doing it anyways due to >>> an actual race hit when running uClibc tst-kill6 [1] >> >> We explicit disable all signals during the create_thread call in pthread_create >> (b3cae39dcbfa2432b3f3aa28854d8ac57f0de1b8), so it should not happen on glibc >> anymore. However it is still an issue if application calls clone itself. > > The scenario there was pthread_create() and parent getting scheduled before child > and immediately doing pthread_kill() causing child signal handler to be invoked > and signal handler doing pthread_self() which was broken as TP was not setup. > > With commit above, parent pthread_kill() will block and will only run when child > is scheduled and unblocks the signals ! It could happen with other scenarios when signal plus tp accesses were involved as well: pthread_cancel the thread (since the sigcancel_handler acesses the tp with THREAD_GETMEM macro), setg* functions (since sighandler_setxid), or any functions with a syscall failure that sets the errno. _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc