From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:39405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gontK-0003l6-2B for qemu-devel@nongnu.org; Wed, 30 Jan 2019 06:18:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gontJ-0005l5-CX for qemu-devel@nongnu.org; Wed, 30 Jan 2019 06:18:50 -0500 References: <1548834906-133241-1-git-send-email-imammedo@redhat.com> <20190130104155.08cc0ac9.cohuck@redhat.com> From: David Hildenbrand Message-ID: <38f1205b-7ccf-f8ba-112f-c7c65ab688f4@redhat.com> Date: Wed, 30 Jan 2019 12:18:44 +0100 MIME-Version: 1.0 In-Reply-To: <20190130104155.08cc0ac9.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] s390x: remove direct reference to mem_path global from s390x code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck , Igor Mammedov Cc: qemu-devel@nongnu.org, pasic@linux.ibm.com, borntraeger@de.ibm.com, qemu-s390x@nongnu.org, rth@twiddle.net On 30.01.19 10:41, Cornelia Huck wrote: > On Wed, 30 Jan 2019 08:55:06 +0100 > Igor Mammedov wrote: > >> I plan to deprecate -mem-path option and replace it with memory-backend, >> for that it's necessary to get rid of mem_path global variable. >> Do it for s390x case, replacing it with alternative way to enable >> 1Mb hugepages capability. >> >> Todo that replace qemu_mempath_getpagesize() with qemu_getrampagesize() >> which also checks for -mem-path provided RAM. >> >> Signed-off-by: Igor Mammedov >> --- >> v4: >> * fix typos in commit message >> * add include "exec/ram_addr.h" to make sure it compiles on ppc host >> v2: >> * s/qemu_mempath_getpagesize/qemu_getrampagesiz/ and drop the rest of changes >> David Hildenbrand > > Something odd happened here -- I presume you did not want to drop > David's R-b? > > [I can re-add while applying, no need to resend.] > Indeed, please add Reviewed-by: David Hildenbrand >> --- >> target/s390x/kvm.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) -- Thanks, David / dhildenb