From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C59F5C4338F for ; Sun, 1 Aug 2021 23:08:40 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC31B60F8F for ; Sun, 1 Aug 2021 23:08:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EC31B60F8F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D71B8832DE; Mon, 2 Aug 2021 01:08:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="HWi/lRke"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D012D832E4; Mon, 2 Aug 2021 01:08:36 +0200 (CEST) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C930982E3F for ; Mon, 2 Aug 2021 01:08:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20210801230811epoutp028ea47855ecc2444fdf83740bc9dfc158~XUWa5ZqMo1982219822epoutp02g for ; Sun, 1 Aug 2021 23:08:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20210801230811epoutp028ea47855ecc2444fdf83740bc9dfc158~XUWa5ZqMo1982219822epoutp02g DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1627859291; bh=za8/QR4nRiC7PlHUqX7NSprAUqXDGSRsrp9fKYLUY24=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=HWi/lRkev9GEkv+eRrVWHIOXSH186v1KmrNMtn3UvMk7Bog5ECIFRI1zAsi8O/TiI guEDPdTj/ueaEdKwmfx/SbhcxXr6+OFrY+Ksw9Q336Ih6nfwXtZhsevGhmFxrTdtkc r/jW26OvF61b77KzoV+HTtW70pzJnFFb8Sauns2g= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20210801230811epcas1p217f0bbb638b4e5f80129930aeea861ee~XUWamk7gb0682106821epcas1p2R; Sun, 1 Aug 2021 23:08:11 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.40.153]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4GdGyK46Zrz4x9Q0; Sun, 1 Aug 2021 23:08:09 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id EC.44.13454.95927016; Mon, 2 Aug 2021 08:08:09 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p4.samsung.com (KnoxPortal) with ESMTPA id 20210801230808epcas1p4457e141e60aa4f863b9166cab4f13681~XUWX6NYbr0270602706epcas1p4s; Sun, 1 Aug 2021 23:08:08 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20210801230808epsmtrp18f3c5aa4449eb62d621b463d1ae3466b~XUWX5Kg4a2890828908epsmtrp1H; Sun, 1 Aug 2021 23:08:08 +0000 (GMT) X-AuditID: b6c32a39-185ff7000002348e-1e-61072959e821 Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id A7.41.08394.85927016; Mon, 2 Aug 2021 08:08:08 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20210801230807epsmtip1a1f81720462db2066fdc2d05635a0744~XUWW__Uyg0524205242epsmtip1Y; Sun, 1 Aug 2021 23:08:07 +0000 (GMT) Subject: Re: [PATCH v3 1/7] mmc: zynq_sdhci: Return errors from arasan_sdhci_set_tapdelay To: Ashok Reddy Soma , u-boot@lists.denx.de Cc: peng.fan@nxp.com, faiz_abbas@ti.com, sjg@chromium.org, michael@walle.cc, git@xilinx.com, monstr@monstr.eu, somaashokreddy@gmail.com, T Karthik Reddy From: Jaehoon Chung Message-ID: <38f532e7-1603-c9c5-bb1f-c21ac5b1d741@samsung.com> Date: Mon, 2 Aug 2021 08:08:57 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210730122842.3264-2-ashok.reddy.soma@xilinx.com> Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBJsWRmVeSWpSXmKPExsWy7bCmnm6kJnuiwZldvBaHLjQwWXxZ2sxs MXnyGkaLt6c3sFs8+XiaxeLHqi+sFt+2bGO0mPZ4JZPF1asHWSze7u1kd+DymN1wkcVj56y7 7B5n7+xg9PjbNYXZY+O7HUwex29sZ/I4sLeFzWPv598sARxR2TYZqYkpqUUKqXnJ+SmZeem2 St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QFcqKZQl5pQChQISi4uV9O1sivJLS1IV MvKLS2yVUgtScgosC/SKE3OLS/PS9ZLzc60MDQyMTIEKE7IzXq5dzFzwRaTiw95mtgbGSYJd jJwcEgImElO2PmTvYuTiEBLYwSjReOoNC4TziVFi8uMeVgjnG6PE442TmGBaFt/bxwaR2Mso 8fH3AqiW94wSX5d8ZAapEhaIltj2dAc7iC0i4CFx7eF2RpAiZoGdjBJt6++zgiTYBHQktn87 DjaWV8BO4vPzE2ANLAIqEtePvgSzRQUiJc7vBtkAUiMocXLmEzCbU8BBYvmdW2BzmAXEJW49 mc8EYctLbH87hxlkmYTAHg6JTT2PgRIcQI6LxNZ3kRAvCEu8Or6FHcKWknjZ3wZlV0vsaj4D 1dvBKHFrWxPUz8YS+5dOBpvDLKApsX6XPkRYUWLn77mMEHv5JN59BYUXyCpeiY42IYgSFYlL r18yway6++Q/K4TtIdE3YT7zBEbFWUg+m4Xkm1lIvpmFsHgBI8sqRrHUguLc9NRiwwJT5Oje xAhOwlqWOxinv/2gd4iRiYPxEKMEB7OSCK/ZSrZEId6UxMqq1KL8+KLSnNTiQ4ymwLCeyCwl mpwPzAN5JfGGpkbGxsYWJoZmpoaGSuK832K/JggJpCeWpGanphakFsH0MXFwSjUwbbctk7pn b/3JcFvFSs1q+68zMi1mR0ra7zesNvu35I6YXthplxsXcr7P7+94b/bhQaBDZZ5858VqsVAB d6dUc2G+sHnuWYfmiGmv6ZW1KUnZp/RIOvTo5bQCt6V8K+8vsFZfMSvJc1ljg4hGpsqvmfOu PVz4ZYPfZqbYkwlfS3qunHg9tzJhX0PuKqc/q7U0VA1Xm94R8tUS19qs/Lp3cfGbAAO1k6b1 h7c0fik7y9qgsFM7Uflq39um4tXOtTxd+U7XjlkxF5cKeU4vmcLwzmLuoeO8hb8W/3DRMztf G7tQadX6n09Ku57GdFsW7rH4tquxXm257VKW3G2ce3gyY95uEPhzRSfic85V2zYlluKMREMt 5qLiRAAhOA1JSwQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGIsWRmVeSWpSXmKPExsWy7bCSnG6EJnuiQfclMYtDFxqYLL4sbWa2 mDx5DaPF29Mb2C2efDzNYvFj1RdWi29btjFaTHu8ksni6tWDLBZv93ayO3B5zG64yOKxc9Zd do+zd3YwevztmsLssfHdDiaP4ze2M3kc2NvC5rH382+WAI4oLpuU1JzMstQifbsEroyXaxcz F3wRqfiwt5mtgXGSYBcjJ4eEgInE4nv72LoYuTiEBHYzSmzYdYYRIiEl8fnpVKAEB5AtLHH4 cDFIWEjgLaPEwx0sILawQLTEtqc72EFsEQEPiWsPtzOCzGEW2AlUs+cAM8TQk4wSr+8vZgKp YhPQkdj+7TiYzStgJ/H5+QmwbhYBFYnrR1+C2aICkRKfF7xihagRlDg58wnYNk4BB4nld26B xZkF1CX+zLvEDGGLS9x6Mp8JwpaX2P52DvMERqFZSNpnIWmZhaRlFpKWBYwsqxglUwuKc9Nz iw0LDPNSy/WKE3OLS/PS9ZLzczcxgqNOS3MH4/ZVH/QOMTJxMB5ilOBgVhLhNVvJlijEm5JY WZValB9fVJqTWnyIUZqDRUmc90LXyXghgfTEktTs1NSC1CKYLBMHp1QDk1HEm4wlv43MDr00 5SzJ/Z667cmj0P89Wv082u/fvrV+9/1mtM8PxU1it0tC1s2ykp70enFwhajxmUn/fygxr8y6 sr3cRfbBRM9VWfzM0xzbdthX5a0R7sue/HW5/rtdd66tdXV94pt27/SaOlZpte++pS7HW/vy Zim07434YRnPpMYgdySzZElb7MQ3u0I2Ou5akLxL1Kb/92Kv02G9LJ8a8sv/mk5eopm0JiYr 5NCDt6Jtp2qPSBwt3N94fzLXoi8sXgzMvDmtXMKfT1as+KMYuSKia8q3CfVxX9wEY5XmtT38 NWnN3h3F5uwTNs3TnvG53rrgTMyJBRxNDyb9ipqQOL3xj/Vmqe4jSXa8vEosxRmJhlrMRcWJ APiBLEopAwAA X-CMS-MailID: 20210801230808epcas1p4457e141e60aa4f863b9166cab4f13681 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20210730122904epcas1p165b815cb23ca04fc4f03d11380e2f7ca References: <20210730122842.3264-1-ashok.reddy.soma@xilinx.com> <20210730122842.3264-2-ashok.reddy.soma@xilinx.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 7/30/21 9:28 PM, Ashok Reddy Soma wrote: > Change return type of arasan_sdhci_set_tapdelay() to int, to facilitate > returning errors. Get return values from input and output set clock phase > functions inside arasan_sdhci_set_tapdelay() and return those errors. > > Signed-off-by: T Karthik Reddy > Signed-off-by: Ashok Reddy Soma Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > Changes in v3: > - Added new line after return at two places > > Changes in v2: > - Split patch 1/7 to two patches, one for zynq_sdhci and other one > for sdhci > > drivers/mmc/zynq_sdhci.c | 23 ++++++++++++++++++----- > 1 file changed, 18 insertions(+), 5 deletions(-) > > diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c > index ba87ee8dd5..1ecc2ec669 100644 > --- a/drivers/mmc/zynq_sdhci.c > +++ b/drivers/mmc/zynq_sdhci.c > @@ -422,7 +422,7 @@ static int sdhci_versal_sampleclk_set_phase(struct sdhci_host *host, > return 0; > } > > -static void arasan_sdhci_set_tapdelay(struct sdhci_host *host) > +static int arasan_sdhci_set_tapdelay(struct sdhci_host *host) > { > struct arasan_sdhci_priv *priv = dev_get_priv(host->mmc->dev); > struct arasan_sdhci_clk_data *clk_data = &priv->clk_data; > @@ -431,18 +431,31 @@ static void arasan_sdhci_set_tapdelay(struct sdhci_host *host) > u8 timing = mode2timing[mmc->selected_mode]; > u32 iclk_phase = clk_data->clk_phase_in[timing]; > u32 oclk_phase = clk_data->clk_phase_out[timing]; > + int ret; > > dev_dbg(dev, "%s, host:%s, mode:%d\n", __func__, host->name, timing); > > if (IS_ENABLED(CONFIG_ARCH_ZYNQMP) && > device_is_compatible(dev, "xlnx,zynqmp-8.9a")) { > - sdhci_zynqmp_sampleclk_set_phase(host, iclk_phase); > - sdhci_zynqmp_sdcardclk_set_phase(host, oclk_phase); > + ret = sdhci_zynqmp_sampleclk_set_phase(host, iclk_phase); > + if (ret) > + return ret; > + > + ret = sdhci_zynqmp_sdcardclk_set_phase(host, oclk_phase); > + if (ret) > + return ret; > } else if (IS_ENABLED(CONFIG_ARCH_VERSAL) && > device_is_compatible(dev, "xlnx,versal-8.9a")) { > - sdhci_versal_sampleclk_set_phase(host, iclk_phase); > - sdhci_versal_sdcardclk_set_phase(host, oclk_phase); > + ret = sdhci_versal_sampleclk_set_phase(host, iclk_phase); > + if (ret) > + return ret; > + > + ret = sdhci_versal_sdcardclk_set_phase(host, oclk_phase); > + if (ret) > + return ret; > } > + > + return 0; > } > > static void arasan_dt_read_clk_phase(struct udevice *dev, unsigned char timing, >