From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F6FBC2BB48 for ; Tue, 15 Dec 2020 10:21:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D29FF22203 for ; Tue, 15 Dec 2020 10:21:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727610AbgLOKUL (ORCPT ); Tue, 15 Dec 2020 05:20:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:40496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727075AbgLOKTx (ORCPT ); Tue, 15 Dec 2020 05:19:53 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0641D20888; Tue, 15 Dec 2020 10:19:13 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kp7QF-001Rnq-0p; Tue, 15 Dec 2020 10:19:11 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 15 Dec 2020 10:19:10 +0000 From: Marc Zyngier To: Guenter Roeck Cc: Valentin Schneider , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andrew Lunn , Lorenzo Pieralisi , Jason Cooper , Scott Branden , Gregory Clement , Florian Fainelli , Ray Jui , Thomas Gleixner , Sebastian Hesselbarth Subject: Re: [PATCH 3/5] irqchip/bcm2836: Make IPIs use handle_percpu_devid_irq() In-Reply-To: <20201215002134.GA182208@roeck-us.net> References: <20201109094121.29975-1-valentin.schneider@arm.com> <20201109094121.29975-4-valentin.schneider@arm.com> <20201215002134.GA182208@roeck-us.net> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <38f8fbe9ceb7a0adb47e62d62260b297@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: linux@roeck-us.net, valentin.schneider@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, andrew@lunn.ch, Lorenzo.Pieralisi@arm.com, jason@lakedaemon.net, sbranden@broadcom.com, gregory.clement@bootlin.com, f.fainelli@gmail.com, rjui@broadcom.com, tglx@linutronix.de, sebastian.hesselbarth@gmail.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gunter, On 2020-12-15 00:21, Guenter Roeck wrote: > On Mon, Nov 09, 2020 at 09:41:19AM +0000, Valentin Schneider wrote: >> As done for the Arm GIC irqchips, move IPIs to >> handle_percpu_devid_irq() as >> handle_percpu_devid_fasteoi_ipi() isn't actually required. >> >> Signed-off-by: Valentin Schneider > > This patch results in boot failures (silent stall) for the qemu > raspi2 emulation. Unfortunately it can not be reverted because > handle_percpu_devid_fasteoi_ipi no longer exists in next-20201214, > so I don't know if it is the only problem. This is odd. This works just fine for me on both the RPi2 and 3 emulation, running a full Debian userspace. Could this be caused by the version of QEMU you are using? Here's what I have: $ qemu-system-arm --version QEMU emulator version 5.1.0 (Debian 1:5.1+dfsg-4+b1) Could you try the following hack and let me know if that helps? Thanks, M. diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c index 5f5eb8877c41..25c9a9c06e41 100644 --- a/drivers/irqchip/irq-bcm2836.c +++ b/drivers/irqchip/irq-bcm2836.c @@ -167,7 +167,7 @@ static void bcm2836_arm_irqchip_handle_ipi(struct irq_desc *desc) chained_irq_exit(chip, desc); } -static void bcm2836_arm_irqchip_ipi_eoi(struct irq_data *d) +static void bcm2836_arm_irqchip_ipi_ack(struct irq_data *d) { int cpu = smp_processor_id(); @@ -195,7 +195,7 @@ static struct irq_chip bcm2836_arm_irqchip_ipi = { .name = "IPI", .irq_mask = bcm2836_arm_irqchip_dummy_op, .irq_unmask = bcm2836_arm_irqchip_dummy_op, - .irq_eoi = bcm2836_arm_irqchip_ipi_eoi, + .irq_ack = bcm2836_arm_irqchip_ipi_ack, .ipi_send_mask = bcm2836_arm_irqchip_ipi_send_mask, }; -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE5E5C4361B for ; Tue, 15 Dec 2020 10:20:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7194620888 for ; Tue, 15 Dec 2020 10:20:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7194620888 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YxNDdW8LwIEMA1SNpsAot5rCWvBf9ktdCLqbGedI8Qg=; b=a6bJk/vPmtVt9o/75WWSXqGqn D76MtscI8iCWs/J7OciEjqDKObbDlzyoPlLxYujD84eUj6Ju3A7+VC6wGHOjjm3UGWRSTE5OE4KHg QcIfmr/ViHiPZenKQ+13Uv+tRlPRBA+4VtTAjncvtXKVfkPjg22f3gKb3hcjwoB/u5yHCSi8e+j7U gb/j3efsean1zqTRa4WIbC5XDVPtNwevnAqLfKNKY4sBR9lg5IMzNsrbyI34xyei9OCuHvNYBS1KL wevnzNXGul7Sonr2N4tP++Pyi76qIec6sMN169dewd9ervmzV502pSOyr6LSxOe6mr5LaHMUiOMLC 2Hwt6h+vQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp7QM-0007tc-6O; Tue, 15 Dec 2020 10:19:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kp7QJ-0007t4-Sf for linux-arm-kernel@lists.infradead.org; Tue, 15 Dec 2020 10:19:16 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0641D20888; Tue, 15 Dec 2020 10:19:13 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kp7QF-001Rnq-0p; Tue, 15 Dec 2020 10:19:11 +0000 MIME-Version: 1.0 Date: Tue, 15 Dec 2020 10:19:10 +0000 From: Marc Zyngier To: Guenter Roeck Subject: Re: [PATCH 3/5] irqchip/bcm2836: Make IPIs use handle_percpu_devid_irq() In-Reply-To: <20201215002134.GA182208@roeck-us.net> References: <20201109094121.29975-1-valentin.schneider@arm.com> <20201109094121.29975-4-valentin.schneider@arm.com> <20201215002134.GA182208@roeck-us.net> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <38f8fbe9ceb7a0adb47e62d62260b297@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: linux@roeck-us.net, valentin.schneider@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, andrew@lunn.ch, Lorenzo.Pieralisi@arm.com, jason@lakedaemon.net, sbranden@broadcom.com, gregory.clement@bootlin.com, f.fainelli@gmail.com, rjui@broadcom.com, tglx@linutronix.de, sebastian.hesselbarth@gmail.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201215_051916_025353_CBFA3BDE X-CRM114-Status: GOOD ( 17.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Lorenzo Pieralisi , Jason Cooper , Scott Branden , Ray Jui , Gregory Clement , linux-kernel@vger.kernel.org, Florian Fainelli , Thomas Gleixner , Valentin Schneider , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Gunter, On 2020-12-15 00:21, Guenter Roeck wrote: > On Mon, Nov 09, 2020 at 09:41:19AM +0000, Valentin Schneider wrote: >> As done for the Arm GIC irqchips, move IPIs to >> handle_percpu_devid_irq() as >> handle_percpu_devid_fasteoi_ipi() isn't actually required. >> >> Signed-off-by: Valentin Schneider > > This patch results in boot failures (silent stall) for the qemu > raspi2 emulation. Unfortunately it can not be reverted because > handle_percpu_devid_fasteoi_ipi no longer exists in next-20201214, > so I don't know if it is the only problem. This is odd. This works just fine for me on both the RPi2 and 3 emulation, running a full Debian userspace. Could this be caused by the version of QEMU you are using? Here's what I have: $ qemu-system-arm --version QEMU emulator version 5.1.0 (Debian 1:5.1+dfsg-4+b1) Could you try the following hack and let me know if that helps? Thanks, M. diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c index 5f5eb8877c41..25c9a9c06e41 100644 --- a/drivers/irqchip/irq-bcm2836.c +++ b/drivers/irqchip/irq-bcm2836.c @@ -167,7 +167,7 @@ static void bcm2836_arm_irqchip_handle_ipi(struct irq_desc *desc) chained_irq_exit(chip, desc); } -static void bcm2836_arm_irqchip_ipi_eoi(struct irq_data *d) +static void bcm2836_arm_irqchip_ipi_ack(struct irq_data *d) { int cpu = smp_processor_id(); @@ -195,7 +195,7 @@ static struct irq_chip bcm2836_arm_irqchip_ipi = { .name = "IPI", .irq_mask = bcm2836_arm_irqchip_dummy_op, .irq_unmask = bcm2836_arm_irqchip_dummy_op, - .irq_eoi = bcm2836_arm_irqchip_ipi_eoi, + .irq_ack = bcm2836_arm_irqchip_ipi_ack, .ipi_send_mask = bcm2836_arm_irqchip_ipi_send_mask, }; -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel