From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Andr=c3=a9_Przywara?= Subject: Re: [PATCH 1/2] drivers: pinctrl: add driver for Allwinner H5 SoC Date: Mon, 9 Jan 2017 00:16:00 +0000 Message-ID: <38fe3491-457a-f0c5-54fb-9defdcd45045@arm.com> References: <20161223125001.1176-1-icenowy@aosc.xyz> <1280f095-ab03-93f8-14d2-99d13ba1ce55@arm.com> <20170105224210.wfinfucbpkkd44om@lukather> Reply-To: andre.przywara-5wv7dgnIgG8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20170105224210.wfinfucbpkkd44om@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard , Linus Walleij Cc: ext Tony Lindgren , Icenowy Zheng , Catalin Marinas , Chen-Yu Tsai , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-sunxi List-Id: linux-gpio@vger.kernel.org On 05/01/17 22:42, Maxime Ripard wrote: > On Fri, Dec 30, 2016 at 01:55:44PM +0100, Linus Walleij wrote: >> On Mon, Dec 26, 2016 at 3:33 PM, Andr=C3=A9 Przywara wrote: >> >>> So while this patch technically looks correct, I was wondering if we >>> should really explore the possibility of making the whole of sunxi >>> pinctrl DT controlled. >>> I brought this up a while ago, but people weren't overly enthusiastic >>> about it, though their argument weren't really convincing to me[1]. >>> >>> So: >>> As this "driver" here is basically a table linking GPIO bit settings >>> (the actual mux value) to names and every pin we care about needs to be >>> enumerated in the DT anyway, why not just add something like: >>> allwinner,pinmux =3D <4>; >>> to each pin(group) in the DT and get rid of this "driver" file here >>> entirely? >> >> I'm open to that if you can use pinctrl-single which is in the kernel >> for this purpose only, and is used with both OMAPs and HiSilicon. >=20 > I'm not open to that, and I'm getting tired of discussing it over and > over again. Andre, if you want to be convinced again, please read the > last discussion we had on this topic. As I said: It didn't convince me back then. And frankly we didn't really discuss it back then, I just refrained from entering a discussion against _two_ maintainers at this time, since my capacity on this kind of email threads is really very limited - especially for something that is a hobby to me. It isn't the highest priority on my list, but I am still planning on sketching something, so that we can discuss about actual code. As it seems like your new patches bring some relief to the immediate copy&paste pain (though the actual DT aspect still remains), I will shut up - for now ;-) Cheers, Andre. --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162485AbdAIAQN (ORCPT ); Sun, 8 Jan 2017 19:16:13 -0500 Received: from foss.arm.com ([217.140.101.70]:43426 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750842AbdAIAQL (ORCPT ); Sun, 8 Jan 2017 19:16:11 -0500 Subject: Re: [linux-sunxi] [PATCH 1/2] drivers: pinctrl: add driver for Allwinner H5 SoC To: Maxime Ripard , Linus Walleij References: <20161223125001.1176-1-icenowy@aosc.xyz> <1280f095-ab03-93f8-14d2-99d13ba1ce55@arm.com> <20170105224210.wfinfucbpkkd44om@lukather> Cc: ext Tony Lindgren , Icenowy Zheng , Catalin Marinas , Chen-Yu Tsai , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , linux-sunxi From: =?UTF-8?Q?Andr=c3=a9_Przywara?= Organization: ARM Ltd. Message-ID: <38fe3491-457a-f0c5-54fb-9defdcd45045@arm.com> Date: Mon, 9 Jan 2017 00:16:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170105224210.wfinfucbpkkd44om@lukather> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/01/17 22:42, Maxime Ripard wrote: > On Fri, Dec 30, 2016 at 01:55:44PM +0100, Linus Walleij wrote: >> On Mon, Dec 26, 2016 at 3:33 PM, André Przywara wrote: >> >>> So while this patch technically looks correct, I was wondering if we >>> should really explore the possibility of making the whole of sunxi >>> pinctrl DT controlled. >>> I brought this up a while ago, but people weren't overly enthusiastic >>> about it, though their argument weren't really convincing to me[1]. >>> >>> So: >>> As this "driver" here is basically a table linking GPIO bit settings >>> (the actual mux value) to names and every pin we care about needs to be >>> enumerated in the DT anyway, why not just add something like: >>> allwinner,pinmux = <4>; >>> to each pin(group) in the DT and get rid of this "driver" file here >>> entirely? >> >> I'm open to that if you can use pinctrl-single which is in the kernel >> for this purpose only, and is used with both OMAPs and HiSilicon. > > I'm not open to that, and I'm getting tired of discussing it over and > over again. Andre, if you want to be convinced again, please read the > last discussion we had on this topic. As I said: It didn't convince me back then. And frankly we didn't really discuss it back then, I just refrained from entering a discussion against _two_ maintainers at this time, since my capacity on this kind of email threads is really very limited - especially for something that is a hobby to me. It isn't the highest priority on my list, but I am still planning on sketching something, so that we can discuss about actual code. As it seems like your new patches bring some relief to the immediate copy&paste pain (though the actual DT aspect still remains), I will shut up - for now ;-) Cheers, Andre. From mboxrd@z Thu Jan 1 00:00:00 1970 From: andre.przywara@arm.com (=?UTF-8?Q?Andr=c3=a9_Przywara?=) Date: Mon, 9 Jan 2017 00:16:00 +0000 Subject: [linux-sunxi] [PATCH 1/2] drivers: pinctrl: add driver for Allwinner H5 SoC In-Reply-To: <20170105224210.wfinfucbpkkd44om@lukather> References: <20161223125001.1176-1-icenowy@aosc.xyz> <1280f095-ab03-93f8-14d2-99d13ba1ce55@arm.com> <20170105224210.wfinfucbpkkd44om@lukather> Message-ID: <38fe3491-457a-f0c5-54fb-9defdcd45045@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/01/17 22:42, Maxime Ripard wrote: > On Fri, Dec 30, 2016 at 01:55:44PM +0100, Linus Walleij wrote: >> On Mon, Dec 26, 2016 at 3:33 PM, Andr? Przywara wrote: >> >>> So while this patch technically looks correct, I was wondering if we >>> should really explore the possibility of making the whole of sunxi >>> pinctrl DT controlled. >>> I brought this up a while ago, but people weren't overly enthusiastic >>> about it, though their argument weren't really convincing to me[1]. >>> >>> So: >>> As this "driver" here is basically a table linking GPIO bit settings >>> (the actual mux value) to names and every pin we care about needs to be >>> enumerated in the DT anyway, why not just add something like: >>> allwinner,pinmux = <4>; >>> to each pin(group) in the DT and get rid of this "driver" file here >>> entirely? >> >> I'm open to that if you can use pinctrl-single which is in the kernel >> for this purpose only, and is used with both OMAPs and HiSilicon. > > I'm not open to that, and I'm getting tired of discussing it over and > over again. Andre, if you want to be convinced again, please read the > last discussion we had on this topic. As I said: It didn't convince me back then. And frankly we didn't really discuss it back then, I just refrained from entering a discussion against _two_ maintainers at this time, since my capacity on this kind of email threads is really very limited - especially for something that is a hobby to me. It isn't the highest priority on my list, but I am still planning on sketching something, so that we can discuss about actual code. As it seems like your new patches bring some relief to the immediate copy&paste pain (though the actual DT aspect still remains), I will shut up - for now ;-) Cheers, Andre.