From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71E26C12002 for ; Thu, 15 Jul 2021 03:23:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 598F161377 for ; Thu, 15 Jul 2021 03:23:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231682AbhGODZy (ORCPT ); Wed, 14 Jul 2021 23:25:54 -0400 Received: from foss.arm.com ([217.140.110.172]:46162 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230495AbhGODZx (ORCPT ); Wed, 14 Jul 2021 23:25:53 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 494BF1042; Wed, 14 Jul 2021 20:23:01 -0700 (PDT) Received: from [10.163.66.71] (unknown [10.163.66.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C4C5E3F7D8; Wed, 14 Jul 2021 20:22:57 -0700 (PDT) Subject: Re: [PATCH 4/5] coresight: trbe: Move irq_work queue processing To: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, al.grant@arm.com, leo.yan@linaro.org, mathieu.poirier@linaro.org, mike.leach@linaro.org, peterz@infradead.org, Tamas.Zsoldos@arm.com, will@kernel.org References: <20210712113830.2803257-1-suzuki.poulose@arm.com> <20210712113830.2803257-5-suzuki.poulose@arm.com> From: Anshuman Khandual Message-ID: <390617ae-c5bd-b73a-c48c-e62b7f5330ca@arm.com> Date: Thu, 15 Jul 2021 08:53:46 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210712113830.2803257-5-suzuki.poulose@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/12/21 5:08 PM, Suzuki K Poulose wrote: > The TRBE driver issues the irq_work_run() to ensure that > any pending disable event callback has been processed. But this > is done before we mark the AUX buffer as TRUNCATED, making > the call pointless. Move the call after the current handle > has been closed. So there is a possibility that a disable event gets missed before the buffer is marked TRUNCATED ? But even then would not another disable event be triggered again subsequently ? Just trying to understand what is the actual problem because of the current placement of irq_work_run() ? > > Fixes: 3fbf7f011f24 ("coresight: sink: Add TRBE driver") > Reported-by: Tamas Zsoldos > Cc: Anshuman Khandual > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Peter Zijlstra (Intel) > Cc: Leo Yan > Cc: Will Deacon > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-trbe.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c > index ec38cf17b693..c0c264264427 100644 > --- a/drivers/hwtracing/coresight/coresight-trbe.c > +++ b/drivers/hwtracing/coresight/coresight-trbe.c > @@ -723,6 +723,14 @@ static void trbe_handle_overflow(struct perf_output_handle *handle) > perf_aux_output_flag(handle, PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW | > PERF_AUX_FLAG_TRUNCATED); > perf_aux_output_end(handle, size); > + > + /* > + * Ensure perf callbacks have completed. Since we > + * always TRUNCATE the buffer on IRQ, the event > + * is scheduled to be disabled. Make sure that happens > + * as soon as possible. > + */ > + irq_work_run(); > } > > static bool is_perf_trbe(struct perf_output_handle *handle) > @@ -777,12 +785,6 @@ static irqreturn_t arm_trbe_irq_handler(int irq, void *dev) > if (!is_perf_trbe(handle)) > return IRQ_NONE; > > - /* > - * Ensure perf callbacks have completed, which may disable > - * the trace buffer in response to a TRUNCATION flag. > - */ > - irq_work_run(); > - > act = trbe_get_fault_act(status); > switch (act) { > case TRBE_FAULT_ACT_WRAP: > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FFEFC12002 for ; Thu, 15 Jul 2021 03:24:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0CE261377 for ; Thu, 15 Jul 2021 03:24:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0CE261377 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=6+uuDwfr+OtYDhNCDTyMtT3IxWfb0TzloRElwyFSx+Q=; b=UFlOSO5D875zi4WnzKeB/qtpJv Ivz6NKbNfb7qDOaIUXtivdsuuYxYCIisTW/dCg3hvq8HR95W0wy2ORXjJUnTrx5GifCWMmkMRU0Xq F1jd6llenxaP66h7ElA5XsttlLUY1QMyKF+yCuIRPPJBK7XwCFLywNRp7r3pua5sqVRxhzh+d+ntO YUNeQxIhHNbohoJs9BzeGWrBT8Jn3/3HEkIe6+TyRQ8gIc8tkEU+IM6liqxtKOyAQdG64nWGr97bj AMSEqWHNpqBYptDtKAjWmb1WRhFDYSk+IVjymf6WXquRaSD1S2N9LKELAtRqiBqbQBMcFDYGBhapv Kk25ER4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3rxq-00H01e-14; Thu, 15 Jul 2021 03:23:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3rxm-00H00k-GW for linux-arm-kernel@lists.infradead.org; Thu, 15 Jul 2021 03:23:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 494BF1042; Wed, 14 Jul 2021 20:23:01 -0700 (PDT) Received: from [10.163.66.71] (unknown [10.163.66.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C4C5E3F7D8; Wed, 14 Jul 2021 20:22:57 -0700 (PDT) Subject: Re: [PATCH 4/5] coresight: trbe: Move irq_work queue processing To: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, al.grant@arm.com, leo.yan@linaro.org, mathieu.poirier@linaro.org, mike.leach@linaro.org, peterz@infradead.org, Tamas.Zsoldos@arm.com, will@kernel.org References: <20210712113830.2803257-1-suzuki.poulose@arm.com> <20210712113830.2803257-5-suzuki.poulose@arm.com> From: Anshuman Khandual Message-ID: <390617ae-c5bd-b73a-c48c-e62b7f5330ca@arm.com> Date: Thu, 15 Jul 2021 08:53:46 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210712113830.2803257-5-suzuki.poulose@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210714_202302_677882_F1F75364 X-CRM114-Status: GOOD ( 23.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/12/21 5:08 PM, Suzuki K Poulose wrote: > The TRBE driver issues the irq_work_run() to ensure that > any pending disable event callback has been processed. But this > is done before we mark the AUX buffer as TRUNCATED, making > the call pointless. Move the call after the current handle > has been closed. So there is a possibility that a disable event gets missed before the buffer is marked TRUNCATED ? But even then would not another disable event be triggered again subsequently ? Just trying to understand what is the actual problem because of the current placement of irq_work_run() ? > > Fixes: 3fbf7f011f24 ("coresight: sink: Add TRBE driver") > Reported-by: Tamas Zsoldos > Cc: Anshuman Khandual > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Peter Zijlstra (Intel) > Cc: Leo Yan > Cc: Will Deacon > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-trbe.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c > index ec38cf17b693..c0c264264427 100644 > --- a/drivers/hwtracing/coresight/coresight-trbe.c > +++ b/drivers/hwtracing/coresight/coresight-trbe.c > @@ -723,6 +723,14 @@ static void trbe_handle_overflow(struct perf_output_handle *handle) > perf_aux_output_flag(handle, PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW | > PERF_AUX_FLAG_TRUNCATED); > perf_aux_output_end(handle, size); > + > + /* > + * Ensure perf callbacks have completed. Since we > + * always TRUNCATE the buffer on IRQ, the event > + * is scheduled to be disabled. Make sure that happens > + * as soon as possible. > + */ > + irq_work_run(); > } > > static bool is_perf_trbe(struct perf_output_handle *handle) > @@ -777,12 +785,6 @@ static irqreturn_t arm_trbe_irq_handler(int irq, void *dev) > if (!is_perf_trbe(handle)) > return IRQ_NONE; > > - /* > - * Ensure perf callbacks have completed, which may disable > - * the trace buffer in response to a TRUNCATION flag. > - */ > - irq_work_run(); > - > act = trbe_get_fault_act(status); > switch (act) { > case TRBE_FAULT_ACT_WRAP: > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel