+ BUG_ON(mci->mc_idx >= EDAC_MAX_MCS); Do we have to "BUG_ON()" here? Couldn't we be gentler with something like: if (mci->mc_idx >= EDAC_MAX_MCS) { printk_once(KERN_WARNING "Too many memory controllers\n"); return; /* probably need to make sure caller copes with this ... so more stuff there */ } -Tony {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I