From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luck, Tony" Subject: RE: [PATCH 5/7 v6] trace, RAS: Add eMCA trace event interface Date: Fri, 30 May 2014 23:03:27 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F32823D2B@ORSMSX114.amr.corp.intel.com> References: <1400142646-10127-1-git-send-email-gong.chen@linux.intel.com> <1401247938-22125-1-git-send-email-gong.chen@linux.intel.com> <1401247938-22125-2-git-send-email-gong.chen@linux.intel.com> <20140528112832.5f83c66b@gandalf.local.home> <20140528163452.GF17196@pd.tnic> <20140528125625.6f6dcf7f@gandalf.local.home> <20140530092232.GA13495@gchen.bj.intel.com> <20140530100716.GE28131@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com ([192.55.52.88]:63907 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751983AbaE3XD3 (ORCPT ); Fri, 30 May 2014 19:03:29 -0400 In-Reply-To: <20140530100716.GE28131@pd.tnic> Content-Language: en-US Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Borislav Petkov , "Chen, Gong" Cc: Steven Rostedt , "m.chehab@samsung.com" , "linux-acpi@vger.kernel.org" , LKML Pj4gRm9yIG1lbW9yeSBlcnJvciBsb2NhdGlvbiwgSSB3aWxsIHV0aWxpemUgdHlwZSBvZmZzZXQg dG8gc2F2ZSBvbmUNCj4+IG1vcmUgYnl0ZSwgZnVydGhlcm1vcmUsIEkgd2FudCB0byBkcm9wIHJl cXVlc3Rvcl9pZCwgcmVzcG9uZGVyX2lkDQo+PiBhbmQgdGFyZ2V0X2lkLiAxKSBUaGV5IGFyZSB2 ZXJ5IHJhcmUgKEkndmUgbmV2ZXIgc2VlbiB0aGVtIGJ5IG5vdykNCj4NCj4gTXkgY29uY2VybiBp cywgYXJlIHdlIHN1cmUgd2UncmUgbmV2ZXIgZ29pbmcgdG8gbmVlZCB0aGVtIGF0IGFsbD8gVG9u eSwNCj4gd2hhdCdzIHlvdXIgdGFrZSBvbiB0aGlzPw0KDQpUaGV5IG1heSBzZWVtIHJhcmUgYmVj YXVzZSBvdXIgQklPUyBkb2Vzbid0IGJvdGhlciB0byBwcm92aWRlIHRoZW0uDQpPdGhlciBCSU9T IHdyaXRlcnMgbWF5IGJlIG1vcmUgZGlsaWdlbnQuDQoNCkkgZmxpcC1mbG9wIG9uIHRoZSBpc3N1 ZSBvZiBob3cgbXVjaCBkZXRhaWwgdG8gbG9nLiAgRm9yIHRoZSBtYWpvcml0eQ0Kb2YgdXNlcnMg aXQgaXMgZW5vdWdoIHRvIGp1c3QgcG9pbnQgYXQgdGhlIERJTU0uICBUaGF0J3MgdGhlIHRoaW5n IHRoYXQNCnRoZXkgY2FuIGVhc2lseSByZXBsYWNlLg0KDQpCdXQgT0VNcyBhbmQgbGFyZ2Ugc2Nh bGUgdXNlcnMgb2Z0ZW4gd2FudCB0byBrbm93IGV2ZXJ5IHRpbnkgZGV0YWlsDQpzbyB0aGV5IGNh biBsb29rIGZvciBwYXR0ZXJucyBiZXR3ZWVuIGVycm9ycyByZXBvcnRlZCBhY3Jvc3MgYSBsYXJn ZQ0KZmxlZXQuIFNvIEkgaGF0ZSB0byBkcm9wIGluZm9ybWF0aW9uIG9uIHRoZSBmbG9vciB0aGF0 IG1pZ2h0IGJlIHVzZWZ1bA0KdG8gc29tZW9uZSBsYXRlci4NCg0KQWxsIG9mIHRoaXMgc3R1ZmYg b25seSBhcHBsaWVzIHRvIHNlcnZlciBzeXN0ZW1zIC0gc28gcXVpYmJsaW5nIG92ZXINCmEgaGFu ZGZ1bCBvZiAqYnl0ZXMqIGluIGFuIGVycm9yIHJlY29yZCBvbiBhIHN5c3RlbSB0aGF0IGhhcyB0 ZW5zLA0KaHVuZHJlZHMgb3IgZXZlbiB0aG91c2FuZHMgb2YgKmdpZ2FieXRlcyogb2YgbWVtb3J5 IHNlZW1zDQphIGJpdCBwb2ludGxlc3MuDQoNCi1Ub255DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934702AbaE3XDa (ORCPT ); Fri, 30 May 2014 19:03:30 -0400 Received: from mga01.intel.com ([192.55.52.88]:63907 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751983AbaE3XD3 (ORCPT ); Fri, 30 May 2014 19:03:29 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.98,944,1392192000"; d="scan'208";a="540266048" From: "Luck, Tony" To: Borislav Petkov , "Chen, Gong" CC: Steven Rostedt , "m.chehab@samsung.com" , "linux-acpi@vger.kernel.org" , LKML Subject: RE: [PATCH 5/7 v6] trace, RAS: Add eMCA trace event interface Thread-Topic: [PATCH 5/7 v6] trace, RAS: Add eMCA trace event interface Thread-Index: AQHPeilSOyJTIZwXt0erLrK7gz6USJtWk/0AgAASiACAAAYGgIACpdkAgAAMgACAAGDh4A== Date: Fri, 30 May 2014 23:03:27 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F32823D2B@ORSMSX114.amr.corp.intel.com> References: <1400142646-10127-1-git-send-email-gong.chen@linux.intel.com> <1401247938-22125-1-git-send-email-gong.chen@linux.intel.com> <1401247938-22125-2-git-send-email-gong.chen@linux.intel.com> <20140528112832.5f83c66b@gandalf.local.home> <20140528163452.GF17196@pd.tnic> <20140528125625.6f6dcf7f@gandalf.local.home> <20140530092232.GA13495@gchen.bj.intel.com> <20140530100716.GE28131@pd.tnic> In-Reply-To: <20140530100716.GE28131@pd.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s4UN3fnU020091 >> For memory error location, I will utilize type offset to save one >> more byte, furthermore, I want to drop requestor_id, responder_id >> and target_id. 1) They are very rare (I've never seen them by now) > > My concern is, are we sure we're never going to need them at all? Tony, > what's your take on this? They may seem rare because our BIOS doesn't bother to provide them. Other BIOS writers may be more diligent. I flip-flop on the issue of how much detail to log. For the majority of users it is enough to just point at the DIMM. That's the thing that they can easily replace. But OEMs and large scale users often want to know every tiny detail so they can look for patterns between errors reported across a large fleet. So I hate to drop information on the floor that might be useful to someone later. All of this stuff only applies to server systems - so quibbling over a handful of *bytes* in an error record on a system that has tens, hundreds or even thousands of *gigabytes* of memory seems a bit pointless. -Tony {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I