RE: [PATCH] x86, mce, severities: Add AMD severities function

["Luck, Tony" <tony.luck@intel.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 871 bytes --]

>> And I call this from mcheck_init().
>> I tested the above bits on AMD and the severities grading works fine.
>> 
>> Should we also come up with a '_default' function to assign to mce_severity
>> function pointer?
>
>I think that should be
>
>	default:
>		WARN_ONCE("WTF?!");
>		break;

mcheck_init() is called unconditionally from setup_arch().  So if anyone is
still using a Cyrix, Transmeta or other non-Intel, non-Amd processor we'd trip this WARN_ON.

I think you can have a default severity function that just does:

	return MCE_PANIC_SEVERITY;

just to avoid the unpleasant thought that we might jump through a NULL pointer
if we did somehow end up in do_machine_check() on another vendors cpu.

-Tony
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥