From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752397AbcKIShZ (ORCPT ); Wed, 9 Nov 2016 13:37:25 -0500 Received: from mga01.intel.com ([192.55.52.88]:58277 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbcKIShY (ORCPT ); Wed, 9 Nov 2016 13:37:24 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,614,1473145200"; d="scan'208";a="899592323" From: "Luck, Tony" To: Borislav Petkov , Sebastian Andrzej Siewior CC: "linux-kernel@vger.kernel.org" , "rt@linutronix.de" , "linux-edac@vger.kernel.org" , "x86@kernel.org" , "Thomas Gleixner" Subject: RE: [PATCH 22/25] x86/mcheck: Do the init in one place Thread-Topic: [PATCH 22/25] x86/mcheck: Do the init in one place Thread-Index: AQHSNeHObH1YU3nVYUW7Srggeic4T6DOaJUA//98pQCAAJugAIAA3OYAgAHl9oCAABUrgP//q5wg Date: Wed, 9 Nov 2016 18:37:23 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F3A229E6C@ORSMSX114.amr.corp.intel.com> References: <20161103145021.28528-1-bigeasy@linutronix.de> <20161103145021.28528-23-bigeasy@linutronix.de> <20161107184532.xj6wzdjlzwhshcmf@pd.tnic> <20161107185524.GA2536@intel.com> <20161107201224.7xazmhgm7bogkrw5@pd.tnic> <20161108092302.wraci5m2cxqozlew@pd.tnic> <20161109142221.3r6xwhkxbckuv3bh@linutronix.de> <20161109153807.7mv7b5f4oqfijq2h@pd.tnic> In-Reply-To: <20161109153807.7mv7b5f4oqfijq2h@pd.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id uA9IbhkR018028 > That's why the hotplug callback mce_disable_cpu() doesn't fiddle with > CR4 - it only clears the bits in MCi_CTL. And I think we should remain > that way. N.B. See vendor_disable_error_reporting() ... on Intel we don't clear MCi_CTL. -Tony