From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F833C433DF for ; Wed, 14 Oct 2020 13:38:46 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id EA22A2173E for ; Wed, 14 Oct 2020 13:38:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA22A2173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 38A541DE1D; Wed, 14 Oct 2020 15:33:57 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 334821BF1D for ; Wed, 14 Oct 2020 15:33:55 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id D1931CB3; Wed, 14 Oct 2020 09:33:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 14 Oct 2020 09:33:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= KVITW/vQQ7rHUWT23MGUgm0YFYGHXhPH0p7EAF7CoIg=; b=KZ1RJbQlQ2c47yBO 8S5uOsCoHK0wvYhELuQ4qESPVwuuXu/zvjX1h/4/fLWjQF1FAnwgdd9Jpq9tCRGk ++WyH1oB6oCxfSkPr7lpagn4yNS9gid3ro2htlDDfvLD0hvzh/eFPsyZxzGo5cgz 5sQgIotMsixA/MzufoPeQMTPq2f9Am43DGz+CPgzW6uNihriAqK6Y7Tn9kIZf21B RmkOEsiuxH2IERyTGcRnmNZoV9WjLUfeWHLYsMnDk4xdRQv6gYtGEd0erxRXwrOQ ChGccNvZD3lET7sU45GB6Jbgpyh4jRF3OuJojLo0fiYzvgdGMpU78tXZtR6gjpdP cFiHVQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=KVITW/vQQ7rHUWT23MGUgm0YFYGHXhPH0p7EAF7Co Ig=; b=PmoRCN0WtGJdcImgRkL9m66DF0Eb4Gnujr+1atBG7DaoCIpCElZOtx5h0 S5sVR3d2go6cLK4dFc+8BxP9mQQsHXOONdxknr5FEx7f3a1L4DREO+QVM6OiO7ZC mpH0xDC2rGD+ToqGjKPzfxsKzgVVDAcwBk7LqL3eAz59yWKowFSR8FDkN5RFWoB/ h1eHrt2X1kOYkybmjCd7Vvq7WYI0zrnWMRhMPJs3HEvUNJV51jZL6ZhGDcIBXr6K v2erg+XE2Bq/q3I9pksRjcXgqrr1f29NyVVmEyXZbsy8FE63z3V/gD+MoYW2OBEF 2mRWiHerpH7qvaLiVXi+1sBYwl9ug== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedriedugdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C3D623280059; Wed, 14 Oct 2020 09:33:50 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko , Andrew Rybchenko , Ivan Ilchenko Cc: Ray Kinsella , Neil Horman , Ferruh Yigit , dev@dpdk.org Date: Wed, 14 Oct 2020 15:33:49 +0200 Message-ID: <3910167.mFdbjSblXh@thomas> In-Reply-To: <1602682146-4722-2-git-send-email-arybchenko@solarflare.com> References: <1602682146-4722-1-git-send-email-arybchenko@solarflare.com> <1602682146-4722-2-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 01/11] ethdev: change eth dev stop function to return int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/10/2020 15:28, Andrew Rybchenko: > From: Ivan Ilchenko > > Change rte_eth_dev_stop() return value from void to int > and return negative errno values in case of error conditions. > Also update the usage of the function in ethdev according to > the new return type. > > Signed-off-by: Ivan Ilchenko Please no capital letter in the email address. > Signed-off-by: Andrew Rybchenko Thanks for taking care of this cleanup. A note in the API changes of the release notes is missing. Except that miss, Acked-by: Thomas Monjalon