All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Muhammad Bilal <m.bilal@emumba.com>
Cc: hemant.agrawal@nxp.com, olivier.matz@6wind.com,
	stephen@networkplumber.org, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] putting null checks on ops_name
Date: Sat, 25 Apr 2020 22:59:57 +0200	[thread overview]
Message-ID: <3912068.8vf5iQgoFF@thomas> (raw)
In-Reply-To: <20200407075613.29273-1-m.bilal@emumba.com>

07/04/2020 09:56, Muhammad Bilal:
> Bugzilla ID: 353
> Cc: dev@dpdk.org
> Cc: stable@dpdk.org
> Cc: hemant.agrawal@nxp.com
> Signed-off-by: Muhammad Bilal <m.bilal@emumba.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

No need to Cc stable in my opinion, as there is no bug fixed.

Changing the name to:
	mbuf: prevent setting mempool ops name empty

Applied with below minor change, thanks


The blank line below should remain:

>  	const struct rte_memzone *mz;
> -
> -	if (strlen(ops_name) >= RTE_MEMPOOL_OPS_NAMESIZE)
> +	size_t len = strnlen(ops_name, RTE_MEMPOOL_OPS_NAMESIZE);
> +	if (len == 0)
> +		return -EINVAL;




      parent reply	other threads:[~2020-04-25 21:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 11:30 [dpdk-dev] [PATCH] putting null checks on ops_name Muhammad Bilal
2020-04-06 15:20 ` Stephen Hemminger
2020-04-07  7:56 ` [dpdk-dev] [PATCH v2] " Muhammad Bilal
2020-04-07 10:16   ` Hemant Agrawal
2020-04-25 20:59   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3912068.8vf5iQgoFF@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=m.bilal@emumba.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.