From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bw2kV-0002jK-Ca for qemu-devel@nongnu.org; Mon, 17 Oct 2016 03:54:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bw2kQ-0001Yk-EA for qemu-devel@nongnu.org; Mon, 17 Oct 2016 03:54:19 -0400 Sender: Paolo Bonzini References: <1476380062-18001-1-git-send-email-pbonzini@redhat.com> <1476380062-18001-8-git-send-email-pbonzini@redhat.com> <20161016102531.GC11739@stefanha-x1.localdomain> From: Paolo Bonzini Message-ID: <391cebcd-e82b-a655-e431-707e3cdbf6b7@redhat.com> Date: Mon, 17 Oct 2016 09:54:05 +0200 MIME-Version: 1.0 In-Reply-To: <20161016102531.GC11739@stefanha-x1.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/18] block: introduce bdrv_poll_while and bdrv_wakeup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, qemu-block@nongnu.org, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On 16/10/2016 12:25, Stefan Hajnoczi wrote: > On Thu, Oct 13, 2016 at 07:34:11PM +0200, Paolo Bonzini wrote: >> @@ -485,9 +474,14 @@ void bdrv_inc_in_flight(BlockDriverState *bs) >> atomic_inc(&bs->in_flight); >> } >> >> +void bdrv_wakeup(BlockDriverState *bs) >> +{ >> +} > > Please write a doc comment explaining the semantics of this new API. > > Since it's a nop here it may be better to introduce bdrv_wakeup() in > another patch. Okay, will do. Paolo