From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1J4PfX-0006K0-9F
	for qemu-devel@nongnu.org; Mon, 17 Dec 2007 18:46:43 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1J4PfT-0006Ea-OB
	for qemu-devel@nongnu.org; Mon, 17 Dec 2007 18:46:42 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1J4PfT-0006ES-KI
	for qemu-devel@nongnu.org; Mon, 17 Dec 2007 18:46:39 -0500
Received: from 0xc2c0b63d.fbbft3nxf1.bf-dhcp.tele.dk ([194.192.182.61]
	helo=smtp.hotelhot.dk) by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mail@flac.kalibalik.dk>) id 1J4PfT-0005ie-1u
	for qemu-devel@nongnu.org; Mon, 17 Dec 2007 18:46:39 -0500
Message-ID: <3924.N1pNGSpdEBQ=.1197935190.squirrel@webmail.hotelhot.dk>
In-Reply-To: <4766EBDB.1020308@qumranet.com>
References: <E1J3tMn-0001vY-5p@cvs.savannah.gnu.org>
	<200712161430.35113.paul@codesourcery.com>
	<476543A0.9090207@flac.kalibalik.dk>
	<200712170058.35739.paul@codesourcery.com>
	<4766EBDB.1020308@qumranet.com>
Date: Tue, 18 Dec 2007 00:46:30 +0100 (CET)
Subject: Re: [Qemu-devel] qemu vl.c
From: "Anders" <mail@flac.kalibalik.dk>
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org


>>>>> 	Redundant timer rearm optimisation by Anders Melchiorsen.

> I'm merging qemu-cvs into the kvm repository now, and with this commit
> in, kvm will hang after about a minute.  Attaching to it with gdb or
> strace will cause it to resume, so this is very likely a missing signal
> problem.

That is clearly not good.

I still cannot see anything wrong with my patch. As fewer signals are
delivered now, it is possible that this change highlights some old race.
It is certainly also possible that my patch is all wrong, even if I am no=
t
able to see it.


The next few days I will be travelling, but when I get back, I was
planning to address Pauls concern by adding

  qemu_rearm_alarm_timer(alarm_timer);

to the bottom of qemu_mod_timer().

If you feel like it, you can try that out. I am predicting that I will
have a hard time reproducing your hang, as I have only been testing with
kvm, and obviously not seen this problem yet.

(What I really plan to add is a rearm only if the new timer is added at
the head of the list, but the above should do for a test)


Cheers,
Anders.