From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 0/3] new API to free consumed buffers in Tx ring Date: Mon, 23 Jan 2017 16:25:28 +0100 Message-ID: <3938869.5RB17SFArz@xps13> References: <20170120160109.1088-1-bmcfall@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: wenzhuo.lu@intel.com, dev@dpdk.org To: Billy McFall Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id B5A61DE5 for ; Mon, 23 Jan 2017 16:25:30 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id r126so138198705wmr.0 for ; Mon, 23 Jan 2017 07:25:30 -0800 (PST) In-Reply-To: <20170120160109.1088-1-bmcfall@redhat.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Thanks for bringing a new convenient API. 2017-01-20 11:01, Billy McFall: > Based on a request from Damjan Marion and seconded by Keith Wiles, see > dpdk-dev mailing list from 11/21/2016, Generally we use links to ML archives to show prior discussions. > add a new API to free consumed > buffers on TX ring. This addresses two scenarios: > 1) Flooding a packet and want to reuse existing mbuf to avoid a packet > copy. Increment the reference count of the packet and poll new API until > reference count is decremented. > 2) Application runs out of mbufs, or resets and is preparing for > additional run, call API to free consumed packets so processing can > continue. > > API will return the number of packets freed (0-n) or error code if > feature not supported (-ENOTSUP) or input invalid (-ENODEV). > > API for e1000 igb driver and vHost driver have been implemented. Other > drivers can be implemented over time. Some drivers implement a Tx done > flush routine that should be reused where possible. e1000 igb driver > and vHost driver do not have such functions. Before considering to use such API, user apps may check how well it is supported by drivers in this table: http://dpdk.org/doc/guides/nics/overview.html Please add this feature in the appropriate files: doc/guides/nics/features/default.ini in patch 1 doc/guides/nics/features/e1000.ini in patch 2 doc/guides/nics/features/vhost.ini in patch 3 Then it will be introduced in the beginning of the 17.05 cycle. So more drivers could be implemented before the 17.05 release. Does it sound good? PS: please use --in-reply-to when sending new versions to keep track of versions changes and discussions.