From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick DELAUNAY <patrick.delaunay@st.com>
Date: Tue, 13 Oct 2020 17:01:00 +0000
Subject: [PATCH v2] ARM: stm32: Use firmware property instead of loadables
In-Reply-To: <e3dae1b8e2ad50f0f27483cd0d0b09454d57dba1.1601890618.git.michal.simek@xilinx.com>
References: <e3dae1b8e2ad50f0f27483cd0d0b09454d57dba1.1601890618.git.michal.simek@xilinx.com>
Message-ID: <3940dad3bfb142369b40f84dec48c493@SFHDAG2NODE3.st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Michael and Marek,

> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Michal Simek
> Sent: lundi 5 octobre 2020 11:37
> 
> There shouldn't be a need to use loadables propertyn because u-boot can be
> pointed by firmware property. This change should also speedup boot process
> because loadables property is list of strings which code is going through.
> On the other hand firmware can just point to one image.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
> Changes in v2:
> - Also add dhcor
> - Fix subject typo
> 
> Only done based on grepping the code. Please retest.
> 
> ---
>  board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its | 8 ++++----
> board/dhelectronics/dh_stm32mp1/u-boot-dhcor.its | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its
> b/board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its
> index 905be57dffd7..dfe89bfad67e 100644
> --- a/board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its
> +++ b/board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its
> @@ -39,28 +39,28 @@
>  		config-1 {
>  			/* DT+SoM+board model */
>  			description = "dh,stm32mp15xx-dhcom-
> pdk2_somrev0_boardrev0";
> -			loadables = "uboot";
> +			firmware = "uboot";
>  			fdt = "fdt-1";
>  		};
> 
>  		config-2 {
>  			/* DT+SoM+board model */
>  			description = "dh,stm32mp15xx-dhcom-
> pdk2_somrev1_boardrev0";
> -			loadables = "uboot";
> +			firmware = "uboot";
>  			fdt = "fdt-1";
>  		};
> 
>  		config-3 {
>  			/* DT+SoM+board model */
>  			description = "dh,stm32mp15xx-dhcom-
> drc02_somrev0_boardrev0";
> -			loadables = "uboot";
> +			firmware = "uboot";
>  			fdt = "fdt-2";
>  		};
> 
>  		config-4 {
>  			/* DT+SoM+board model */
>  			description = "dh,stm32mp15xx-dhcom-
> drc02_somrev1_boardrev0";
> -			loadables = "uboot";
> +			firmware = "uboot";
>  			fdt = "fdt-2";
>  		};
> 
> diff --git a/board/dhelectronics/dh_stm32mp1/u-boot-dhcor.its
> b/board/dhelectronics/dh_stm32mp1/u-boot-dhcor.its
> index 7419684f5599..0ea10a14972e 100644
> --- a/board/dhelectronics/dh_stm32mp1/u-boot-dhcor.its
> +++ b/board/dhelectronics/dh_stm32mp1/u-boot-dhcor.its
> @@ -31,7 +31,7 @@
>  		config-1 {
>  			/* DT+SoM+board model */
>  			description = "arrow,stm32mp15xx-
> avenger96_somrev0_boardrev1";
> -			loadables = "uboot";
> +			firmware = "uboot";
>  			fdt = "fdt-1";
>  		};
> 
> --
> 2.28.0

Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>

Marek, I don't see any objection, it is also ok for you ? 
And can you test dh board with this patch ?

Thanks

Patrick