All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Jozwiak, TomaszX" <tomaszx.jozwiak@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
	david.marchand@redhat.com, fiona.trahe@intel.com,
	yskoh@mellanox.com, tomaszx.cel@intel.com
Subject: Re: [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case
Date: Fri, 19 Apr 2019 13:25:56 +0200	[thread overview]
Message-ID: <3955282.IgHOaonqCx@xps> (raw)
In-Reply-To: <CA70B6012E3ADB4184D44E025E5FF01B6A20A888@LCSMSX155.ger.corp.intel.com>

19/04/2019 12:57, Jozwiak, TomaszX:
> > What is supposed to be "i"?
> > It is initialized at 0 and never touched.
> >
> It's touched inside test_deflate_comp_decomp function.

What do you mean?
It's a local variable and its address is referenced:
	int_data.buf_idx = &i;
It looks really wrong.

Another error is seen in FreeBSD.

Should I totally revert this patch?




  parent reply	other threads:[~2019-04-19 11:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-19  9:57 [dpdk-dev] [PATCH] test/compress: fix max mbuf size test case Tomasz Jozwiak
2019-04-19 10:05 ` Bruce Richardson
2019-04-19 10:17 ` Thomas Monjalon
     [not found]   ` <CA70B6012E3ADB4184D44E025E5FF01B6A20A888@LCSMSX155.ger.corp.intel.com>
2019-04-19 11:25     ` Thomas Monjalon [this message]
2019-04-19 11:36       ` Jozwiak, TomaszX
2019-04-19 11:50         ` Thomas Monjalon
2019-04-19 12:14           ` Jozwiak, TomaszX
2019-04-19 17:01             ` Trahe, Fiona
2019-04-19 10:49 ` David Marchand
2019-04-19 11:45 ` [dpdk-dev] [PATCH v2] " Tomasz Jozwiak
2019-04-19 16:52   ` [dpdk-dev] [PATCH v3] " Fiona Trahe
2019-04-19 21:06     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3955282.IgHOaonqCx@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=tomaszx.cel@intel.com \
    --cc=tomaszx.jozwiak@intel.com \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.