From: Alex Elder <elder@linaro.org>
To: Janusz Dziedzic <janusz.dziedzic@gmail.com>,
linux-kernel@vger.kernel.org
Cc: linux-soc@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
Date: Tue, 26 Oct 2021 08:42:58 -0500 [thread overview]
Message-ID: <39561c73-732e-bc38-e250-a0bdf51b09f9@linaro.org> (raw)
In-Reply-To: <20211025163121.2189630-1-janusz.dziedzic@gmail.com>
On 10/25/21 11:31 AM, Janusz Dziedzic wrote:
> From: Alex Elder <elder@linaro.org>
>
> Add a prompt to the "tristate" attribute in the Kconfig file in
> which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
> without it.
This was a *long* time ago!
https://lore.kernel.org/all/20180427140358.30839-1-elder@linaro.org/
The discussion that followed indicated that the thing that needs
QCOM_QMI_HELPERS should *select* it rather than *depend on it.
Will this not work for you?
-Alex
> We need it in OpenWRT project, when using WiFi backports
> and build ath11k driver. While ath11k driver depends on
> QCOM_QMI_HELPERS we need way to enable this option in
> our kernel.
>
> Signed-off-by: Alex Elder <elder@linaro.org>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@gmail.com>
> ---
> drivers/soc/qcom/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index fe3c486ae32d..16fb8e286015 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -92,7 +92,7 @@ config QCOM_PDR_HELPERS
> select QCOM_QMI_HELPERS
>
> config QCOM_QMI_HELPERS
> - tristate
> + tristate "Qualcomm QMI Helpers"
> depends on NET
>
> config QCOM_RMTFS_MEM
>
next prev parent reply other threads:[~2021-10-26 13:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 16:31 [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS Janusz Dziedzic
2021-10-26 13:42 ` Alex Elder [this message]
2021-10-26 18:11 ` Janusz Dziedzic
-- strict thread matches above, loose matches on Subject: below --
2018-04-27 14:03 Alex Elder
2018-09-28 11:41 ` Alex Elder
2018-09-28 12:26 ` Niklas Cassel
2018-09-28 13:23 ` Alex Elder
2018-09-28 14:00 ` Niklas Cassel
2018-09-28 17:21 ` Bjorn Andersson
2018-09-28 17:29 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39561c73-732e-bc38-e250-a0bdf51b09f9@linaro.org \
--to=elder@linaro.org \
--cc=janusz.dziedzic@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.