From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: bhupinder.thakur@linaro.org, volodymyr_babchuk@epam.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2 3/7] xen/arm: traps: Export a bunch of helpers to handle emulation
Date: Wed, 13 Sep 2017 09:52:25 +0100 [thread overview]
Message-ID: <39650ab8-db2c-a126-95b5-781d3beac09b@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1709121423540.9439@sstabellini-ThinkPad-X260>
Hi,
On 09/12/2017 10:26 PM, Stefano Stabellini wrote:
>> +int check_conditional_instr(struct cpu_user_regs *regs, const union hsr hsr);
>> +
>> +void advance_pc(struct cpu_user_regs *regs, const union hsr hsr);
>> +
>> +void inject_undef_exception(struct cpu_user_regs *regs, const union hsr hsr);
>> +
>> +void handle_raz_wi(struct cpu_user_regs *regs, int regidx, bool read,
>> + const union hsr hsr, int min_el);
>> +
>> +void handle_wo_wi(struct cpu_user_regs *regs, int regidx, bool read,
>> + const union hsr hsr, int min_el);
>> +
>> +void handle_ro_raz(struct cpu_user_regs *regs, int regidx, bool read,
>> + const union hsr hsr, int min_el);
>>
>
> Could you please copy or move the simple one-line comments we have in
> traps.c here as well to describe these functions? Such as "Read only as
> read as zero" and "Read as zero and write ignore".
I will do that.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-09-13 8:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 10:36 [PATCH v2 0/7] xen/arm: Clean-up traps.c Julien Grall
2017-09-12 10:36 ` [PATCH v2 1/7] xen/arm: traps: Re-order the includes alphabetically Julien Grall
2017-09-12 20:59 ` Stefano Stabellini
2017-09-12 10:36 ` [PATCH v2 2/7] xen/arm: Move arch/arm/vtimer.h to include/asm-arm/vtimer.h Julien Grall
2017-09-12 21:02 ` Stefano Stabellini
2017-09-12 10:36 ` [PATCH v2 3/7] xen/arm: traps: Export a bunch of helpers to handle emulation Julien Grall
2017-09-12 21:26 ` Stefano Stabellini
2017-09-13 8:52 ` Julien Grall [this message]
2017-09-12 10:36 ` [PATCH v2 4/7] xen/arm: Move sysreg emulation outside of traps.c Julien Grall
2017-09-12 21:40 ` Stefano Stabellini
2017-09-12 10:36 ` [PATCH v2 5/7] xen/arm: Move co-processor " Julien Grall
2017-09-12 21:43 ` Stefano Stabellini
2017-09-12 10:36 ` [PATCH v2 6/7] xen/arm: Move sysregs.h in arm64 sub-directory Julien Grall
2017-09-12 21:49 ` Stefano Stabellini
2017-09-12 10:36 ` [PATCH v2 7/7] xen/arm: Limit the scope of cpregs.h Julien Grall
2017-09-12 21:53 ` Stefano Stabellini
2017-09-13 9:11 ` Julien Grall
2017-09-13 21:13 ` Stefano Stabellini
2017-09-14 16:58 ` Julien Grall
2017-09-12 21:57 ` [PATCH v2 0/7] xen/arm: Clean-up traps.c Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39650ab8-db2c-a126-95b5-781d3beac09b@arm.com \
--to=julien.grall@arm.com \
--cc=bhupinder.thakur@linaro.org \
--cc=sstabellini@kernel.org \
--cc=volodymyr_babchuk@epam.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.